Greyish origin. #43531

New Issue

Łukasz Debita · 2015-02-02T18:13:28+01:00

Łukasz Debita commented

2015-02-02 18:13:28 +01:00

Blender 2.73a (and 2.73 also had that problem).

//It's not a very disturbing bug, but it is, so I want to help ; )

Sometimes when I work with blender I see that greyish origins. I work a lot with projects started in Blender 2.72, maybe it has something with that.

Here is video with my awful english, sorry ; )
https://www.youtube.com/watch?v=3eFfLHD-XuM

Exact steps for others to reproduce the error

You should see it just when projcet will be opened.
Here's the file:
http://www24.zippyshare.com/v/a8k7iUGf/file.html

Blender 2.73a (and 2.73 also had that problem). //It's not a very disturbing bug, but it is, so I want to help ; ) Sometimes when I work with blender I see that greyish origins. I work a lot with projects started in Blender 2.72, maybe it has something with that. Here is video with my awful english, sorry ; ) https://www.youtube.com/watch?v=3eFfLHD-XuM **Exact steps for others to reproduce the error** You should see it just when projcet will be opened. Here's the file: http://www24.zippyshare.com/v/a8k7iUGf/file.html

Łukasz Debita commented

2015-02-02 18:13:28 +01:00

Changed status to: 'Open'

Łukasz Debita commented

2015-02-02 18:13:28 +01:00

Added subscriber: @LukaszDebita

Campbell Barton commented

2015-02-02 22:30:06 +01:00

Added subscribers: @Psy-Fi, @ideasman42

Campbell Barton commented

2015-02-02 22:30:06 +01:00

This can happen when multiple objects are selected, or when the active object isnt selected.

@Psy-Fi, what do you think about this?

P192: Possible fix for #43531

diff --git a/source/blender/editors/space_view3d/drawobject.c b/source/blender/editors/space_view3d/drawobject.c
index 0d0ef72..e3b9740 100644
--- a/source/blender/editors/space_view3d/drawobject.c
+++ b/source/blender/editors/space_view3d/drawobject.c
@@ -737,6 +737,10 @@ static void drawcentercircle(View3D *v3d, RegionView3D *rv3d, const float co[3],
 	const float size = ED_view3d_pixel_size(rv3d, co) * (float)U.obcenter_dia * 0.5f;
 	float verts[CIRCLE_RESOL][3];
 
+	glEnable(GL_POLYGON_OFFSET_FILL);
+	glEnable(GL_POLYGON_OFFSET_LINE);
+	glPolygonOffset(-1.0, -10000.0);
+
 	/* using gldepthfunc guarantees that it does write z values,
 	 * but not checks for it, so centers remain visible independent order of drawing */
 	if (v3d->zbuf) glDepthFunc(GL_ALWAYS);
@@ -771,6 +775,9 @@ static void drawcentercircle(View3D *v3d, RegionView3D *rv3d, const float co[3],
 
 	glDisable(GL_BLEND);
 
+	glDisable(GL_POLYGON_OFFSET_LINE);
+	glDisable(GL_POLYGON_OFFSET_FILL);
+
 	if (v3d->zbuf) glDepthFunc(GL_LEQUAL);
 }

Seems a bit of a hack, but its kind-of correct if you want these to draw ontop of everything else, in Blender 2.4x these were drawn as bitmaps in 2d.

Note, while its nice to fix glitches like this, we could set it as TODO. since viewport needs work and this isn't breaking Blender.

This can happen when multiple objects are selected, or when the active object isnt selected. @Psy-Fi, what do you think about this? [P192: Possible fix for #43531](https://archive.blender.org/developer/P192.txt) ```diff diff --git a/source/blender/editors/space_view3d/drawobject.c b/source/blender/editors/space_view3d/drawobject.c index 0d0ef72..e3b9740 100644 --- a/source/blender/editors/space_view3d/drawobject.c +++ b/source/blender/editors/space_view3d/drawobject.c @@ -737,6 +737,10 @@ static void drawcentercircle(View3D *v3d, RegionView3D *rv3d, const float co[3], const float size = ED_view3d_pixel_size(rv3d, co) * (float)U.obcenter_dia * 0.5f; float verts[CIRCLE_RESOL][3]; + glEnable(GL_POLYGON_OFFSET_FILL); + glEnable(GL_POLYGON_OFFSET_LINE); + glPolygonOffset(-1.0, -10000.0); + /* using gldepthfunc guarantees that it does write z values, * but not checks for it, so centers remain visible independent order of drawing */ if (v3d->zbuf) glDepthFunc(GL_ALWAYS); @@ -771,6 +775,9 @@ static void drawcentercircle(View3D *v3d, RegionView3D *rv3d, const float co[3], glDisable(GL_BLEND); + glDisable(GL_POLYGON_OFFSET_LINE); + glDisable(GL_POLYGON_OFFSET_FILL); + if (v3d->zbuf) glDepthFunc(GL_LEQUAL); } ``` ---- *Seems a bit of a hack, but its kind-of correct if you want these to draw ontop of everything else, in Blender 2.4x these were drawn as bitmaps in 2d.* Note, while its nice to fix glitches like this, we could set it as TODO. since viewport needs work and this isn't breaking Blender.

Antonis Ryakiotakis was assigned by Campbell Barton

2015-02-02 22:30:40 +01:00

Sergey Sharybin commented

2015-02-03 09:14:04 +01:00

Added subscriber: @Sergey

Sergey Sharybin commented

2015-02-03 09:14:04 +01:00

@ideasman42, this seems ok to me, not sure why you call it a hack. Just makes it so GL state is known. Could probably be cleaned up a bit together with rest of drawing code to avoid possible redundant state changes, but that does not belong to this bugfix IMO.

Campbell Barton commented

2015-02-03 10:22:17 +01:00

@Sergey, seems like there could be a more direct way to write into 0.0 depth in the buffer instead of offsetting existing depth some arbitrary amount.

blender-admin commented

2015-02-05 07:01:58 +01:00

This issue was referenced by 57e1a5373f

This issue was referenced by 57e1a5373f41e0cd6c628abdc836fd807ffc4adf

Campbell Barton commented

2015-02-05 07:02:45 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2015-02-05 07:02:45 +01:00

Campbell Barton commented

2015-02-05 07:02:46 +01:00

Closed by commit 57e1a5373f.

Closed by commit 57e1a5373f.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Greyish origin. #43531