crash with border select (many objects) #43785

New Issue

Ronny G · 2015-02-23T12:32:12+01:00

Ronny G commented

2015-02-23 12:32:12 +01:00

System Information
ubuntu 14.04, 630gt, 4930k 4.5ghz

Blender Version
Broken: 2.73.5, 26f9a92

Exact steps for others to reproduce the error

open the blend file
border select around all empties
crash

warning this blend contains 43200 empties!

empties.blend

**System Information** ubuntu 14.04, 630gt, 4930k 4.5ghz **Blender Version** Broken: 2.73.5, 26f9a92 **Exact steps for others to reproduce the error** 1. open the blend file 2. border select around all empties 3. crash **warning this blend contains 43200 empties!** [empties.blend](https://archive.blender.org/developer/F145402/empties.blend)

Ronny G commented

2015-02-23 12:32:12 +01:00

Changed status to: 'Open'

Ronny G commented

2015-02-23 12:32:12 +01:00

Added subscriber: @nudelZ

Ronny G commented

2015-02-23 12:52:31 +01:00

ok found something

with "opengl select" nothing happens (no selection) but with "occlusion queries" it crashes

ok found something - > with "opengl select" nothing happens (no selection) but with "occlusion queries" it crashes

Wolfgang Faehnle commented

2015-02-23 12:59:04 +01:00

Added subscriber: @mib2berlin

Wolfgang Faehnle commented

2015-02-23 12:59:04 +01:00

Can verify on:

Opensuse 13.2/64
Intel i5 3770K
GTX 760 4 GB (Display)
GTX 560Ti 1.28 GB 448 Cores
Driver 346.29

With opengl select border select does not work, hotkey a do.

Cheers, mib

Can verify on: Opensuse 13.2/64 Intel i5 3770K GTX 760 4 GB (Display) GTX 560Ti 1.28 GB 448 Cores Driver 346.29 With opengl select border select does not work, hotkey a do. Cheers, mib

Julian Eisel commented

2015-02-23 13:45:03 +01:00

Added subscriber: @JulianEisel

Julian Eisel commented

2015-02-23 13:45:03 +01:00

It works if you zoom in a bit, so I'd guess it's either an issue with the high amount of objects, or just another presicion issue :/

Antonis Ryakiotakis was assigned by Julian Eisel

2015-02-23 13:45:20 +01:00

Julian Eisel commented

2015-02-23 13:51:06 +01:00

Eek, just noticed I'm getting a "Too many objects in select buffer" error, so seems like this is a limit of the OGL selection methods?

Campbell Barton commented

2015-02-23 22:55:04 +01:00

Added subscribers: @Psy-Fi, @ideasman42

Campbell Barton commented

2015-02-23 22:55:04 +01:00

@Psy-Fi, looks like this is just missing multiply checking buffer bounds P205: Fix for #43785

diff --git a/source/blender/gpu/intern/gpu_select.c b/source/blender/gpu/intern/gpu_select.c
index 35a39b2..d51d0da 100644
--- a/source/blender/gpu/intern/gpu_select.c
+++ b/source/blender/gpu/intern/gpu_select.c
@@ -180,6 +180,7 @@ unsigned int GPU_select_end(void)
 		hits = glRenderMode(GL_RENDER);
 	}
 	else {
+		const unsigned int bufsize_4x = g_query_state.bufsize * 4;
 		int i;
 
 		if (g_query_state.query_issued) {
@@ -191,7 +192,7 @@ unsigned int GPU_select_end(void)
 			glGetQueryObjectuivARB(g_query_state.queries- [x], GL_QUERY_RESULT_ARB, &result);
 			if (result > 0) {
 				if (g_query_state.mode != GPU_SELECT_NEAREST_SECOND_PASS) {
-					if (hits < g_query_state.bufsize) {
+					if (hits < bufsize_4x) {
 						g_query_state.buffer[hits * 4] = 1;
 						g_query_state.buffer[hits * 4 + 1] = 0xFFFF;
 						g_query_state.buffer[hits * 4 + 2] = 0xFFFF;

note. there are a few of buffer[4 * MAXPICKBUF]; these should be made into buffer[MAXPICKBUF]; if this patch is applied.

@Psy-Fi, looks like this is just missing multiply checking buffer bounds [P205: Fix for #43785](https://archive.blender.org/developer/P205.txt) ```diff diff --git a/source/blender/gpu/intern/gpu_select.c b/source/blender/gpu/intern/gpu_select.c index 35a39b2..d51d0da 100644 --- a/source/blender/gpu/intern/gpu_select.c +++ b/source/blender/gpu/intern/gpu_select.c @@ -180,6 +180,7 @@ unsigned int GPU_select_end(void) hits = glRenderMode(GL_RENDER); } else { + const unsigned int bufsize_4x = g_query_state.bufsize * 4; int i; if (g_query_state.query_issued) { @@ -191,7 +192,7 @@ unsigned int GPU_select_end(void) glGetQueryObjectuivARB(g_query_state.queries- [x], GL_QUERY_RESULT_ARB, &result); if (result > 0) { if (g_query_state.mode != GPU_SELECT_NEAREST_SECOND_PASS) { - if (hits < g_query_state.bufsize) { + if (hits < bufsize_4x) { g_query_state.buffer[hits * 4] = 1; g_query_state.buffer[hits * 4 + 1] = 0xFFFF; g_query_state.buffer[hits * 4 + 2] = 0xFFFF; ``` note. there are a few of `buffer[4 * MAXPICKBUF];` these should be made into `buffer[MAXPICKBUF];` if this patch is applied.

blender-admin commented

2015-02-24 17:19:07 +01:00

This issue was referenced by 50e9868abe

This issue was referenced by 50e9868abe11bd2ed0173b7a51cf129d77e4389e

Antonis Ryakiotakis commented

2015-02-24 17:20:05 +01:00

Changed status from 'Open' to: 'Resolved'

Antonis Ryakiotakis closed this issue

2015-02-24 17:20:05 +01:00

Antonis Ryakiotakis commented

2015-02-24 17:20:05 +01:00

Closed by commit 50e9868abe.

Closed by commit 50e9868abe.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

crash with border select (many objects) #43785