Freestyle lines in Cycles are in an unexpected color space #44048

New Issue

Sam Brubaker · 2015-03-19T19:40:29+01:00

Sam Brubaker commented

2015-03-19 19:40:29 +01:00

Version: 2.73 (but also 2.74 rc2) linux 64

How to reproduce:

Open the attached file and inspect the simple blue cube material and freestyle settings.
Notice that the line color and emission color values are identical.
Render the scene and notice that the emission shader emits exactly the same color as set in the properties, but the freestyle line is much darker than expected.
Try the same thing in BI and notice that the freestyle color space is not affected in this way when rendered with BI.

If this is an intentional aspect of Freestyle in Cycles, I cannot figure out why.

Cycles_Freestyle_Color_space.blend

Version: 2.73 (but also 2.74 rc2) linux 64 How to reproduce: - Open the attached file and inspect the simple blue cube material and freestyle settings. - Notice that the line color and emission color values are identical. - Render the scene and notice that the emission shader emits exactly the same color as set in the properties, but the freestyle line is much darker than expected. - Try the same thing in BI and notice that the freestyle color space is not affected in this way when rendered with BI. If this is an intentional aspect of Freestyle in Cycles, I cannot figure out why. [Cycles_Freestyle_Color_space.blend](https://archive.blender.org/developer/F153248/Cycles_Freestyle_Color_space.blend)

Sam Brubaker commented

2015-03-19 19:40:29 +01:00

Changed status to: 'Open'

Sam Brubaker commented

2015-03-19 19:40:29 +01:00

Added subscriber: @rocketman

Tamito Kajiyama was assigned by Julian Eisel

2015-03-19 20:54:56 +01:00

Julian Eisel commented

2015-03-19 20:54:56 +01:00

Added subscribers: @kjym3, @JulianEisel

Julian Eisel commented

2015-03-19 20:54:56 +01:00

@kjym3, Sounds similar to #43624, maybe same fix is needed again?

Tamito Kajiyama commented

2015-03-20 02:57:45 +01:00

Thanks for the problem report. The issue looks like related to color management. I will look into it and come back to you with updates.

Tamito Kajiyama commented

2015-03-20 17:41:11 +01:00

Added subscribers: @Sergey, @ThomasDinges

Tamito Kajiyama commented

2015-03-20 17:41:11 +01:00

Freestyle generates a temporary scene to render strokes using Cycles. The temporary scene is populated by mesh objects representing the strokes. The upper half of the screen capture below shows the (slightly simplified) shader setttings used for the stroke meshes. Stroke colors are taken from a vertex color layer ('Color') and fed to an Emission node. As shown in the Python console at the left bottom of the screen capture, the color in the vertex color layer matches with the Freestyle Line color in question. The same screen capture confirms that the line color in the rendering result is darker than it should be.

Now if the Freestyle Line color is specified directly by the Emission node (without relying on the vertex color layer) as shown in the lower half of the image below, then the rendered line color becomes correct.

So the problem comes from the color sources from which the diffuse color of stroke meshes is taken.

@Sergey, @ThomasDinges, do you guys have any insight about the documented color differences between an Emission color and a vertex color layer in Cycles?

Freestyle generates a temporary scene to render strokes using Cycles. The temporary scene is populated by mesh objects representing the strokes. The upper half of the screen capture below shows the (slightly simplified) shader setttings used for the stroke meshes. Stroke colors are taken from a vertex color layer ('Color') and fed to an Emission node. As shown in the Python console at the left bottom of the screen capture, the color in the vertex color layer matches with the Freestyle Line color in question. The same screen capture confirms that the line color in the rendering result is darker than it should be. ![vertex_colors.png](https://archive.blender.org/developer/F153436/vertex_colors.png) Now if the Freestyle Line color is specified directly by the Emission node (without relying on the vertex color layer) as shown in the lower half of the image below, then the rendered line color becomes correct. So the problem comes from the color sources from which the diffuse color of stroke meshes is taken. @Sergey, @ThomasDinges, do you guys have any insight about the documented color differences between an Emission color and a vertex color layer in Cycles?

Sergey Sharybin commented

2015-03-20 18:07:37 +01:00

I don't think it's something cycles-specific. All the light (including Emission) in render engines is in linear space. And vertex color in blender is in sRGB space i would think.

So what you can do is to linearize the color when creating emission shader by calling srgb_to_linearrgb_v3_v3. It's not totally correct from the CM pipeline, but it's as good as we can do now.

I don't think it's something cycles-specific. All the light (including Emission) in render engines is in linear space. And vertex color in blender is in sRGB space i would think. So what you can do is to linearize the color when creating emission shader by calling `srgb_to_linearrgb_v3_v3`. It's not totally correct from the CM pipeline, but it's as good as we can do now.

blender-admin commented

2015-10-10 18:44:19 +02:00

This issue was referenced by fc7c856da2

This issue was referenced by fc7c856da21765094f53ba2a8110365b737c6103

Brecht Van Lommel commented

2015-10-10 18:50:29 +02:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2015-10-10 18:50:29 +02:00

Tamito Kajiyama commented

2015-10-12 06:10:00 +02:00

The fix is very much appreciated, thanks Brecht.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Freestyle lines in Cycles are in an unexpected color space #44048