To set stereo 3d mode to Time Sequential may crash Blender #44688

New Issue

Dalai Felinto · 2015-05-13T00:11:37+02:00

Dalai Felinto commented

2015-05-13 00:11:37 +02:00

System Information
OSX 10.9.5 but I also suspect Linux have this issue.

Short description of error
When setting 3D to Time Sequential (aka Quadbuffer) Blender duplicates the window (see wm_stereo3d_set_exec), when 'time sequential is not supported, the menu lingers open, and leads to a crash after I try to press OK, or simply click around the UI.

Also, if I try to change the stereo mode in the python console it works fine:
bpy.ops.wm.set_stereo_3d(display_mode='TIMESEQUENTIAL')

Exact steps for others to reproduce the error

Turn on Views (in the Render Layer panel)
Set Stereo 3D mode to Time Sequential (in the Info Header > Window > Set Stereo 3D, 'Time Sequential')

Now quit the menu (esc), or just click anywhere in the UI and boom !

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: 13 at address: 0x0000000000000000
0x000000010002df45 in wm_operator_ui_popup_cancel (C=0x107f11ea8, userData=0x108fd6ea8) at //blender/windowmanager/intern/wm_operators.c:1657
1657			if (op->type->cancel) {

This may be related to the 'broken pop UI' I get when Quadbuffer is not supported:

(look at the exclamation mark on the left)

**System Information** OSX 10.9.5 but I also suspect Linux have this issue. **Short description of error** When setting 3D to Time Sequential (aka Quadbuffer) Blender duplicates the window (see `wm_stereo3d_set_exec`), when 'time sequential is not supported, the menu lingers open, and leads to a crash after I try to press OK, or simply click around the UI. Also, if I try to change the stereo mode in the python console it works fine: `bpy.ops.wm.set_stereo_3d(display_mode='TIMESEQUENTIAL')` **Exact steps for others to reproduce the error** * Turn on Views (in the Render Layer panel) * Set Stereo 3D mode to Time Sequential (in the Info Header > Window > Set Stereo 3D, 'Time Sequential') Now quit the menu (esc), or just click anywhere in the UI and boom ! ``` Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: 13 at address: 0x0000000000000000 0x000000010002df45 in wm_operator_ui_popup_cancel (C=0x107f11ea8, userData=0x108fd6ea8) at //blender/windowmanager/intern/wm_operators.c:1657 1657 if (op->type->cancel) { ``` This may be related to the 'broken pop UI' I get when Quadbuffer is not supported: ![time-sequential.jpg](https://archive.blender.org/developer/F173628/time-sequential.jpg) (look at the exclamation mark on the left)

Dalai Felinto commented

2015-05-13 00:11:37 +02:00

Changed status to: 'Open'

Dalai Felinto commented

2015-05-13 00:11:37 +02:00

Added subscriber: @dfelinto

perfection cat commented

2015-05-13 05:09:40 +02:00

Added subscriber: @sindra1961

perfection cat commented

2015-05-13 05:09:40 +02:00

It crashes when I perform something in the pop-up window after a warning mark appeared.
However, it does not crash when I click another place of 3dview in defiance of it.
The error of not supporting Quad-buffer in a log file is recorded.

result.txt

It crashes when I perform something in the pop-up window after a warning mark appeared. However, it does not crash when I click another place of 3dview in defiance of it. The error of not supporting Quad-buffer in a log file is recorded. [result.txt](https://archive.blender.org/developer/F173743/result.txt)

Dalai Felinto commented

2015-05-13 07:26:23 +02:00

Added subscriber: @ideasman42

Dalai Felinto commented

2015-05-13 07:26:23 +02:00

@ideasman42 any chance you could look at that? This seems related to context/operator getting buggy after windows duplication

Sergey Sharybin commented

2015-05-13 11:34:27 +02:00

Added subscriber: @Sergey

Dalai Felinto commented

2015-05-20 06:39:33 +02:00

For the records, in some systems, there is a crash that happens prior to the real issue. So for general testing the patch below helps to reproduce the issue in some linuxes too.

diff --git a/source/blender/windowmanager/intern/wm_stereo.c b/source/blender/windowmanager/intern/wm_stereo.c
index 717583f..cffcbd8 100644
--- a/source/blender/windowmanager/intern/wm_stereo.c
+++ b/source/blender/windowmanager/intern/wm_stereo.c
@@ -463,8 +463,23 @@ int wm_stereo3d_set_exec(bContext *C, wmOperator *op)
        }
 
        s3dd = op->customdata;
-       *win->stereo3d_format = s3dd->stereo3d_format;
+       //*win->stereo3d_format = s3dd->stereo3d_format;
 
+#if 1
+       if (s3dd->stereo3d_format.display_mode == S3D_DISPLAY_PAGEFLIP) {
+               /* pageflip requires a new window to be created with the proper OS flags */
+               if (wm_window_duplicate_exec(C, op) == OPERATOR_FINISHED) {
+                       wmWindow *win_new = wm->windows.last;
+                       wm_window_close(C, wm, win_new);
+                       BKE_report(op->reports, RPT_ERROR, "Quad-buffer not supported by the system");
+               }
+               else {
+                       BKE_report(op->reports, RPT_ERROR,
+                                  "Failed to create a window compatible with the time sequential display method");
+                       win->stereo3d_format->display_mode = prev_display_mode;
+               }
+       }
+#else
        if (prev_display_mode == S3D_DISPLAY_PAGEFLIP &&
            prev_display_mode != win->stereo3d_format->display_mode)
        {
@@ -497,6 +512,7 @@ int wm_stereo3d_set_exec(bContext *C, wmOperator *op)
                        win->stereo3d_format->display_mode = prev_display_mode;
                }
        }
+#endif
 
        if (wm_stereo3d_is_fullscreen_required(s3dd->stereo3d_format.display_mode)) {
                if (!is_fullscreen) {

For the records, in some systems, there is a crash that happens prior to the real issue. So for general testing the patch below helps to reproduce the issue in some linuxes too. ``` diff --git a/source/blender/windowmanager/intern/wm_stereo.c b/source/blender/windowmanager/intern/wm_stereo.c index 717583f..cffcbd8 100644 --- a/source/blender/windowmanager/intern/wm_stereo.c +++ b/source/blender/windowmanager/intern/wm_stereo.c @@ -463,8 +463,23 @@ int wm_stereo3d_set_exec(bContext *C, wmOperator *op) } s3dd = op->customdata; - *win->stereo3d_format = s3dd->stereo3d_format; + //*win->stereo3d_format = s3dd->stereo3d_format; +#if 1 + if (s3dd->stereo3d_format.display_mode == S3D_DISPLAY_PAGEFLIP) { + /* pageflip requires a new window to be created with the proper OS flags */ + if (wm_window_duplicate_exec(C, op) == OPERATOR_FINISHED) { + wmWindow *win_new = wm->windows.last; + wm_window_close(C, wm, win_new); + BKE_report(op->reports, RPT_ERROR, "Quad-buffer not supported by the system"); + } + else { + BKE_report(op->reports, RPT_ERROR, + "Failed to create a window compatible with the time sequential display method"); + win->stereo3d_format->display_mode = prev_display_mode; + } + } +#else if (prev_display_mode == S3D_DISPLAY_PAGEFLIP && prev_display_mode != win->stereo3d_format->display_mode) { @@ -497,6 +512,7 @@ int wm_stereo3d_set_exec(bContext *C, wmOperator *op) win->stereo3d_format->display_mode = prev_display_mode; } } +#endif if (wm_stereo3d_is_fullscreen_required(s3dd->stereo3d_format.display_mode)) { if (!is_fullscreen) { ```

Campbell Barton was assigned by Sergey Sharybin

2015-05-25 20:28:03 +02:00

Sergey Sharybin commented

2015-05-25 20:28:03 +02:00

@ideasman42, afraid you know this are better than me. Mind having a look and give some help to Dalai?

blender-admin commented

2015-05-28 10:46:15 +02:00

This issue was referenced by d9b6768521

This issue was referenced by d9b67685210275a71bd22b4f8c35590bf795eb47

Campbell Barton commented

2015-05-28 10:47:01 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2015-05-28 10:47:01 +02:00

Dalai Felinto commented

2015-05-28 13:51:23 +02:00

@ideasman42 after your commit I get the following crash:

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: 13 at address: 0x0000000000000000
0x00000001012f8537 in BLI_remlink (listbase=0x10b300408, vlink=0x10b65a768) at /Users/dfelinto/blender/git/blender/source/blender/blenlib/intern/listbase.c:111
111		if (link->next) link->next->prev = link->prev;
(gdb) bt
- 0  0x00000001012f8537 in BLI_remlink (listbase=0x10b300408, vlink=0x10b65a768) at /Users/dfelinto/blender/git/blender/source/blender/blenlib/intern/listbase.c:111
- 1  0x000000010001773b in wm_event_do_handlers (C=0x107f11d68) at /Users/dfelinto/blender/git/blender/source/blender/windowmanager/intern/wm_event_system.c:2468
- 2  0x000000010000bc1e in WM_main (C=0x107f11d68) at /Users/dfelinto/blender/git/blender/source/blender/windowmanager/intern/wm.c:487
- 3  0x0000000100007391 in main (argc=1, argv=0x7fff5fbff740) at /Users/dfelinto/blender/git/blender/source/creator/creator.c:1882
Current language:  auto; currently minimal

(OSX here) is it working in your computer? Do you see the error message popup?

@ideasman42 after your commit I get the following crash: ``` Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: 13 at address: 0x0000000000000000 0x00000001012f8537 in BLI_remlink (listbase=0x10b300408, vlink=0x10b65a768) at /Users/dfelinto/blender/git/blender/source/blender/blenlib/intern/listbase.c:111 111 if (link->next) link->next->prev = link->prev; (gdb) bt - 0 0x00000001012f8537 in BLI_remlink (listbase=0x10b300408, vlink=0x10b65a768) at /Users/dfelinto/blender/git/blender/source/blender/blenlib/intern/listbase.c:111 - 1 0x000000010001773b in wm_event_do_handlers (C=0x107f11d68) at /Users/dfelinto/blender/git/blender/source/blender/windowmanager/intern/wm_event_system.c:2468 - 2 0x000000010000bc1e in WM_main (C=0x107f11d68) at /Users/dfelinto/blender/git/blender/source/blender/windowmanager/intern/wm.c:487 - 3 0x0000000100007391 in main (argc=1, argv=0x7fff5fbff740) at /Users/dfelinto/blender/git/blender/source/creator/creator.c:1882 Current language: auto; currently minimal ``` (OSX here) is it working in your computer? Do you see the error message popup?

Campbell Barton commented

2015-06-02 11:03:56 +02:00

@dfelinto, could you try with 95b9d6d9c2 or later?

(I had to trick Blender into thinking the OpenGL state was OK to test the patch, think its fixed now)

@dfelinto, could you try with 95b9d6d9c2 or later? (I had to trick Blender into thinking the OpenGL state was OK to test the patch, think its fixed now)

Dalai Felinto commented

2015-06-02 16:28:37 +02:00

@ideasman42 it's almost there. When the window is NOT in fullscreen it no longer crashes. If I set fullscreen first (Alt+F11) I then get the same segfault as above (listbase.c:111)

Campbell Barton commented

2015-06-03 04:11:37 +02:00

@dfelinto, As you did before, could you make a patch which will crash? without the system having to support 3d hardware I don't have? :)

Re-opening bug so we dont forget about it for release.

@dfelinto, As you did before, could you make a patch which will crash? *without the system having to support 3d hardware I don't have?* :) Re-opening bug so we dont forget about it for release.

Campbell Barton commented

2015-06-03 04:18:28 +02:00

Changed status from 'Resolved' to: 'Open'

Campbell Barton reopened this issue

2015-06-03 04:18:28 +02:00

perfection cat commented

2015-06-03 04:22:01 +02:00

Removed subscriber: @sindra1961

Dalai Felinto commented

2015-06-03 19:22:34 +02:00

Added subscriber: @ThomasDinges

Dalai Felinto commented

2015-06-03 19:22:34 +02:00

I can't reproduce the issue (Alt+F11) on linux, @ThomasDinges can you try that on windows to see if it's OSX specific?

How to test:

Alt+F11
Turn on Views
Set Stereo 3D mode to Time Sequential

I can't reproduce the issue (Alt+F11) on linux, @ThomasDinges can you try that on windows to see if it's OSX specific? How to test: 1. Alt+F11 2. Turn on Views 3. Set Stereo 3D mode to Time Sequential

Campbell Barton commented

2015-06-08 08:21:43 +02:00

Managed to get a crash with the popup, should be really fixed this time. b54e95a5c8

But theres still a crash:

Alt+F10
Alt+F11
Set Stereo 3D -> Time Sequential
- 0 0x43c2543 in BLI_strnlen /src/blender/source/blender/blenlib/intern/string.c:726
- 1 0x43bee6b in BLI_strncpy /src/blender/source/blender/blenlib/intern/string.c:116
- 2 0xa44055 in wm_window_copy /src/blender/source/blender/windowmanager/intern/wm_window.c:258
- 3 0xa4798d in wm_window_duplicate_exec /src/blender/source/blender/windowmanager/intern/wm_window.c:622
- 4 0xa52109 in wm_stereo3d_set_exec /src/blender/source/blender/windowmanager/intern/wm_stereo.c:484
- 5 0x9d598b in wm_operator_exec /src/blender/source/blender/windowmanager/intern/wm_event_system.c:771
- 6 0x9d5f79 in WM_operator_call_ex /src/blender/source/blender/windowmanager/intern/wm_event_system.c:823
- 7 0xa1cfa1 in dialog_exec_cb /src/blender/source/blender/windowmanager/intern/wm_operators.c:1563
- 8 0x14f7336 in ui_apply_but_funcs_after /src/blender/source/blender/editors/interface/interface_handlers.c:742
- 9 0x1560a17 in ui_popup_handler /src/blender/source/blender/editors/interface/interface_handlers.c:9810
- 10 0x9d2998 in wm_handler_ui_call /src/blender/source/blender/windowmanager/intern/wm_event_system.c:457
- 11 0x9e07a8 in wm_handlers_do_intern /src/blender/source/blender/windowmanager/intern/wm_event_system.c:2008
- 12 0x9e1112 in wm_handlers_do /src/blender/source/blender/windowmanager/intern/wm_event_system.c:2092
- 13 0x9e36d4 in wm_event_do_handlers /src/blender/source/blender/windowmanager/intern/wm_event_system.c:2375
- 14 0x9b5a9b in WM_main /src/blender/source/blender/windowmanager/intern/wm.c:487
- 15 0x9b2470 in main /src/blender/source/creator/creator.c:1887
- 16 0x7f7778edc78f in __libc_start_main (/usr/lib/libc.so.6+0x2078f)
- 17 0x9ab4a8 in _start (/src/cmake_debug/bin/blender+0x9ab4a8)

Managed to get a crash with the popup, should be really fixed this time. b54e95a5c8 But theres still a crash: - Alt+F10 - Alt+F11 - Set Stereo 3D -> Time Sequential - 0 0x43c2543 in BLI_strnlen /src/blender/source/blender/blenlib/intern/string.c:726 - 1 0x43bee6b in BLI_strncpy /src/blender/source/blender/blenlib/intern/string.c:116 - 2 0xa44055 in wm_window_copy /src/blender/source/blender/windowmanager/intern/wm_window.c:258 - 3 0xa4798d in wm_window_duplicate_exec /src/blender/source/blender/windowmanager/intern/wm_window.c:622 - 4 0xa52109 in wm_stereo3d_set_exec /src/blender/source/blender/windowmanager/intern/wm_stereo.c:484 - 5 0x9d598b in wm_operator_exec /src/blender/source/blender/windowmanager/intern/wm_event_system.c:771 - 6 0x9d5f79 in WM_operator_call_ex /src/blender/source/blender/windowmanager/intern/wm_event_system.c:823 - 7 0xa1cfa1 in dialog_exec_cb /src/blender/source/blender/windowmanager/intern/wm_operators.c:1563 - 8 0x14f7336 in ui_apply_but_funcs_after /src/blender/source/blender/editors/interface/interface_handlers.c:742 - 9 0x1560a17 in ui_popup_handler /src/blender/source/blender/editors/interface/interface_handlers.c:9810 - 10 0x9d2998 in wm_handler_ui_call /src/blender/source/blender/windowmanager/intern/wm_event_system.c:457 - 11 0x9e07a8 in wm_handlers_do_intern /src/blender/source/blender/windowmanager/intern/wm_event_system.c:2008 - 12 0x9e1112 in wm_handlers_do /src/blender/source/blender/windowmanager/intern/wm_event_system.c:2092 - 13 0x9e36d4 in wm_event_do_handlers /src/blender/source/blender/windowmanager/intern/wm_event_system.c:2375 - 14 0x9b5a9b in WM_main /src/blender/source/blender/windowmanager/intern/wm.c:487 - 15 0x9b2470 in main /src/blender/source/creator/creator.c:1887 - 16 0x7f7778edc78f in __libc_start_main (/usr/lib/libc.so.6+0x2078f) - 17 0x9ab4a8 in _start (/src/cmake_debug/bin/blender+0x9ab4a8)

Dalai Felinto commented

2015-06-08 15:18:47 +02:00

@ideasman42 you don't even need Alt+F11 for this crash in string.c, "Alt+F10, Set Stereo 3D > Time Sequencial" is enough. I'll look at that. I still get the Alt + F11 crash, but it's probably OSX only.

Campbell Barton commented

2015-06-08 17:34:26 +02:00

@dfelinto,

Looks like making ED_screen_duplicate support non-normal screens will fix.
Just need to make sure the screen state remains valid at all times. (when using a temp screen for eg).

Note that testing different fixes here was getting problematic. Committed 962f764d58 to avoid calling operator exec to duplicate screen (so its easier to add args if we want).

@dfelinto, Looks like making `ED_screen_duplicate` support non-normal screens will fix. Just need to make sure the screen state remains valid at all times. (when using a temp screen for eg). Note that testing different fixes here was getting problematic. Committed 962f764d58 to avoid calling operator exec to duplicate screen (so its easier to add args if we want).

Campbell Barton removed their assignment 2015-06-08 17:45:45 +02:00

Dalai Felinto was assigned by Campbell Barton

2015-06-08 17:45:45 +02:00

Campbell Barton commented

2015-06-09 07:49:43 +02:00

@dfelinto, is this fixed now?

If not, would be good to note what fails exactly, AFAICS there were 2 bugs which are resolved.

@dfelinto, is this fixed now? If not, would be good to note what fails exactly, AFAICS there were 2 bugs which are resolved.

Dalai Felinto commented

2015-06-09 09:31:28 +02:00

@ideasman42 apart from the fullwindow (Alt + F11) issue in OSX, I believe the bug is fixed. I'm yet to confirm if we didn't break quadbuffer support for computers that can handle it, so I will wait to close this until later this week.

Campbell Barton commented

2015-06-09 11:36:22 +02:00

@dfelinto. maybe am being a bit picky - but the state of this report is confusing now.
If I had OSX and wanted to fix I wouldn't even know where to start.
Maybe this report could be closed,. Then open new report with remaining issue?

Its just this is potentially holding up release, so leaving it in some unknown state means its hard keep track of what needs doing.

@dfelinto. maybe am being a bit picky - but the state of this report is confusing now. If I had OSX and wanted to fix I wouldn't even know where to start. Maybe this report could be closed,. Then open new report with remaining issue? Its just this is potentially holding up release, so leaving it in some unknown state means its hard keep track of what needs doing.

Dalai Felinto commented

2015-06-10 21:09:30 +02:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2015-06-10 21:09:30 +02:00

Dalai Felinto commented

2015-06-10 21:09:30 +02:00

OK, I just tested master in a quadbuffer compatible station and things are working from either fullscreen (Alt+F11) or windowed modes.

I'm closing this now and I'll report the fullscreen + OSX issue separately later.

Out of curiosity, when in fullscreen (Alt + F11) in Linux, after toggling Pageflip mode, the new window is not fullscreen. I think this is a minor drawback, so nothing to worry about.

OK, I just tested master in a quadbuffer compatible station and things are working from either fullscreen (Alt+F11) or windowed modes. I'm closing this now and I'll report the fullscreen + OSX issue separately later. Out of curiosity, when in fullscreen (Alt + F11) in Linux, after toggling Pageflip mode, the new window is not fullscreen. I think this is a minor drawback, so nothing to worry about.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

To set stereo 3d mode to Time Sequential may crash Blender #44688