Blender hangs when using masking, dilate-erode and soften node #44871

New Issue

Sebastian Koenig · 2015-05-28T14:41:36+02:00

Sebastian Koenig commented

2015-05-28 14:41:36 +02:00

System Information
OSX 10.10.2, GTX970

Blender Version
Broken: 000dfc0
Worked: 2.74

Short description of error
This is a bit of a weird bug.
Blender hangs when combining the soften node and the dilate erode node together with masking. It only happens if soften and dilate are active, if one of them is muted blender works fine. I suspect the dilate/erode node is problematic in some way anyway, because if i set it to linear feathering, i get these issues in the console: http://www.pasteall.org/58689
I guess the interesting line here is "BLI_assert failed: /Volumes/blender/source/blender/compositor/operations/COM_BlurBaseOperation.cpp:144, make_dist_fac_inverse(), at '0'"

Exact steps for others to reproduce the error
Open this file: linear_feather.blend
Press F12
Tweak the mask rapidly, maybe by moving its center point quickly in small steps around. At some point blender just hangs and has to be killed. No errors in the console, not even with --debug or even using lldp. It's superweird. And: i couldn't reproduce on linux.

**System Information** OSX 10.10.2, GTX970 **Blender Version** Broken: 000dfc0 Worked: 2.74 **Short description of error** This is a bit of a weird bug. Blender hangs when combining the soften node and the dilate erode node together with masking. It only happens if soften and dilate are active, if one of them is muted blender works fine. I suspect the dilate/erode node is problematic in some way anyway, because if i set it to linear feathering, i get these issues in the console: http://www.pasteall.org/58689 I guess the interesting line here is "BLI_assert failed: /Volumes/blender/source/blender/compositor/operations/COM_BlurBaseOperation.cpp:144, make_dist_fac_inverse(), at '0'" **Exact steps for others to reproduce the error** Open this file: [linear_feather.blend](https://archive.blender.org/developer/F180792/linear_feather.blend) Press F12 Tweak the mask rapidly, maybe by moving its center point quickly in small steps around. At some point blender just hangs and has to be killed. No errors in the console, not even with --debug or even using lldp. It's superweird. And: i couldn't reproduce on linux.

Sebastian Koenig commented

2015-05-28 14:41:36 +02:00

Changed status to: 'Open'

Sebastian Koenig commented

2015-05-28 14:41:36 +02:00

Added subscriber: @sebastian_k

Aaron Carlisle commented

2015-05-28 15:05:03 +02:00

Added subscriber: @Blendify

Aaron Carlisle commented

2015-05-28 15:05:03 +02:00

I would try I build from build bot there were some threading issues that were fixed so it's worth a try

https://builder.blender.org/download/

I would try I build from build bot there were some threading issues that were fixed so it's worth a try https://builder.blender.org/download/

Sebastian Koenig commented

2015-05-28 15:07:10 +02:00

Added subscriber: @jensverwiebe

Sebastian Koenig commented

2015-05-28 15:07:10 +02:00

I tested buildbot, also @jensverwiebe could confirm the issue.

Antonis Ryakiotakis commented

2015-05-28 18:56:37 +02:00

Added subscriber: @Psy-Fi

Antonis Ryakiotakis commented

2015-05-28 18:56:37 +02:00

Meh, Indeed I can't reproduce issue on linux. I'm putting the file through valgrind but it's so sloooooow that I don't think it will be possible to find the issue easily.

Aaron Carlisle commented

2015-05-28 19:03:40 +02:00

nothing under windows

Bastien Montagne commented

2015-05-29 13:10:15 +02:00

Added subscriber: @mont29

Campbell Barton commented

2015-06-02 14:14:33 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2015-06-02 14:14:33 +02:00

Manged to redo the report, with address sanitizers thread checking, see: P228.

@Sergey, you worked most here before heres a proposed fix P229 ...

Posting here incase theres good reason to resolve some other way.

Updated: managed to find another race condition, needs further investigation.

Manged to redo the report, with address sanitizers thread checking, see: [P228](https://archive.blender.org/developer/P228.txt). @Sergey, you worked most here before heres a proposed fix [P229](https://archive.blender.org/developer/P229.txt) ... Posting here incase theres good reason to resolve some other way. ---- Updated: managed to find another race condition, needs further investigation.

Campbell Barton commented

2015-06-02 14:15:39 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2015-06-02 19:36:00 +02:00

@ideasman42, didn't see your comment before.. I've run into same report from hellgrind and your patch is correct. Please go ahead and commit it.

@sebastian_k, the assert failure you see is likely caused by the memory corruption. Did you manage to reproduce the hanging blender when running it from lldb? If so, having full threads backtrace will give some clues.

@ideasman42, didn't see your comment before.. I've run into same report from hellgrind and your patch is correct. Please go ahead and commit it. @sebastian_k, the assert failure you see is likely caused by the memory corruption. Did you manage to reproduce the hanging blender when running it from lldb? If so, having full threads backtrace will give some clues.

Campbell Barton commented

2015-06-03 03:23:42 +02:00

Checked this morning,

Found another race condition, 2 threads are using LOCK_DRAW_IMAGE at the same time (initImage and draw_image_main)

See stack trace: P230

note, when hanging there are 2 threads in BLI_lock_thread, one waiting on LOCK_VIEWER the other on LOCK_DRAW_IMAGE. however both threads lock LOCK_DRAW_IMAGE in their call-stack.

Checked this morning, Found another race condition, 2 threads are using `LOCK_DRAW_IMAGE` at the same time (`initImage` and `draw_image_main`) See stack trace: [P230](https://archive.blender.org/developer/P230.txt) note, when hanging there are 2 threads in `BLI_lock_thread`, one waiting on `LOCK_VIEWER` the other on `LOCK_DRAW_IMAGE`. however both threads lock `LOCK_DRAW_IMAGE` in their call-stack.

Sebastian Koenig commented

2015-06-04 09:32:28 +02:00

@Sergey I was able to reproduce with lldb, but that didn't seem to print anything. Are there any options or arguments I should run Blender with for threads backtrace?