Deleting brush closes Paint panel and creates duplicate brush when re-entering a Paint Mode #45258

New Issue

Dennis Brown · 2015-07-01T15:13:50+02:00

Dennis Brown commented

2015-07-01 15:13:50 +02:00

System Information
Windows 7 Pro SP1 x64
nVidia GTX 960

Blender Version
Broken: cf1bac3

Short description of error
When in Texture Paint mode for 3D View or UV/Image view, removing a brush removes the ability to use a brush at all by removing the Paint panel, as well as the Image Paint Tool options in the Brush menu. The only option is to exit the paint mode, and re-enter it. When doing so, The Brush brush in the list is copied and selected.

Exact steps for others to reproduce the error

Switch to UV/Image Editor, and switch from View mode to Paint mode
remove a brush via the Unlink button "X", and observe all tabs are removed, and only left with the Grease Pencil options
Switch back to View mode from Paint mode, and back to Paint mode to refresh the panels. Notice that the brush selected is now "Brush.001"

3a. You can also select Paint when in Paint mode to refresh the mode. Same results.
4. You can continue to unlink brushes, and Blender will continue to create more copies of the "Brush" brush.

Correct me if I'm wrong, but I believe this use to work the same as vertex paint mode even after 2.72, where you could delete brushes, but not lose the ability to continue working with other brushes.

I did look at the older tickets, but did not see anything regarding this issue, but did notice it was an issue in 2.74 as well when trying to find a "working" version.

**System Information** Windows 7 Pro SP1 x64 nVidia GTX 960 **Blender Version** Broken: cf1bac3 **Short description of error** When in Texture Paint mode for 3D View or UV/Image view, removing a brush removes the ability to use a brush at all by removing the Paint panel, as well as the Image Paint Tool options in the Brush menu. The only option is to exit the paint mode, and re-enter it. When doing so, The Brush brush in the list is copied and selected. **Exact steps for others to reproduce the error** 1. Switch to UV/Image Editor, and switch from View mode to Paint mode 2. remove a brush via the Unlink button "X", and observe all tabs are removed, and only left with the Grease Pencil options 3. Switch back to View mode from Paint mode, and back to Paint mode to refresh the panels. Notice that the brush selected is now "Brush.001" 3a. You can also select Paint when in Paint mode to refresh the mode. Same results. 4. You can continue to unlink brushes, and Blender will continue to create more copies of the "Brush" brush. Correct me if I'm wrong, but I believe this use to work the same as vertex paint mode even after 2.72, where you could delete brushes, but not lose the ability to continue working with other brushes. I did look at the older tickets, but did not see anything regarding this issue, but did notice it was an issue in 2.74 as well when trying to find a "working" version.

Dennis Brown commented

2015-07-01 15:13:50 +02:00

Changed status to: 'Open'

Dennis Brown commented

2015-07-01 15:13:50 +02:00

Added subscriber: @DBrown

Sergey Sharybin commented

2015-07-02 08:41:48 +02:00

Added subscribers: @Psy-Fi, @Sergey

Antonis Ryakiotakis was assigned by Sergey Sharybin

2015-07-02 08:41:48 +02:00

Sergey Sharybin commented

2015-07-02 08:41:48 +02:00

@Psy-Fi, mind having a look into this report? :) Thanks in advance =)

Campbell Barton commented

2015-08-31 18:21:18 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2015-08-31 18:21:18 +02:00

@Psy-Fi, I was looking into this, and am wondering if its really important/needed to add a brush on entering point mode.

This is such a rare situation and normally you'll want to use one of the existing brushes anyway.

guessing this is mostly useful loading old files?

I was looking into picking an existing brush, however at this point we don't know the mode we're in, so it could pick a sculpt brush in vertex paint mode for eg.

Suggested fix...

add a new enum for kinds of brush types (since they're not a 1:1 match with object-modes)
use this to check for an existing brush to use (compatible with the current mode), only adding a new brush when none are available.
remove the color argument, (color can be set by checking the color enum).

This isn't really all that involved... probably ~20 line patch.

@Psy-Fi, I was looking into this, and am wondering if its really important/needed to add a brush on entering point mode. This is such a rare situation and normally you'll want to use one of the existing brushes anyway. guessing this is mostly useful loading old files? I was looking into picking an existing brush, however at this point we don't know the mode we're in, so it could pick a sculpt brush in vertex paint mode for eg. Suggested fix... ---- - add a new enum for kinds of brush types (since they're not a 1:1 match with object-modes) - use this to check for an existing brush to use (compatible with the current mode), only adding a new brush when none are available. - remove the color argument, (color can be set by checking the color enum). This isn't really all that involved... probably ~20 line patch.

Antonis Ryakiotakis commented

2015-08-31 18:34:01 +02:00

The enum is already there, see Brush->ob_mode.
Selecting an existing brush instead of adding a new one is not that bad but I think the crucial part of this report is that the brush selection panel disappears. It should not disappear and allow choosing another brush. Just modifying the poll function of the panel should do. Probably we can mimic what other paint modes do.

The enum is already there, see Brush->ob_mode. Selecting an existing brush instead of adding a new one is not that bad but I think the crucial part of this report is that the brush selection panel disappears. It should not disappear and allow choosing another brush. Just modifying the poll function of the panel should do. Probably we can mimic what other paint modes do.

Campbell Barton commented

2015-08-31 18:36:38 +02:00

In #45258#331527, @Psy-Fi wrote:
The enum is already there, see Brush->ob_mode.

Right, the thing is, the function doesn't know which mode the caller is in, so it doesn't know which Brush->ob_mode to check for.
As I said, no big deal to add. But you may have an opinion on this.

> In #45258#331527, @Psy-Fi wrote: > The enum is already there, see Brush->ob_mode. Right, the thing is, the function doesn't know which mode the caller is in, so it doesn't know which `Brush->ob_mode` to check for. As I said, no big deal to add. But you may have an opinion on this.

Campbell Barton commented

2015-08-31 18:41:11 +02:00

In #45258#331527, @Psy-Fi wrote:
Selecting an existing brush instead of adding a new one is not that bad but I think the crucial part of this report is that the brush selection panel disappears. It should not disappear and allow choosing another brush. Just modifying the poll function of the panel should do. Probably we can mimic what other paint modes do.

Ah, thats bad, anything against just removing the check? P254 (tested, it seems to work fine without).

> In #45258#331527, @Psy-Fi wrote: > Selecting an existing brush instead of adding a new one is not that bad but I think the crucial part of this report is that the brush selection panel disappears. It should not disappear and allow choosing another brush. Just modifying the poll function of the panel should do. Probably we can mimic what other paint modes do. Ah, thats bad, anything against just removing the check? [P254](https://archive.blender.org/developer/P254.txt) (tested, it seems to work fine without).

Antonis Ryakiotakis commented

2015-08-31 19:08:52 +02:00

Leave it to me, I'll take care of the report

blender-admin commented

2015-08-31 21:00:30 +02:00

This issue was referenced by 333feea6e9

This issue was referenced by 333feea6e9450379f5314f327cf1ac1aef6d8a07

Antonis Ryakiotakis commented

2015-08-31 21:01:56 +02:00

Changed status from 'Open' to: 'Resolved'

Antonis Ryakiotakis closed this issue

2015-08-31 21:01:56 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Deleting brush closes Paint panel and creates duplicate brush when re-entering a Paint Mode #45258

Suggested fix...