cycles bake crashes with motionblur on #45537

New Issue

Vilem Duha · 2015-07-23T11:09:43+02:00

Vilem Duha commented

2015-07-23 11:09:43 +02:00

System Information

Blender Version
Broken: 2b5e150
Worked: (optional)

Short description of error
crash when hitting bake and having motion blur on.

Exact steps for others to reproduce the error

enable motion blur, add some object with uvs and image in material nodes, try to bake.

**System Information** **Blender Version** Broken: 2b5e150 Worked: (optional) **Short description of error** crash when hitting bake and having motion blur on. **Exact steps for others to reproduce the error** enable motion blur, add some object with uvs and image in material nodes, try to bake.

Vilem Duha commented

2015-07-23 11:09:43 +02:00

Changed status to: 'Open'

Vilem Duha commented

2015-07-23 11:09:43 +02:00

Added subscriber: @VilemDuha

Vilem Duha commented

2015-07-23 16:25:52 +02:00

Just a comment - of course it's not very logical to have mblur supported with bake ( or woud it ever be?), but crashes shouldn't happen..

Kévin Dietrich commented

2015-07-24 13:25:47 +02:00

Added subscriber: @kevindietrich

Kévin Dietrich commented

2015-07-24 13:25:47 +02:00

Please try with a more recent version of Blender to see if the crash is still present and if so, attach a file demonstrating the issue.

Please try with a more [recent version of Blender ](https://builder.blender.org/download/) to see if the crash is still present and if so, attach a file demonstrating the issue.

Vilem Duha commented

2015-07-24 14:44:33 +02:00

well the version I reported with isn't that old(2 weeks maximum?) , especially considering Cycles bake isn't being worked on.
so it happens also to yesterdays build.

MBLURCRASH.blend

tested with:
7ae44e8

I didn't post a file this time, I thougth it's so simple to recreate that It actually takes longer time to write this comment than it took to create this file :)

well the version I reported with isn't that old(2 weeks maximum?) , especially considering Cycles bake isn't being worked on. so it happens also to yesterdays build. [MBLURCRASH.blend](https://archive.blender.org/developer/F212134/MBLURCRASH.blend) tested with: 7ae44e8 I didn't post a file this time, I thougth it's so simple to recreate that It actually takes longer time to write this comment than it took to create this file :)

Kévin Dietrich commented

2015-07-24 16:17:13 +02:00

A file is always required, even for simple bugs. As a matter of fact bugs should be reproducible with the default cube (depending on the area, e.g. it doesn't really make sense for the compositor). Also, people (mostly developers) don't necessarily have time to recreate the issue to check on the bug.

Anyway, the segfault seems to happen in the camera motion synchronization code in Cycles' Blender API. I don't have a debug build with Cycles at the moment to confirm or infirm this.

A file is always required, even for simple bugs. As a matter of fact bugs should be reproducible with the default cube (depending on the area, e.g. it doesn't really make sense for the compositor). Also, people (mostly developers) don't necessarily have time to recreate the issue to check on the bug. Anyway, the segfault seems to happen in the camera motion synchronization code in Cycles' Blender API. I don't have a debug build with Cycles at the moment to confirm or infirm this.

Brecht Van Lommel commented

2015-07-24 20:17:36 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2015-07-24 20:17:36 +02:00

It's crashing because there is no camera in the scene, it should be a simple NULL pointer check to fix this so that we're not trying to synchronize motion from a non-existing camera.

Kévin Dietrich commented

2015-07-24 20:52:31 +02:00

Oh, well, I could have spent a few more seconds checking on that file :) Thanks @brecht. For now I have to get the module owner's approval to commit to master, would you approve of this patch?

diff --git a/intern/cycles/blender/blender_object.cpp b/intern/cycles/blender/blender_object.cpp
index 432c4aa..d866ddf 100644
--- a/intern/cycles/blender/blender_object.cpp
+++ b/intern/cycles/blender/blender_object.cpp
@@ -670,6 +670,10 @@ void BlenderSync::sync_motion(BL::RenderSettings b_render,
 
 	/* get camera object here to deal with camera switch */
 	BL::Object b_cam = b_scene.camera();
+
+	if(!b_cam)
+		return;
+
 	if(b_override)
 		b_cam = b_override;

@VilemDuha, that's yet another reason to always link a file, if I had to recreate it with the default startup file there would have been a camera in there ;)

Oh, well, I could have spent a few more seconds checking on that file :) Thanks @brecht. For now I have to get the module owner's approval to commit to master, would you approve of this patch? ``` diff --git a/intern/cycles/blender/blender_object.cpp b/intern/cycles/blender/blender_object.cpp index 432c4aa..d866ddf 100644 --- a/intern/cycles/blender/blender_object.cpp +++ b/intern/cycles/blender/blender_object.cpp @@ -670,6 +670,10 @@ void BlenderSync::sync_motion(BL::RenderSettings b_render, /* get camera object here to deal with camera switch */ BL::Object b_cam = b_scene.camera(); + + if(!b_cam) + return; + if(b_override) b_cam = b_override; ``` @VilemDuha, that's yet another reason to always link a file, if I had to recreate it with the default startup file there would have been a camera in there ;)

Brecht Van Lommel commented

2015-07-24 21:02:48 +02:00

@kevindietrich, I would add if(!b_ob) return in sync_camera_motion() instead, no need to abort sync_motion() entirely. If you do that and it fixes the crash, you can commit it. Thanks!

@kevindietrich, I would add `if(!b_ob) return` in `sync_camera_motion()` instead, no need to abort `sync_motion()` entirely. If you do that and it fixes the crash, you can commit it. Thanks!

Kévin Dietrich commented

2015-07-24 21:14:25 +02:00

That works too, will commit in a minute, thanks for the input/review!