Add visual warning for links between incompatible node sockets #45657

Open
opened 2015-08-02 21:16:14 +02:00 by Julian Eisel · 11 comments
Member

Add visual warning for links between incompatible node sockets

Motivation

Currently, if a node link is between two sockets that are not compatible with each other, the link has no effect without making the user aware of it.

Proposal

Draw node links between incompatible sockets red. Additionally, a warning could appear after connecting the node.

invalid_link_lines.png


Basic implementation for the red colored node links: P244

# Add visual warning for links between incompatible node sockets ## Motivation Currently, if a node link is between two sockets that are not compatible with each other, the link has no effect without making the user aware of it. ## Proposal Draw node links between incompatible sockets red. Additionally, a warning could appear after connecting the node. ![invalid_link_lines.png](https://archive.blender.org/developer/F217395/invalid_link_lines.png) ---- Basic implementation for the red colored node links: [P244](https://archive.blender.org/developer/P244.txt)
Author
Member

Changed status to: 'Open'

Changed status to: 'Open'
Author
Member

Added subscribers: @JulianEisel, @LukasStockner

Added subscribers: @JulianEisel, @LukasStockner
Member

Added subscriber: @Blendify

Added subscriber: @Blendify
Member

I think that they can be drawn as thicker lines so that they stand out more then the other noodles. although that could just be me because I am color blind

I think that they can be drawn as thicker lines so that they stand out more then the other noodles. although that could just be me because I am color blind

Added subscriber: @JonathanWilliamson

Added subscriber: @JonathanWilliamson

I like this @severin. Is the red being pulled from the theme? In my testing it doesn't seem to be, but it probably should for the sake of compatibility with themes.

I like this @severin. Is the red being pulled from the theme? In my testing it doesn't seem to be, but it probably should for the sake of compatibility with themes.
Author
Member

It's currently hardcoded in resources.c UI_ThemeGetColorPtr (colorid is TH_REDALERT). We could easily make this a theme option of course.

It's currently hardcoded in resources.c UI_ThemeGetColorPtr (colorid is TH_REDALERT). We could easily make this a theme option of course.

Maybe that's something that can be tackled in #45352

Maybe that's something that can be tackled in #45352
Author
Member

Yep, might be better :)

Yep, might be better :)
Member

You can use a dashed red line. This would give the appearance of something being broken or not working.

You can use a dashed red line. This would give the appearance of something being broken or not working.
Eitan Traurig self-assigned this 2019-08-27 22:04:28 +02:00
Eitan Traurig removed their assignment 2020-01-01 05:54:22 +01:00
Member

Added subscriber: @EitanSomething

Added subscriber: @EitanSomething
Brecht Van Lommel added this to the Render & Cycles project 2023-02-07 19:08:35 +01:00
Philipp Oeser removed the
Interest
Render & Cycles
label 2023-02-09 13:56:49 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#45657
No description provided.