fix for change to newer OpenCollada API #45956

New Issue

Lawrence D'Oliveiro · 2015-08-30T04:36:12+02:00

2015-08-30 04:36:12 +02:00

I build OpenCollada from source, and Blender fails to compile correctly against it. It appears there has been a change to the DocumentExporter API. The enclosed patch opencollada-compile-fix.patch fixes Blender so it continues to compile correctly.

I build OpenCollada from source, and Blender fails to compile correctly against it. It appears there has been a change to the DocumentExporter API. The enclosed patch [opencollada-compile-fix.patch](https://archive.blender.org/developer/F229115/opencollada-compile-fix.patch) fixes Blender so it continues to compile correctly.

Lawrence D'Oliveiro commented

2015-08-30 04:36:13 +02:00

Changed status to: 'Open'

Lawrence D'Oliveiro commented

2015-08-30 04:36:13 +02:00

Added subscriber: @ldo

Bastien Montagne commented

2015-08-30 08:38:54 +02:00

Added subscribers: @GaiaClary, @mont29

Bastien Montagne commented

2015-08-30 08:38:54 +02:00

Thanks for the patch, but we have a specific opencollada version we use for blender, afaik there is no plan to update that lib in near future, @GaiaClary?

Gaia Clary was assigned by Bastien Montagne

2015-08-30 08:39:17 +02:00

Gaia Clary commented

2015-08-30 10:33:00 +02:00

OpenCollada does not have "stable releases", just a series of commits (which almost always result in a stable library though). For Blender we provide prebuilt libraries for Windows and OSX. We would be forced to rebuild the libraries for every commit on the OpenCollada side if we always wanted to be up to date with the most recent revision of that library. This is not feasible.

The decision to update to a newer OpenCollada version happens if OpenCollada provides something new that helps us to improve the Blender exporter/importer Right now we use OpenCollada revision

3335ac164e

As far as i know the Linux distributions provide/use a script which determines exactly which libraries have to be used to successfully build blender. This includes information about the OpenCollada revision. It might be helpful to have sort of configuration information where we could drop the current used revision. But we do not (yet) have this.

Anyways thanks for the patch. We will apply it as soon as we have the need to update to a newer revision of OpenCollada.

OpenCollada does not have "stable releases", just a series of commits (which almost always result in a stable library though). For Blender we provide prebuilt libraries for Windows and OSX. We would be forced to rebuild the libraries for every commit on the OpenCollada side if we always wanted to be up to date with the most recent revision of that library. This is not feasible. The decision to update to a newer OpenCollada version happens if OpenCollada provides something new that helps us to improve the Blender exporter/importer Right now we use OpenCollada revision https://github.com/KhronosGroup/OpenCOLLADA/commit/3335ac164e68b2512a40914b14c74db260e6ff7d As far as i know the Linux distributions provide/use a script which determines exactly which libraries have to be used to successfully build blender. This includes information about the OpenCollada revision. It might be helpful to have sort of configuration information where we could drop the current used revision. But we do not (yet) have this. Anyways thanks for the patch. We will apply it as soon as we have the need to update to a newer revision of OpenCollada.

Gaia Clary commented

2015-08-30 10:34:17 +02:00

Changed status from 'Open' to: 'Archived'

Gaia Clary closed this issue

2015-08-30 10:34:17 +02:00

Gaia Clary commented

2015-08-30 10:34:17 +02:00

This patch will be applied when necessary (when an update to a newer revision of OpenCollada becomes necessary)