[Material node editor] default value for "normal" input of a node group not taken into account #46406

New Issue

François DAUBINÉ · 2015-10-07T15:09:01+02:00

2015-10-07 15:09:01 +02:00

System Information
No matter

Blender Version
Broken: 2.75

Short description of error
A "normal" input is defined in a node group and a default value is set for this input (in the right panel of the node editor). If this input is not connected outside of the node group, the default value is not taken into account and the actual value is random.

Exact steps for others to reproduce the error
No matter (see blend file)Bug_normal.blend

**System Information** No matter **Blender Version** Broken: 2.75 **Short description of error** A "normal" input is defined in a node group and a default value is set for this input (in the right panel of the node editor). If this input is not connected outside of the node group, the default value is not taken into account and the actual value is random. **Exact steps for others to reproduce the error** No matter (see blend file)[Bug_normal.blend](https://archive.blender.org/developer/F243128/Bug_normal.blend) ![Bug_screenshot.PNG](https://archive.blender.org/developer/F243129/Bug_screenshot.PNG)

François DAUBINÉ commented

2015-10-07 15:09:01 +02:00

Changed status to: 'Open'

François DAUBINÉ commented

2015-10-07 15:09:01 +02:00

Added subscriber: @momotoh

Sergey Sharybin was assigned by Bastien Montagne

2015-10-08 10:36:40 +02:00

Bastien Montagne commented

2015-10-08 10:36:40 +02:00

Added subscriber: @mont29

blender-admin commented

2015-10-08 13:05:51 +02:00

This issue was referenced by 1730c3666f

This issue was referenced by 1730c3666fd8a042a74100697fce00cc3e04a636

Sergey Sharybin commented

2015-10-08 13:06:00 +02:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2015-10-08 13:06:00 +02:00

blender-admin commented

2015-10-10 21:57:00 +02:00

This issue was referenced by 307d4b3139

This issue was referenced by 307d4b3139c400c3131df7b59e4504769d627f7a

Brecht Van Lommel commented

2015-10-10 22:03:33 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2015-10-10 22:03:33 +02:00

Changed status from 'Resolved' to: 'Open'

Brecht Van Lommel reopened this issue

2015-10-10 22:03:33 +02:00

Brecht Van Lommel commented

2015-10-10 22:03:33 +02:00

I've reverted this fix, since it's breaking Cycles node groups.

I think this was actually rendering correctly, it should not use the default value but the one in the group node. However the Normal input has its value hidden, which is confusing.

I've reverted this fix, since it's breaking Cycles node groups. I think this was actually rendering correctly, it should not use the default value but the one in the group node. However the Normal input has its value hidden, which is confusing.

Sergey Sharybin commented

2015-10-11 09:11:20 +02:00

Changed status from 'Open' to: 'Archived'

Sergey Sharybin closed this issue

2015-10-11 09:11:20 +02:00

Sergey Sharybin commented

2015-10-11 09:11:20 +02:00

@brecht, you're right. Default value in the settings only affects newly added node group instances. That's a bit confusing (well, big enough to confuse myself :( ) from the UI interaction point of view but indeed everything worked as expected.

Improvements to communication are possible, but they're happening outside of the bug tracker.

@brecht, That being said, what if we simply expose vector value "editor" to the group node (similar to how it's done for other vector nodes like Vector Transform) ?

@brecht, you're right. Default value in the settings only affects newly added node group instances. That's a bit confusing (well, big enough to confuse myself :( ) from the UI interaction point of view but indeed everything worked as expected. Improvements to communication are possible, but they're happening outside of the bug tracker. @brecht, That being said, what if we simply expose vector value "editor" to the group node (similar to how it's done for other vector nodes like Vector Transform) ?

Brecht Van Lommel commented

2015-10-11 12:39:13 +02:00

For BSDF nodes the vector value editor is hidden, because the value will not be used, it uses the surface normal. If you put that BSDF node in a group the flag to indicate that the editor should be hidden is inherited.

That's fine, the problem happens when you remove that BSDF node from the group, then hiding the value editor is wrong. It could be smarter about that, not sure what the best way to solve that would be.

For BSDF nodes the vector value editor is hidden, because the value will not be used, it uses the surface normal. If you put that BSDF node in a group the flag to indicate that the editor should be hidden is inherited. That's fine, the problem happens when you remove that BSDF node from the group, then hiding the value editor is wrong. It could be smarter about that, not sure what the best way to solve that would be.

blender-admin commented

2015-10-11 14:54:29 +02:00

This issue was referenced by blender/cycles@6973516c33

This issue was referenced by blender/cycles@6973516c33d1a9d6a6735dfafeb689eeed45f40f

blender-admin commented

2015-10-11 14:54:29 +02:00

This issue was referenced by blender/cycles@68d42cca03

This issue was referenced by blender/cycles@68d42cca031bd756fda1fe33570b36b7f08dab18

Sergey Sharybin commented

2015-10-11 15:27:01 +02:00

Changed status from 'Archived' to: 'Resolved'

Sergey Sharybin commented

2015-10-17 20:00:21 +02:00

Changed status from 'Resolved' to: 'Archived'

Sergey Sharybin commented

2015-10-17 20:00:21 +02:00

Eeh, porting commit to Cycles repository marked the report as resolved while in fact it's not resolved.

To be clear: there are actually several other issues reported here about behavior of node group inputs which are in fact related to this one. For example, you can't switch socket type from vector to color and vice versa.

While it's confusing, it's not really a bug since it actually behaves as it was intended from code side. Surely improvements are possible, we'll look into this as a part of TODO work. Noted the report there: http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/Editors#Node_Editor

Eeh, porting commit to Cycles repository marked the report as resolved while in fact it's not resolved. To be clear: there are actually several other issues reported here about behavior of node group inputs which are in fact related to this one. For example, you can't switch socket type from vector to color and vice versa. While it's confusing, it's not really a bug since it actually behaves as it was intended from code side. Surely improvements are possible, we'll look into this as a part of TODO work. Noted the report there: http://wiki.blender.org/index.php/Dev:2.5/Source/Development/Todo/Editors#Node_Editor

Sybren A. Stüvel referenced this issue

2023-03-30 15:30:10 +02:00

Blender development todo list -- Editors #55366

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

[Material node editor] default value for "normal" input of a node group not taken into account #46406