Page MenuHome

Project Vertices on Grease Pencil
Closed, ArchivedPublic

Description

Hi!!
This tool project selected vertices on a grease pencil draw, like shrink wrap project.

Video:
https://www.youtube.com/watch?v=W2Av331BLgU

Demo (model a mechanic piece):
https://www.youtube.com/watch?v=B2sZrqadXxs&feature=youtu.be

Greetings!

Details

Type
Patch

Event Timeline

Eugenio Pignataro (oscurart) updated the task description. (Show Details)
Eugenio Pignataro (oscurart) raised the priority of this task from to Needs Triage by Developer.
Eugenio Pignataro (oscurart) set Type to Patch.

hi, looks good, I'll have time to test this weekend

hi, some minor suggestions:
Review by Sybren:
please follow PEP-8 conventions
the use of except: pass in lines 69, 76. 83, is this needed?
indentation levels (line 45 should inverse the condition and do a continue)
comparisons, A > x and A < y should be written as y < A < x
bpy.context instead of the passed-in context (line 50)
using 'vertice' instead of 'vertex'
also some code comments & better function descriptions would be good.

@Eugenio Pignataro (oscurart)
please fix the pep8 first then your good to add to contrib & improve/work on code style & issues.
thanks for your continued efforts.
Brendon.

Sergey Sharybin (sergey) triaged this task as Needs Information from User priority.Nov 17 2015, 9:15 AM

Marking as incomplete since author's action is required.

Bastien Montagne (mont29) closed this task as Archived.Dec 4 2015, 4:24 PM

More than two weeks without reactions… archiving for now. Also, that kind of stuff would be much better as a differencial than a task (see https://developer.blender.org/differential/diff/create/ ).