ASC CDL Node: Clamps #47336
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#47336
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
According to the ASC CDL specification, there should be no clamps on the slope, offset, or power of the ASC CDL transform.
In Blender, there is.
Changed status to: 'Open'
Added subscriber: @troy_s
Added subscriber: @Sergey
Blender doesn't have "ASC CDL" node. Rest of the report please translate to English (at least so Blender community can understand what's it's all about!). Following report bug guidelines will also be a god idea to do.
Added subscriber: @BassamKurdali
ASC CDL is in the Offset/Power/Slope (ASC-CDL) in the color balance node, The default correction formula there is Lift/Gamma/Gain so it's a bit hidden.
Sorry.
System Information
Operating system and graphics card
Linux amd64 Debian Squeeze
Blender Version
Broken: 3b1acd
Worked: Don't think it ever did
Short description of error
Line 31 of COM_ColorBalanceASCCDLOperation.c uses a CLAMP operation. This breaks all scene referred imagery out of Cycles, as well as goes against the specification which should never be clamped against display referred values. See https://en.wikipedia.org/wiki/ASC_CDL for more information.
Exact steps for others to reproduce the error
Load a Color Balance Node, flip to ASC CDL. Impossible to get correct results as the values are clamped.
Added subscriber: @jta
I concur with T & B...
Well, sure enough the wiki does not take into account any issues caused by machine arithmetic and only shows math side ;)
So think we should still prevent negative values from happening before calling a
pow()
. Clamping from the top is not needed here indeed.thanks sergey!
This issue was referenced by
dd185bf5b8
Changed status from 'Open' to: 'Resolved'