X3d import crashes on texture #47374

New Issue

Anton Fuhrmann · 2016-02-09T14:13:17+01:00

Anton Fuhrmann commented

2016-02-09 14:13:17 +01:00

System Information
Windows 10x64, on Intel and Nvidia cards

Blender Version
Broken: import_x3d.py in 2.76b

Short description of error
Importing an X3d file containing a textureTransform node crashes importer

Exact steps for others to reproduce the error
Attached are a simple blend file and an .x3d exported from this blend file: demo.zip
When re-importing the .x3d with the "x3d/vrml" importer distributed with 2.76b, you get the following stacktrace:

Traceback (most recent call last):
  File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\__init__.py", line 81, in execute
    return import_x3d.load(self, context, **keywords)
  File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\import_x3d.py", line 2684, in load
    global_matrix=global_matrix,
  File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\import_x3d.py", line 2604, in load_web3d
    importShape(node, ancestry, global_matrix)
  File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\import_x3d.py", line 2223, in importShape
    apply_texmtx(blendata, texmtx)
NameError: name 'blendata' is not defined

This is caused by the following typo:

2220:                        if bpydata.uv_layers:
2221:                            if texmtx:
2222:                                # Apply texture transform?
2223:                                apply_texmtx(blendata, texmtx)

which should read:

2220:                        if bpydata.uv_layers:
2221:                            if texmtx:
2222:                                # Apply texture transform?
2223:                                apply_texmtx(bpydata, texmtx)

changing this results in another stacktrace in function "apply_texmtx":

Traceback (most recent call last):
  File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\__init__.py", line 81, in execute
    return import_x3d.load(self, context, **keywords)
  File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\import_x3d.py", line 2684, in load
    global_matrix=global_matrix,
  File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\import_x3d.py", line 2604, in load_web3d
    importShape(node, ancestry, global_matrix)
  File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\import_x3d.py", line 2223, in importShape
    apply_texmtx(bpydata, texmtx)
  File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\import_x3d.py", line 2044, in apply_texmtx
    luv.uv = texmtx * luv.uv
ValueError: matrix * vector: len(matrix.col) and len(vector) must be the same, except for 4x4 matrix * 3D vector.

which results from trying to multiply a 2d UV-coordinate vector by an 4x4 matrix:

2042:    def apply_texmtx(blendata, texmtx):
2043:        for luv in bpydata.uv_layers.active.data:
2044:            luv.uv = texmtx * luv.uv

line 2044 should in my opinion read:

2044:            luv.uv = (texmtx * luv.uv.to_3d()).to_2d()

This results in a correct import of "demo.x3d":

then, changing the textureTransform values in the .x3d correctly results in a plausible transformation:

**System Information** Windows 10x64, on Intel and Nvidia cards **Blender Version** Broken: import_x3d.py in 2.76b **Short description of error** Importing an X3d file containing a textureTransform node crashes importer **Exact steps for others to reproduce the error** Attached are a simple blend file and an .x3d exported from this blend file: [demo.zip](https://archive.blender.org/developer/F281176/demo.zip) When re-importing the .x3d with the "x3d/vrml" importer distributed with 2.76b, you get the following stacktrace: ``` Traceback (most recent call last): File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\__init__.py", line 81, in execute return import_x3d.load(self, context, **keywords) File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\import_x3d.py", line 2684, in load global_matrix=global_matrix, File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\import_x3d.py", line 2604, in load_web3d importShape(node, ancestry, global_matrix) File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\import_x3d.py", line 2223, in importShape apply_texmtx(blendata, texmtx) NameError: name 'blendata' is not defined ``` This is caused by the following typo: ``` 2220: if bpydata.uv_layers: 2221: if texmtx: 2222: # Apply texture transform? 2223: apply_texmtx(blendata, texmtx) ``` which should read: ``` 2220: if bpydata.uv_layers: 2221: if texmtx: 2222: # Apply texture transform? 2223: apply_texmtx(bpydata, texmtx) ``` changing this results in another stacktrace in function "apply_texmtx": ``` Traceback (most recent call last): File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\__init__.py", line 81, in execute return import_x3d.load(self, context, **keywords) File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\import_x3d.py", line 2684, in load global_matrix=global_matrix, File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\import_x3d.py", line 2604, in load_web3d importShape(node, ancestry, global_matrix) File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\import_x3d.py", line 2223, in importShape apply_texmtx(bpydata, texmtx) File "C:\Program Files\Blender Foundation\Blender\2.76\scripts\addons\io_scene_x3d\import_x3d.py", line 2044, in apply_texmtx luv.uv = texmtx * luv.uv ValueError: matrix * vector: len(matrix.col) and len(vector) must be the same, except for 4x4 matrix * 3D vector. ``` which results from trying to multiply a 2d UV-coordinate vector by an 4x4 matrix: ``` 2042: def apply_texmtx(blendata, texmtx): 2043: for luv in bpydata.uv_layers.active.data: 2044: luv.uv = texmtx * luv.uv ``` line 2044 should in my opinion read: ``` 2044: luv.uv = (texmtx * luv.uv.to_3d()).to_2d() ``` This results in a correct import of "demo.x3d": ![Capture.PNG](https://archive.blender.org/developer/F281179/Capture.PNG) then, changing the textureTransform values in the .x3d correctly results in a plausible transformation: ![Capture1.PNG](https://archive.blender.org/developer/F281181/Capture1.PNG)

Anton Fuhrmann commented

2016-02-09 14:13:17 +01:00

Changed status to: 'Open'