Page MenuHome

ASC CDL: Should permit negative values on offset.
Closed, ResolvedPublic

Description

System Information
Linux amd64, Debian Squeeze

Blender Version
Broken: c1d05fa

Short description of error
ASC CDL function should permit negative slope value.

Exact steps for others to reproduce the error
Add a Color Balance node, change to ASC CDL. Note how 'offset' variable is impossible to set to negative values.

@Lukas Stockner (lukasstockner97) wrote a patch that changes the ASC CDL values to numerical inputs here, however, if plausible, it would be nice to keep the wheels as well. Is this possible?

Details

Type
Bug

Event Timeline

Troy Sobotka (sobotka) set Type to Bug.
Troy Sobotka (sobotka) created this task.
Troy Sobotka (sobotka) raised the priority of this task from to Needs Triage by Developer.

Oops. I mistakingly posted "Slope" when I should have said "Offset". Dummy.

Sergey Sharybin (sergey) triaged this task as Normal priority.

I'm asking once again, please stick to Blender's terminology! There are more than one developer involved in the development, and form the report it's not clear at all: (a) what area the issue is happening (b) what exact circumstances the issue is happening with.

For those who didn't follow previous related report: it is about Color Balance compositor node set to ASC-CDL correction formula.

I don't think it's really great idea to change wheels to sliders, and i don't find new tooltips any more artists friendly.

@Campbell Barton (campbellbarton), is it possible to enable negative values for a particular color wheels? Afair, it was you who disabled negative values.

I don't think it's really great idea to change wheels to sliders, and i don't find new tooltips any more artists friendly.

The precision when operating on the wheels is somewhat needing greater digits of accuracy when operating on scene referred imagery. Perhaps the values can be expanded to greater precision?

@Campbell Barton (campbellbarton), is it possible to enable negative values for a particular color wheels? Afair, it was you who disabled negative values.

@Campbell Barton (campbellbarton) Any chance you can provide a method to permit negative values on a per-UI basis?

Checked on making the color wheel support negative colors, however theres too many HSV/RGB conversions in our pickers code which rely on RGB being >0.0.
Committed a basis for the color which can be negative rBddd6be1834692c63353e47ab8d94e8dfc576c906