ASC CDL: Should permit negative values on offset. #47709

New Issue

Troy Sobotka · 2016-03-07T08:35:35+01:00

Troy Sobotka commented

2016-03-07 08:35:35 +01:00

System Information
Linux amd64, Debian Squeeze

Blender Version
Broken: c1d05fa

Short description of error
ASC CDL function should permit negative slope value.

Exact steps for others to reproduce the error
Add a Color Balance node, change to ASC CDL. Note how 'offset' variable is impossible to set to negative values.

@LukasStockner wrote a patch that changes the ASC CDL values to numerical inputs here , however, if plausible, it would be nice to keep the wheels as well. Is this possible?

**System Information** Linux amd64, Debian Squeeze **Blender Version** Broken: c1d05fa **Short description of error** ASC CDL function should permit negative slope value. **Exact steps for others to reproduce the error** Add a Color Balance node, change to ASC CDL. Note how 'offset' variable is impossible to set to negative values. ![slope.jpg](https://archive.blender.org/developer/F288923/slope.jpg) @LukasStockner wrote a patch that changes the ASC CDL values to numerical inputs [here ](http://www.pasteall.org/65855/diff), however, if plausible, it would be nice to keep the wheels as well. Is this possible?

Troy Sobotka commented

2016-03-07 08:35:35 +01:00

Changed status to: 'Open'

Troy Sobotka commented

2016-03-07 08:35:35 +01:00

Added subscribers: @troy_s, @LukasStockner

Troy Sobotka commented

2016-03-07 08:37:14 +01:00

Oops. I mistakingly posted "Slope" when I should have said "Offset". Dummy.

Oops. I mistakingly posted "Slope" when I should have said "Offset". Dummy. ![offset.jpg](https://archive.blender.org/developer/F288925/offset.jpg)

Sergey Sharybin commented

2016-03-07 10:59:22 +01:00

Added subscribers: @ideasman42, @Sergey

Sergey Sharybin commented

2016-03-07 10:59:22 +01:00

I'm asking once again, please stick to Blender's terminology! There are more than one developer involved in the development, and form the report it's not clear at all: (a) what area the issue is happening (b) what exact circumstances the issue is happening with.

For those who didn't follow previous related report: it is about Color Balance compositor node set to ASC-CDL correction formula.

I don't think it's really great idea to change wheels to sliders, and i don't find new tooltips any more artists friendly.

@ideasman42, is it possible to enable negative values for a particular color wheels? Afair, it was you who disabled negative values.

I'm asking once again, please stick to Blender's terminology! There are more than one developer involved in the development, and form the report it's not clear at all: (a) what area the issue is happening (b) what exact circumstances the issue is happening with. For those who didn't follow previous related report: it is about Color Balance compositor node set to ASC-CDL correction formula. I don't think it's really great idea to change wheels to sliders, and i don't find new tooltips any more artists friendly. @ideasman42, is it possible to enable negative values for a particular color wheels? Afair, it was you who disabled negative values.

Troy Sobotka commented

2016-03-14 03:21:13 +01:00

In #47709#362464, @Sergey wrote:

I don't think it's really great idea to change wheels to sliders, and i don't find new tooltips any more artists friendly.

The precision when operating on the wheels is somewhat needing greater digits of accuracy when operating on scene referred imagery. Perhaps the values can be expanded to greater precision?

@ideasman42, is it possible to enable negative values for a particular color wheels? Afair, it was you who disabled negative values.

@ideasman42 Any chance you can provide a method to permit negative values on a per-UI basis?

> In #47709#362464, @Sergey wrote: > > I don't think it's really great idea to change wheels to sliders, and i don't find new tooltips any more artists friendly. The precision when operating on the wheels is somewhat needing greater digits of accuracy when operating on scene referred imagery. Perhaps the values can be expanded to greater precision? > @ideasman42, is it possible to enable negative values for a particular color wheels? Afair, it was you who disabled negative values. @ideasman42 Any chance you can provide a method to permit negative values on a per-UI basis?

Campbell Barton was assigned by Sergey Sharybin

2016-05-03 17:59:18 +02:00

Campbell Barton commented

2016-05-04 16:04:41 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2016-05-04 16:04:41 +02:00

Campbell Barton commented

2016-05-04 16:04:41 +02:00

Checked on making the color wheel support negative colors, however theres too many HSV/RGB conversions in our pickers code which rely on RGB being >0.0.
Committed a basis for the color which can be negative ddd6be1834

Checked on making the color wheel support negative colors, however theres too many HSV/RGB conversions in our pickers code which rely on RGB being >0.0. Committed a basis for the color which can be negative ddd6be1834

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

ASC CDL: Should permit negative values on offset. #47709