Blender freezes in multi-threaded tasks since recent rB98123ae91680, on windows - atomic ops issue? #48422

New Issue

Denis Belov · 2016-05-13T17:29:46+02:00

Denis Belov commented

2016-05-13 17:29:46 +02:00

System Information
Win 7x64, Nvidia GTX 580

Blender Version
broken: blender-2.77.0-git.b72aef9-AMD64
Working: blender-2.77.0-git.898d040-AMD64

Blender freezes while trying to do vertex snapping with subdivision modifier enabled both in object and edit mode.

Create Suzanne
Add Subsurface modifier, duplicate mesh
Try to manipulate meshes with vertex snapping enabled

Sometimes i can reproduce this instantly, sometime not, so try open attached file, it freezes all the time.
bug.blend

**System Information** Win 7x64, Nvidia GTX 580 **Blender Version** broken: blender-2.77.0-git.b72aef9-AMD64 Working: blender-2.77.0-git.898d040-AMD64 Blender freezes while trying to do vertex snapping with subdivision modifier enabled both in object and edit mode. 1. Create Suzanne 2. Add Subsurface modifier, duplicate mesh 3. Try to manipulate meshes with vertex snapping enabled Sometimes i can reproduce this instantly, sometime not, so try open attached file, it freezes all the time. [bug.blend](https://archive.blender.org/developer/F310802/bug.blend)

Denis Belov commented

2016-05-13 17:29:46 +02:00

Changed status to: 'Open'

Denis Belov commented

2016-05-13 17:29:46 +02:00

Added subscriber: @DenisBelov

blender-admin commented

2016-05-13 17:29:46 +02:00

#48432 was marked as duplicate of this issue

blender-admin commented

2016-05-13 17:29:46 +02:00

#48442 was marked as duplicate of this issue

blender-admin commented

2016-05-13 17:29:46 +02:00

#48440 was marked as duplicate of this issue

blender-admin commented

2016-05-13 17:29:46 +02:00

#48437 was marked as duplicate of this issue

Campbell Barton commented

2016-05-13 20:39:43 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2016-05-13 20:39:43 +02:00

This is caused by 98123ae916

This is caused by 98123ae916

Bastien Montagne commented

2016-05-14 10:15:47 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2016-05-14 10:15:47 +02:00

Cannot reproduce that here… @ideasman42 you just opened the file and did some snapped transform in Object or Edit mode, and got the freeze?

Anyway, if this commit causes issues, it can be reverted, gave nearly no speed gain anyway…

Cannot reproduce that here… @ideasman42 you just opened the file and did some snapped transform in Object or Edit mode, and got the freeze? Anyway, if this commit causes issues, it can be reverted, gave nearly no speed gain anyway…

Germano Cavalcante commented

2016-05-14 16:01:26 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2016-05-14 16:01:26 +02:00

I don't like to revert optimizations (no matter how small) :(
@mont29 if the first time has not frozen, try again, there are times when it works.
(Just make the snap to vertices in object mode. Edit mode also freezes)

I don't like to revert optimizations (no matter how small) :( @mont29 if the first time has not frozen, try again, there are times when it works. (Just make the snap to vertices in object mode. Edit mode also freezes)

Bastien Montagne commented

2016-05-14 18:07:04 +02:00

I tried it several times of course, with both release and debug builds. Am on linux though, not sure on which OS Campbell reproduced it.

I do found an error in new code that could create issues, committed a fix, please give it a try. :)

I tried it several times of course, with both release and debug builds. Am on linux though, not sure on which OS Campbell reproduced it. I do found an error in new code that could create issues, committed a fix, please give it a try. :)

Germano Cavalcante commented

2016-05-14 19:45:56 +02:00

ops, saying to "try again" I meant close and open Blender (but you also must have already tried this way).

At first, it seemed that was fixed. But the problem came back on the second try :( (no fix)

ops, saying to "try again" I meant close and open Blender (but you also must have already tried this way). At first, it seemed that was fixed. But the problem came back on the second try :( (no fix)

Bastien Montagne commented

2016-05-15 11:10:48 +02:00

Still cannot reproduce at all…

Might be related to #48437, can you please try and see if you can reproduce it?

Still cannot reproduce at all… Might be related to #48437, can you please try and see if you can reproduce it?

Germano Cavalcante commented

2016-05-15 16:08:53 +02:00

Yes I can reproduce it.
And the race condition also occurs in the loop "while (UNLIKELY(previter != olditer)".

I found a strange thing - after the end of the loop execution, suddenly, out of nowhere, it runs again without passing by the expected sequence of the function.

(I do not understand this atomic thing however)

Yes I can reproduce it. And the race condition also occurs in the loop "while (UNLIKELY(previter != olditer)". I found a strange thing - after the end of the loop execution, suddenly, out of nowhere, it runs again without passing by the expected sequence of the function. (I do not understand this atomic thing however)

Bastien Montagne commented

2016-05-15 16:28:40 +02:00

Grumph… atomic means the operation is done in 'a single step' from CPU point of view, i.e. you cannot have thread 1 start an atomic operation, then thread 2 modify one of its operands, then thread 1 finish the operation.

Those atomic ops are implemented in all modern CPUs, and are much cheaper than using regular thread synchronization primitives like mutex or spinlock.

That looping func is a way to perform an operation that does not exists in atomic primitives, idea is to:

read current value of the shared data we want to modify (32bit data, reading is assumed atomic, i.e. you cannot read part of the value, then get it changed by another thread, then read the remaining part).
do the operation and store its value in a local variable (this can take any amount of time, since it only uses local or read-only variables).
do an atomic CAS to set the shared variable we want to modify.
Repeat as long a value returned by CAS is not the same as the one we stored at the beginning (meaning the shared variable has been modified by another thread in-between).

The atomic CAS (compare and swap) compares the value of the data to modify with a given 'reference', only sets the former with the new value if it equals to the reference value, and then return the old value of modified data.

So in theory, this is perfectly safe and no deadlock should happen. Actually, there is no actual deadlock possible here, since there is no lock - I’d rather think of an inifite loop due to something messed up in msvc version of our atomic primitives.

I would suspect some stupid conversion mismatch between signed and unsigned integers (though afaik uint32 < INT_MAX should not be an issue here :| ).
Can you please try to replace line 76 of intern/atomic/intern/atomic_ops_msvc.h file with that one, and check again?

  	return InterlockedCompareExchange((long *)v, *(long *)(&_new), *(long *)(&old));

Grumph… atomic means the operation is done in 'a single step' from CPU point of view, i.e. you cannot have thread 1 start an atomic operation, then thread 2 modify one of its operands, then thread 1 finish the operation. Those atomic ops are implemented in all modern CPUs, and are much cheaper than using regular thread synchronization primitives like mutex or spinlock. That looping func is a way to perform an operation that does not exists in atomic primitives, idea is to: - read current value of the shared data we want to modify (32bit data, reading is assumed atomic, i.e. you cannot read part of the value, then get it changed by another thread, then read the remaining part). - do the operation and store its value in a local variable (this can take any amount of time, since it only uses local or read-only variables). - do an atomic CAS to set the shared variable we want to modify. - Repeat as long a value returned by CAS is not the same as the one we stored at the beginning (meaning the shared variable has been modified by another thread in-between). The atomic CAS (compare and swap) compares the value of the data to modify with a given 'reference', only sets the former with the new value if it equals to the reference value, and then return the old value of modified data. So in theory, this is perfectly safe and no deadlock should happen. Actually, there is no actual deadlock possible here, since there is no lock - I’d rather think of an inifite loop due to something messed up in msvc version of our atomic primitives. I would suspect some stupid conversion mismatch between signed and unsigned integers (though afaik uint32 < INT_MAX should not be an issue here :| ). Can you please try to replace line 76 of `intern/atomic/intern/atomic_ops_msvc.h` file with that one, and check again? ``` return InterlockedCompareExchange((long *)v, *(long *)(&_new), *(long *)(&old)); ```

Germano Cavalcante commented

2016-05-15 17:04:36 +02:00

(I'm still trying to understand all the explanation ...)

However did the change you requested (line 76 of atomic_ops_msvc.h), and the problem persists :(

(I'm still trying to understand all the explanation ...) However did the change you requested (line 76 of atomic_ops_msvc.h), and the problem persists :(

Bastien Montagne commented

2016-05-15 18:00:04 +02:00

Guess I’ll have to go and debug this myself on my win VM (provided blender still runs on it), looks like our win atomics is broken somehow (unless I miss something else, maybe we'd need some kind of memory fence here, not sure why or where though)…

Bastien Montagne commented

2016-05-15 20:40:37 +02:00

Added subscribers: @VertexPainter, @Ace_Dragon

Bastien Montagne changed title from ~~Blender freezes while trying to do vertex snapping with subdivision modifier enabled.~~ to Blender freezes in multi-threaded tasks since recent rB98123ae91680, on windows - atomic ops issue?

2016-05-15 20:41:56 +02:00

Bastien Montagne self-assigned this 2016-05-15 20:41:56 +02:00

Bastien Montagne commented

2016-05-15 21:02:26 +02:00

Added subscribers: @Clarkx, @MassimilianoPuliero