Official Pie menus/3d Viewport Pies (Promote: Addons Release) #48709

New Issue

Brendon Murphy · 2016-06-22T12:27:45+02:00

Brendon Murphy commented

2016-06-22 12:27:45 +02:00

Hi, this update brings new methods to the activation of the official pie menus.
Current behavior: The official pie menu's activate all the pies in the addon. this can & does cause conflicts with other addons that use the same hotkeys.
New behavior: The 3d view menus have individual activation so users have additional flexibility in what pies they want to enable or not. this does not interfere with other addons with the same hotkey, simply turn off the individual pie activation & other keymaps are respected. The clip editor pies have one activation as it's a specific area & the chance of conflicting pies is significantly lessened.

pie_menus_official.zip

thanks.

Edit:
The initial addon had expanded beyond "Official Pie menus"
Current Version is in addons contrib: commit: https://developer.blender.org/rBAC6176bf658d03be565f7c82e2d2527c9c2aa1cf3b
The current version is an extensive addon containing multiple pie menus & incorporating the 3d View pie menus from "Official Pie menus addon".
File:space_view3d_pie_menus.zip
Screenshot:

After discussions with sebastian_k & severin & external pie menu devs & others in irc, I've addressed several issues & fixes.
New: Only location & description in the addons drop down
New: menu names structure: "menu name: menu hotkey:" eg: Pivot Point Pie: Hotkey: . key
New: Editor Switch Pie: easily switch editor types from any editor
New: addon is mostly 3d view specific. *exceptions are the Open Save file menus & the editor type switch

Proposalas it stands:

Official Pie Menus
1/ Remove 3d View menu's & leave in Clip Editor menus
2/ Rename Official Pie menus to Clip Editor Pies
Reasoning: (as above)
Current behavior: The official pie menu's activate all the pies in the addon. this can & does cause conflicts with other addons that use the same hotkeys.
New behavior: The 3d view menus have individual activation so users have additional flexibility in what pies they want to enable or not. This does not interfere with other addons with the same hotkey, simply turn off the individual pie menus activation & other keymaps are respected. The clip editor pies would remain a single addon/menu activation as it's a specific area & the chance of conflicting pies is significantly lessened.

3D Viewport Pie Menus
1/ Add to release.
Reasoning:
This is a significant pie menu addon offering great flexibility for the user & additional tools for the ui.
It represents the 3d view very well, covering many useful menu's & integrating well into workflows.

Design was as follows:
Using the addon submodule activation by chromoly, I split up wazou's popular pie menus addon into submodules, from there I added in the 3d view pies from the "Official Pie menus addon" & matched hotkeys & content as best as practical. After advice & discussion over several weeks I have come to my 'final design'
Thanks.

link to contrib: https://developer.blender.org/diffusion/BAC/browse/master/space_view3d_pie_menus/

Hi, this update brings new methods to the activation of the official pie menus. Current behavior: The official pie menu's activate all the pies in the addon. this can & does cause conflicts with other addons that use the same hotkeys. New behavior: The 3d view menus have individual activation so users have additional flexibility in what pies they want to enable or not. this does not interfere with other addons with the same hotkey, simply turn off the individual pie activation & other keymaps are respected. The clip editor pies have one activation as it's a specific area & the chance of conflicting pies is significantly lessened. ![official pies.jpg](https://archive.blender.org/developer/F318199/official_pies.jpg) [pie_menus_official.zip](https://archive.blender.org/developer/F318201/pie_menus_official.zip) thanks. Edit: The initial addon had expanded beyond "Official Pie menus" Current Version is in addons contrib: commit: https://developer.blender.org/rBAC6176bf658d03be565f7c82e2d2527c9c2aa1cf3b The current version is an extensive addon containing multiple pie menus & incorporating the 3d View pie menus from "Official Pie menus addon". File:[space_view3d_pie_menus.zip](https://archive.blender.org/developer/F319097/space_view3d_pie_menus.zip) Screenshot: ![3d_view_pies.jpg](https://archive.blender.org/developer/F319098/3d_view_pies.jpg) After discussions with sebastian_k & severin & external pie menu devs & others in irc, I've addressed several issues & fixes. New: Only location & description in the addons drop down New: menu names structure: "menu name: menu hotkey:" eg: Pivot Point Pie: Hotkey: . key New: Editor Switch Pie: easily switch editor types from any editor New: addon is mostly 3d view specific. *exceptions are the Open Save file menus & the editor type switch **Proposal**as it stands: *Official Pie Menus* 1/ Remove 3d View menu's & leave in Clip Editor menus 2/ Rename Official Pie menus to Clip Editor Pies *`Reasoning:`* (as above) Current behavior: The official pie menu's activate all the pies in the addon. this can & does cause conflicts with other addons that use the same hotkeys. New behavior: The 3d view menus have individual activation so users have additional flexibility in what pies they want to enable or not. This does not interfere with other addons with the same hotkey, simply turn off the individual pie menus activation & other keymaps are respected. The clip editor pies would remain a single addon/menu activation as it's a specific area & the chance of conflicting pies is significantly lessened. *3D Viewport Pie Menus* 1/ Add to release. *`Reasoning:`* This is a significant pie menu addon offering great flexibility for the user & additional tools for the ui. It represents the 3d view very well, covering many useful menu's & integrating well into workflows. Design was as follows: Using the addon submodule activation by chromoly, I split up wazou's popular pie menus addon into submodules, from there I added in the 3d view pies from the "Official Pie menus addon" & matched hotkeys & content as best as practical. After advice & discussion over several weeks I have come to my 'final design' Thanks. link to contrib: https://developer.blender.org/diffusion/BAC/browse/master/space_view3d_pie_menus/

Brendon Murphy commented

2016-06-22 12:27:45 +02:00

Changed status to: 'Open'

Brendon Murphy commented

2016-06-22 12:27:45 +02:00

Added subscriber: @BrendonMurphy

Vuk Gardašević commented

2016-06-22 12:33:16 +02:00

Added subscriber: @VukGardasevic

Sergey Sharybin commented

2016-06-28 11:58:32 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2016-06-28 11:59:56 +02:00

Added subscribers: @JulianEisel, @mont29

Sergey Sharybin commented

2016-06-28 11:59:56 +02:00

@JulianEisel, @mont29, who's our pie department nowadays?

Brendon Murphy commented

2016-06-30 11:02:37 +02:00

new proposal in first post

Brendon Murphy changed title from ~~Official Pie menus (update: addons release)~~ to Official Pie menus (Promote: Addons Release)

2016-07-03 11:26:31 +02:00

Brendon Murphy changed title from ~~Official Pie menus (Promote: Addons Release)~~ to Official Pie menus/3d Viewport Pies (Promote: Addons Release)

2016-07-03 11:27:05 +02:00

Sebastian Koenig commented

2016-07-18 13:06:07 +02:00

Added subscriber: @sebastian_k

Sebastian Koenig commented

2016-07-18 13:06:07 +02:00

While I think it is great to be able to toggle the pie options separately, I have to say there are several pie menus that I really don't like at all.
As far as I understand, the idea behind pie menus is to have quick, muscle-memory based access to the operators. In many of these pie menus however, there are classical menus integrated along with the pie menus items.
Take for example the Shift+Z menu. In the lower left corner of the pie you have 3 checkbox items take the place of 1 pie menue entry. The problem is, I cannot even open up the pie menu and toggle all these 3 menus (Only Render, Outline Selected, World Background), because each time I activate one checkbox, it closes the pie. That makes the entire workflow cumbersome and slow, and it would be a lot faster to just use the menu in the properties panel.
Personally I think these classical menu items should not be allowed in a pie menu. At least not in an official one.
Pies are for fast access of the most important settings and operators, menu panels for all the stuff. Combining these jsut doesnt work, at least not in my opinion.

While I think it is great to be able to toggle the pie options separately, I have to say there are several pie menus that I really don't like at all. As far as I understand, the idea behind pie menus is to have quick, muscle-memory based access to the operators. In many of these pie menus however, there are classical menus integrated along with the pie menus items. Take for example the Shift+Z menu. In the lower left corner of the pie you have 3 checkbox items take the place of 1 pie menue entry. The problem is, I cannot even open up the pie menu and toggle all these 3 menus (Only Render, Outline Selected, World Background), because each time I activate one checkbox, it closes the pie. That makes the entire workflow cumbersome and slow, and it would be a lot faster to just use the menu in the properties panel. Personally I think these classical menu items should not be allowed in a pie menu. At least not in an official one. Pies are for fast access of the most important settings and operators, menu panels for all the stuff. Combining these jsut doesnt work, at least not in my opinion.

Sebastian Koenig commented

2016-07-18 13:53:23 +02:00

I think it would be good to have some guidelines when designing pie menus. Of course this is just personal preference, but anyway, here's what I think should be considered when designing pie menus:

Pie menus are for fast and easy access to the most used tools and operators
They are not there to cram every single option related to the tool into the pie. For that we have menus.
Don't use non-pie-menus such as checkboxes and dropdown menus in a pie: they don't even animate together with the pie
Opposing operators should be on opposing sides of the pie. Example: play forward/backward, wireframe/solid view etc.

Maybe there is more, but I think this could be a start. I would want to keep things separated: Menus to put all the things in there, pies as a quick way to perform frequently used tasks quicker and easier.

I think it would be good to have some guidelines when designing pie menus. Of course this is just personal preference, but anyway, here's what I think should be considered when designing pie menus: 1. Pie menus are for fast and easy access to the most used tools and operators 2. They are not there to cram every single option related to the tool into the pie. For that we have menus. 3. Don't use non-pie-menus such as checkboxes and dropdown menus in a pie: they don't even animate together with the pie 4. Opposing operators should be on opposing sides of the pie. Example: play forward/backward, wireframe/solid view etc. Maybe there is more, but I think this could be a start. I would want to keep things separated: Menus to put all the things in there, pies as a quick way to perform frequently used tasks quicker and easier.

Brendon Murphy commented

2016-07-18 15:35:15 +02:00

Hi, @sebastian_k
Thanks for feedback, I'll look at the issue;s you have mentioned & make changes to some design elements, I'll have updated files in a few days.
I'm glad you like the activation system, it gives users greater flexibility.
Thanks again.

Hi, @sebastian_k Thanks for feedback, I'll look at the issue;s you have mentioned & make changes to some design elements, I'll have updated files in a few days. I'm glad you like the activation system, it gives users greater flexibility. Thanks again.

Brendon Murphy commented

2016-07-25 12:16:54 +02:00

Fixed most of the issues identified by @sebastian_k

Current Proposal: (2 parts)
Official Pie Menus:
This is exact same menu as Official Pie Menus

pie_menus_official.zip
Current behavior: The official pie menu's activate all the pies in the addon. this can & does cause conflicts with other addons that use the same hotkeys.
New behavior: The 3d view menus have individual activation so users have additional flexibility in what pies they want to enable or not. This does not interfere with other addons with the same hotkey, simply turn off the individual pie menus activation & other keymaps are respected. The clip editor pies would remain a single addon/menu activation as it's a specific area & the chance of conflicting pies is significantly lessened.
No Changes to the original addon other than the new activation system.

Current Proposal: (2nd part)
3d Viewport Pie Menus:
Currently in contrib, this extensive addon offers many common menus in pie menu form, it's design shows several styles of pie menus whilst remaining consistent & well organized. The basis for this addon was official pie menus, wazou pies, saidenka pies, help from italic & rewritten by meta-androcto be more Blender user friendly.
This addon is Not designed to replace the current Official pie menus, it can however live along side it in addons release as it's a substantial addon, it shows new methods & styles not currently in blender that are widely used by the pie menu writers. Many current pie menu coders use these styles to create their menus in a variety of addons. I think also this could help give a needed boost to pie menus in general.
Wiki page: https://wiki.blender.org/index.php/Extensions:2.6/Py/Scripts/3D_interaction/viewport_pies
Thanks.

Fixed most of the issues identified by @sebastian_k Current Proposal: (2 parts) Official Pie Menus: This is exact same menu as Official Pie Menus ![official pies.jpg](https://archive.blender.org/developer/F318199/official_pies.jpg) [pie_menus_official.zip](https://archive.blender.org/developer/F318201/pie_menus_official.zip) Current behavior: The official pie menu's activate all the pies in the addon. this can & does cause conflicts with other addons that use the same hotkeys. New behavior: The 3d view menus have individual activation so users have additional flexibility in what pies they want to enable or not. This does not interfere with other addons with the same hotkey, simply turn off the individual pie menus activation & other keymaps are respected. The clip editor pies would remain a single addon/menu activation as it's a specific area & the chance of conflicting pies is significantly lessened. No Changes to the original addon other than the new activation system. Current Proposal: (2nd part) 3d Viewport Pie Menus: Currently in contrib, this extensive addon offers many common menus in pie menu form, it's design shows several styles of pie menus whilst remaining consistent & well organized. The basis for this addon was official pie menus, wazou pies, saidenka pies, help from italic & rewritten by meta-androcto be more Blender user friendly. This addon is Not designed to replace the current Official pie menus, it can however live along side it in addons release as it's a substantial addon, it shows new methods & styles not currently in blender that are widely used by the pie menu writers. Many current pie menu coders use these styles to create their menus in a variety of addons. I think also this could help give a needed boost to pie menus in general. Wiki page: https://wiki.blender.org/index.php/Extensions:2.6/Py/Scripts/3D_interaction/viewport_pies Thanks.

Brendon Murphy commented

2016-07-26 00:07:27 +02:00

link to contrib: https://developer.blender.org/diffusion/BAC/browse/master/space_view3d_pie_menus/

Campbell Barton commented

2016-07-27 03:03:44 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2016-07-27 03:03:44 +02:00

First of all, who is the maintainer of this add-on (who to assign bugs to if there are problems?)

Also, general question - is anyone using this add-on for regular day-to-day work?

Blocking issues

These should be resolved before moving to master.

With all menus enabled: Pressing Tab on the default cube to enter edit-mode, automatically activates a second pie (Edit Selection Modes).
Incremental save behaves strangely when the file isn't saved (writes _001.blend into the current working directory), it should have a poll function or report an error. Its also checking for _ in the entire path (all leading directories), when choosing a new filename - this can't be correct.
UI option not to draw borders in the addon-prefereces this has no reason to be an option and should be removed.
/pie_apply_transform_menu/__init__.py Is defining operators such as ApplyTransformLocation, ApplyTransformRotation & ApplyTransformRotationScale - which only exist to call an existing operator with different arguments. I would guess the original author didn't know how to call an operator with options.
/pie_editor_switch_menu/__init__.py defines AreaTypePieOperator which references not existing class AreaTypePie.
/pie_editor_switch_menu/__init__.py references not existing class PieEditor.
/pie_delete_menu/__init__.py defines an operator DeleteLimitedDissolve which only exists to call bpy.ops.mesh.dissolve_limitedwhich it fails to do because its missing () at the end of the line, also, why does this operator exist?
/pie_select_menu/__init__.py defines SelectAllBySelection operator which calls select toggle twice, not only does it fail when there is no selection, the select operator already has an option to do this. (use SELECT argument)

General issues

/pie_proportional_menu/__init__.py Is defining far too many operators (one for every proportional edit type), this is a case where operator options should be used.
/pie_manipulator_menu/__init__.py a lot of repitetion which could be easily avoided by using operator arguments.
/pie_views_numpad_menu/__init__.py has an operator PerspOrthoView which only exists to call another operator, why?
/pie_views_numpad_menu/__init__.py defines bpy.types.Scene.cameratoto outside of register/unregister.
/pie_views_numpad_menu/__init__.py defines LockCameraTransforms which just applies to the active object (no reference to camera and doesn't take the current active camera...).
/pie_align_menu/__init__.py defines 3 operators, AlignX, AlignY, AlignZ, AlignToX0, AlignToY0, AlignToZ0, AlignXLeft (for left, right, font, top, bottom, each for X, Y, Z...), a single operator with axis options should be used here.

Really disappointed with the quality of this add-on, it seems nobody has checked the code or really tested all that much, its full of near repeated definitions which could be written in a much more compact way.

I can understand there it can be hard to avoid glitches and some errors are overlooked, but it seems there is not even an attempt to make this maintainable and reduce repetition.

The testing repository is where these things are supposed to be tested and ironed out.

First of all, who is the maintainer of this add-on (who to assign bugs to if there are problems?) Also, general question - is anyone using this add-on for regular day-to-day work? Blocking issues **** These should be resolved before moving to master. - With all menus enabled: Pressing Tab on the default cube to enter edit-mode, automatically activates a second pie (Edit Selection Modes). - Incremental save behaves strangely when the file isn't saved (writes `_001.blend` into the current working directory), it should have a poll function or report an error. Its also checking for `_` in the entire path (all leading directories), when choosing a new filename - this can't be correct. - UI option not to draw borders in the addon-prefereces this has no reason to be an option and should be removed. - `/pie_apply_transform_menu/__init__.py` Is defining operators such as `ApplyTransformLocation`, `ApplyTransformRotation` & `ApplyTransformRotationScale` - which only exist to call an existing operator with different arguments. I would guess the original author didn't know how to call an operator with options. - `/pie_editor_switch_menu/__init__.py` defines `AreaTypePieOperator` which references not existing class `AreaTypePie`. - `/pie_editor_switch_menu/__init__.py` references not existing class `PieEditor`. - `/pie_delete_menu/__init__.py` defines an operator `DeleteLimitedDissolve` which only exists to call `bpy.ops.mesh.dissolve_limited`which it fails to do because its missing `()` at the end of the line, also, why does this operator exist? - `/pie_select_menu/__init__.py` defines `SelectAllBySelection` operator which calls select toggle twice, not only does it fail when there is no selection, the select operator already has an option to do this. (use `SELECT` argument) General issues **** - `/pie_proportional_menu/__init__.py` Is defining **far** too many operators (one for every proportional edit type), this is a case where operator options should be used. - `/pie_manipulator_menu/__init__.py` a lot of repitetion which could be easily avoided by using operator arguments. - `/pie_views_numpad_menu/__init__.py` has an operator `PerspOrthoView` which only exists to call another operator, why? - `/pie_views_numpad_menu/__init__.py` defines `bpy.types.Scene.cameratoto` outside of register/unregister. - `/pie_views_numpad_menu/__init__.py` defines `LockCameraTransforms` which just applies to the active object (no reference to camera and doesn't take the current active camera...). - `/pie_align_menu/__init__.py ` defines 3 operators, `AlignX`, `AlignY`, `AlignZ`, `AlignToX0`, `AlignToY0`, `AlignToZ0`, `AlignXLeft` (for left, right, font, top, bottom, each for X, Y, Z...), a single operator with axis options should be used here. Really disappointed with the quality of this add-on, it seems nobody has checked the code or really tested all that much, its full of near repeated definitions which could be written in a much more compact way. I can understand there it can be hard to avoid glitches and some errors are overlooked, but it seems there is not even an attempt to make this maintainable and reduce repetition. The testing repository is where these things are supposed to be tested and ironed out.

Julian Eisel commented

2016-07-27 03:16:10 +02:00

While I'm fine with maintaining the C part of pies I'm probably not the right person to ask for maintaining the Add-on. At least not if it gets as big as proposed here.

Brendon Murphy commented

2016-07-27 05:58:07 +02:00

hi, thanks for review, I am author & maintainer of this addon.
I will look at the issues raised today & submit fixed version.
thanks.

hi, thanks for review, I am author & maintainer of this addon. I will look at the issues raised today & submit fixed version. thanks.

Brendon Murphy self-assigned this 2016-07-27 09:57:41 +02:00

Brendon Murphy commented

2016-07-28 13:17:48 +02:00

list of fixes & answers to review questions:

Blocking issues:

"With all menus enabled: Pressing Tab on the default cube to enter edit-mode, automatically activates a second pie (Edit Selection
Modes)."

Yes in this 2nd pie is in the same script, a sub pie, the design is to tab either top to edit mode or top right to editmode with selection
values added. The menu is also availible from the edit mode tab menu.

"Incremental save behaves strangely when the file isn't saved (writes _001.blend into the current working directory), it should have a
poll function or report an error. Its also checking for _ in the entire path (all leading directories), when choosing a new filename - this
can't be correct."

Yes, fixed, operator now is inactive unless .blend is saved & saves to location of parent .blend , added tooltip to reflect this.

  "UI option not to draw borders in the addon-prefereces this has no reason to be an option and should be removed."

Removed, this creates issue with visually blending other addons boxes into the layout so there's no separation between the pie menus addon.
Added End of Pie menu Activation Text to provide separation from other menus.

"/pie_apply_transform_menu/init.py Is defining operators such as ApplyTransformLocation, ApplyTransformRotation &
ApplyTransformRotationScale - which only exist to call an existing operator with different arguments. I would guess the original author didn't
know how to call an operator with options."

I don't see this as a showstopper. It's true it can be improved, but no harm done here.

"/pie_editor_switch_menu/init.py defines AreaTypePieOperator which references not existing class AreaTypePie.
/pie_editor_switch_menu/init.py references not existing class PieEditor."

Fixed, strange it worked at all under those circumstances.

"/pie_delete_menu/init.py defines an operator DeleteLimitedDissolve which only exists to call bpy.ops.mesh.dissolve_limited which it
fails to do because its missing () at the end of the line, also, why does this operator exist?"

Fixed, removed operator was not needed using built in.

"/pie_select_menu/init.py defines SelectAllBySelection operator which calls select toggle twice, not only does it fail when there is
no selection, the select operator already has an option to do this. (use SELECT argument)"

removed duplicate operator. also was unused operator, fixed.

General issues

"/pie_proportional_menu/init.py Is defining far too many operators (one for every proportional edit type), this is a case where
operator options should be used."

agreed will look at better ways to do this.

"/pie_manipulator_menu/init.py a lot of repitetion which could be easily avoided by using operator arguments."

agreed will look at better ways to do this. I have better way in menu form, will follow up.

" /pie_views_numpad_menu/init.py has an operator PerspOrthoView which only exists to call another operator, why?
/pie_views_numpad_menu/init.py defines bpy.types.Scene.cameratoto outside of register/unregister.
/pie_views_numpad_menu/init.py defines LockCameraTransforms which just applies to the active object (no reference to camera and
doesn't take the current active camera...)."

Fixes:
remove persportho operator & use direct operator,
moved bpy.types.Scene.cameratoto into register,
changed menu/operator name for LockCameraTransforms, now lock Object Transforms, which is more useful than just camera.

"/pie_align_menu/init.py defines 3 operators, AlignX, AlignY, AlignZ, AlignToX0, AlignToY0, AlignToZ0, AlignXLeft (for left, right,
font, top, bottom, each for X, Y, Z...), a single operator with axis options should be used here.

again, will look at better ways to do this.

please note, positioning operators in pies is difficult, having classes to define operators provides absolute control over positioning the operator within the pie.

thanks @ideasman42 for review

list of fixes & answers to review questions: **Blocking issues:** "With all menus enabled: Pressing Tab on the default cube to enter edit-mode, automatically activates a second pie (Edit Selection Modes)." * Yes in this 2nd pie is in the same script, a sub pie, the design is to tab either top to edit mode or top right to editmode with selection values added. The menu is also availible from the edit mode tab menu. "Incremental save behaves strangely when the file isn't saved (writes _001.blend into the current working directory), it should have a poll function or report an error. Its also checking for _ in the entire path (all leading directories), when choosing a new filename - this can't be correct." * Yes, fixed, operator now is inactive unless .blend is saved & saves to location of parent .blend , added tooltip to reflect this. ``` "UI option not to draw borders in the addon-prefereces this has no reason to be an option and should be removed." ``` * Removed, this creates issue with visually blending other addons boxes into the layout so there's no separation between the pie menus addon. Added End of Pie menu Activation Text to provide separation from other menus. "/pie_apply_transform_menu/__init__.py Is defining operators such as ApplyTransformLocation, ApplyTransformRotation & ApplyTransformRotationScale - which only exist to call an existing operator with different arguments. I would guess the original author didn't know how to call an operator with options." * I don't see this as a showstopper. It's true it can be improved, but no harm done here. "/pie_editor_switch_menu/__init__.py defines AreaTypePieOperator which references not existing class AreaTypePie. /pie_editor_switch_menu/__init__.py references not existing class PieEditor." * Fixed, strange it worked at all under those circumstances. "/pie_delete_menu/__init__.py defines an operator DeleteLimitedDissolve which only exists to call bpy.ops.mesh.dissolve_limited which it fails to do because its missing () at the end of the line, also, why does this operator exist?" * Fixed, removed operator was not needed using built in. "/pie_select_menu/__init__.py defines SelectAllBySelection operator which calls select toggle twice, not only does it fail when there is no selection, the select operator already has an option to do this. (use SELECT argument)" * removed duplicate operator. also was unused operator, fixed. **General issues** "/pie_proportional_menu/__init__.py Is defining far too many operators (one for every proportional edit type), this is a case where operator options should be used." * agreed will look at better ways to do this. "/pie_manipulator_menu/__init__.py a lot of repitetion which could be easily avoided by using operator arguments." * agreed will look at better ways to do this. I have better way in menu form, will follow up. " /pie_views_numpad_menu/__init__.py has an operator PerspOrthoView which only exists to call another operator, why? /pie_views_numpad_menu/__init__.py defines bpy.types.Scene.cameratoto outside of register/unregister. /pie_views_numpad_menu/__init__.py defines LockCameraTransforms which just applies to the active object (no reference to camera and doesn't take the current active camera...)." * Fixes: * remove persportho operator & use direct operator, * moved bpy.types.Scene.cameratoto into register, * changed menu/operator name for LockCameraTransforms, now lock Object Transforms, which is more useful than just camera. "/pie_align_menu/__init__.py defines 3 operators, AlignX, AlignY, AlignZ, AlignToX0, AlignToY0, AlignToZ0, AlignXLeft (for left, right, font, top, bottom, each for X, Y, Z...), a single operator with axis options should be used here. * again, will look at better ways to do this. please note, positioning operators in pies is difficult, having classes to define operators provides absolute control over positioning the operator within the pie. thanks @ideasman42 for review

Brendon Murphy commented

2016-08-03 03:35:47 +02:00

committed first half of this task, added individual hotkey activation for official pies, changed category from User Interface to "Pie Menus"