Multiscatter GGX problem when the Roughness is zero #49411

Closed
opened 2016-09-20 09:20:46 +02:00 by Leroy · 9 comments

System Information
windows 7 64bit sp1

Blender Version
Broken: 2.78rc2 9d70344
Worked: (optional)

Multiscatter GGX not right when the Roughness setting to zero and the big value for the Filter Gloss. both glass and glossy.

Exact steps for others to reproduce the error

some screenshot at flow:

the glossy shader:
01.png
02.png

the glass shader
03.png
04.png

you can find when the roughness is zero and Filter Gloss settled to 10, the result have some problem, glossy will become some dark, and the glass become blur, I am not sure this a bug. By the way ,the Refraction Shader don't have Multiscatter GGX mode is intentional? sorry for my bad English, thanks!

bug.blend

**System Information** windows 7 64bit sp1 **Blender Version** Broken: 2.78rc2 9d70344 Worked: (optional) Multiscatter GGX not right when the Roughness setting to zero and the big value for the Filter Gloss. both glass and glossy. **Exact steps for others to reproduce the error** some screenshot at flow: the glossy shader: ![01.png](https://archive.blender.org/developer/F364954/01.png) ![02.png](https://archive.blender.org/developer/F364956/02.png) the glass shader ![03.png](https://archive.blender.org/developer/F364958/03.png) ![04.png](https://archive.blender.org/developer/F364960/04.png) you can find when the roughness is zero and Filter Gloss settled to 10, the result have some problem, glossy will become some dark, and the glass become blur, I am not sure this a bug. By the way ,the Refraction Shader don't have Multiscatter GGX mode is intentional? sorry for my bad English, thanks! [bug.blend](https://archive.blender.org/developer/F364965/bug.blend)
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

Added subscriber: @Leroy-Xie

Added subscriber: @Leroy-Xie

Added subscribers: @LukasStockner, @Sergey

Added subscribers: @LukasStockner, @Sergey
Lukas Stockner was assigned by Sergey Sharybin 2016-09-20 12:31:41 +02:00

@LukasStockner, to my knowledge GGX/Beckmann ar falling back to Sharp when roughness is 0. Might worth doing the same for multiscatter perhaps? That should also fix the reported issue here.

@LukasStockner, to my knowledge GGX/Beckmann ar falling back to Sharp when roughness is 0. Might worth doing the same for multiscatter perhaps? That should also fix the reported issue here.

Added subscriber: @ThomasDinges

Added subscriber: @ThomasDinges

That's not the case, at least not when we use Filter Glossy (see e.g. GlassBsdfNode::simplify_settings). So in case of a non sharp closure, in combination with Filter Glossy, the closure isn't changed.

That's not the case, at least not when we use Filter Glossy (see e.g. GlassBsdfNode::simplify_settings). So in case of a non sharp closure, in combination with Filter Glossy, the closure isn't changed.

This issue was referenced by blender/cycles@bb9607dd17

This issue was referenced by blender/cycles@bb9607dd17ee29665200c631b87bd91e772ab376

This issue was referenced by 0b89b31a18

This issue was referenced by 0b89b31a1842edba162e3ca01b556906c8adee52
Member

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#49411
No description provided.