VSE Scene Strip (in "Use Sequence" mode) Incompatible with certain Effect Strips #49424

New Issue

Matt · 2016-09-22T07:07:21+02:00

Matt commented

2016-09-22 07:07:21 +02:00

System Information
Windows 10, Quadro K2000

Blender Version
Broken: 2.77, 2.78

Short description of error
The Scene strip (in "Use Sequence" mode) doesn't handle certain types of strips within the referenced scene correctly. For Multicam Selector strip, the output is blank. For Adjustment strip, blender crashes!

Exact steps for others to reproduce the error

Using the attached blend file you can follow these steps:

Scan through the short scene. Notice that it switches from black to white.
Switch to scene 2: multicam scene
Scan through the scene. Notice that it is not rendered as expected. It should be the same as the first scene but it's just blank.
Switch to scene 3: adjustment. Notice that because of the adjustment. The output is a light grey.
Switch to scene 4: adjustment scene. Blender crashes.

Finally, I've never worked on blender's code base before but I believe I have a solid attempt at a fix but I'm not sure what the best way to convey it is. I have my change committed locally in git. What would be the best way to go about trying to get this change reviewed?

scene_effects.blend

**System Information** Windows 10, Quadro K2000 **Blender Version** Broken: 2.77, 2.78 **Short description of error** The Scene strip (in "Use Sequence" mode) doesn't handle certain types of strips within the referenced scene correctly. For Multicam Selector strip, the output is blank. For Adjustment strip, blender crashes! **Exact steps for others to reproduce the error** Using the attached blend file you can follow these steps: 1. Scan through the short scene. Notice that it switches from black to white. 2. Switch to scene 2: multicam scene 3. Scan through the scene. Notice that it is not rendered as expected. It should be the same as the first scene but it's just blank. 4. Switch to scene 3: adjustment. Notice that because of the adjustment. The output is a light grey. 5. Switch to scene 4: adjustment scene. Blender crashes. Finally, I've never worked on blender's code base before but I believe I have a solid attempt at a fix but I'm not sure what the best way to convey it is. I have my change committed locally in git. What would be the best way to go about trying to get this change reviewed? [scene_effects.blend](https://archive.blender.org/developer/F366093/scene_effects.blend)

Matt commented

2016-09-22 07:07:21 +02:00

Changed status to: 'Open'

Matt commented

2016-09-22 07:07:21 +02:00

Added subscriber: @HyperSphere

Philipp Oeser commented

2016-09-22 10:27:27 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2016-09-22 10:27:27 +02:00

@HyperSphere: didnt have a look at the issue yet, but you can post your diff here

https://developer.blender.org/differential/diff/create/ (if its ready for review) or
https://developer.blender.org/paste/ (just to have a quick look -- no real review features, but can still be commented on)

@HyperSphere: didnt have a look at the issue yet, but you can post your diff here - https://developer.blender.org/differential/diff/create/ (if its ready for review) or - https://developer.blender.org/paste/ (just to have a quick look -- no real review features, but can still be commented on)

Matt commented

2016-09-22 13:48:11 +02:00

Thanks for the info!

Here is the diff:
https://developer.blender.org/D2252

Thanks!

Matt

Thanks for the info! Here is the diff: https://developer.blender.org/D2252 Thanks! Matt

Philipp Oeser commented

2016-09-23 22:03:57 +02:00

@HyperSphere: thanx for the patch!
Sequencer is not really a part of blender that I am very familiar with, at first glance I can confirm the patch seems to solve issues mentioned in the report. Hope I can spend some more time checking more in depth...

@HyperSphere: thanx for the patch! Sequencer is not really a part of blender that I am very familiar with, at first glance I can confirm the patch seems to solve issues mentioned in the report. Hope I can spend some more time checking more in depth...

Philipp Oeser commented

2016-09-23 22:38:32 +02:00

btw: issues from report confirmed

Sergey Sharybin commented

2016-09-29 15:01:51 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2016-09-29 15:01:51 +02:00

I've committed D2252 now. Does it fix all the issues reported here?

I've committed [D2252](https://archive.blender.org/developer/D2252) now. Does it fix all the issues reported here?

Matt commented

2016-09-29 19:23:00 +02:00

Before I sent it out, I confirmed that the reported issues with the linked blend file don't occur when using blender built on Windows with the fix Diff you linked.

I can pull from head and reconfirm on Windows and check it on Linux (Ubuntu) as well if you would like.

Before I sent it out, I confirmed that the reported issues with the linked blend file don't occur when using blender built on Windows with the fix Diff you linked. I can pull from head and reconfirm on Windows and check it on Linux (Ubuntu) as well if you would like.

Olly Funkster commented

2016-10-13 12:14:21 +02:00

Added subscriber: @Funkster-3

Olly Funkster commented

2016-10-13 12:14:21 +02:00

Hi folks,

Is this related to keyframed changes on strips not being used correctly when the scene is inserted into another in "use sequence" mode?

In 2.78, if you keyframe some audio levels in a scene and then insert that scene into another some time after the start, the keyframed values happen at the wrong time - it seems like the time is measured from the start of the second scene, rather from the time the first scene's start position.

To reproduce:
scene 1) audio strip 10s long, volume at 1 at start, keyframe at 5s at volume 1, another keyframe at 6s at volume 0.
scene 2) insert scene 1 as sequence, at position 3s.

Render scene 2 as animation, audio will change volume at 5s from start (2s from start of scene 1), rather than at 8s.

Hi folks, Is this related to keyframed changes on strips not being used correctly when the scene is inserted into another in "use sequence" mode? In 2.78, if you keyframe some audio levels in a scene and then insert that scene into another some time after the start, the keyframed values happen at the wrong time - it seems like the time is measured from the start of the second scene, rather from the time the first scene's start position. To reproduce: scene 1) audio strip 10s long, volume at 1 at start, keyframe at 5s at volume 1, another keyframe at 6s at volume 0. scene 2) insert scene 1 as sequence, at position 3s. Render scene 2 as animation, audio will change volume at 5s from start (2s from start of scene 1), rather than at 8s.

Olly Funkster commented

2016-10-14 13:04:25 +02:00

incorrect_sequence_keyframes.blend

Since I found that this applies to other strip types, I have made a blend file as an example. In the scene "sub" you can see the text count from 1 to 5. In the scene "master", "sub is inserted at 2s, and the numbers start counting from 3 instead of 1.

[incorrect_sequence_keyframes.blend](https://archive.blender.org/developer/F378272/incorrect_sequence_keyframes.blend) Since I found that this applies to other strip types, I have made a blend file as an example. In the scene "sub" you can see the text count from 1 to 5. In the scene "master", "sub is inserted at 2s, and the numbers start counting from 3 instead of 1.

Matt commented

2016-10-14 13:57:39 +02:00

Hey Olly,

It's definitely conceptually similar. although it relates to the way strips reference the animation data as opposed to referencing other strips. I took a quick look and it looks like it's more complicated than I originally thought. I think this is a different enough issue to merit another task.

If you're interested in looking into the code you can look at the solution to the original issue which is here:

https://developer.blender.org/D2252#d494a504

Thanks,

Matt

Hey Olly, It's definitely conceptually similar. although it relates to the way strips reference the animation data as opposed to referencing other strips. I took a quick look and it looks like it's more complicated than I originally thought. I think this is a different enough issue to merit another task. If you're interested in looking into the code you can look at the solution to the original issue which is here: https://developer.blender.org/D2252#d494a504 Thanks, Matt

Olly Funkster commented

2016-10-14 16:26:06 +02:00

Thanks Matt. I've created a new task (https://developer.blender.org/T49658), hope that's okay!

I've had a dig through with the debugger and don't see any data that could be used to correct the error at the point where the curves are being evaluated.

Thanks Matt. I've created a new task (https://developer.blender.org/T49658), hope that's okay! I've had a dig through with the debugger and don't see any data that could be used to correct the error at the point where the curves are being evaluated.

Matt commented

2017-08-30 10:27:33 +02:00

I've just checked this out in the 2.79 rc 1 and none of the issues reported in the original issue persist. Closing unless there are objections. Apologies for the long delay here, I didn't realize I had never closed this.

Thanks!

Matt

I've just checked this out in the 2.79 rc 1 and none of the issues reported in the original issue persist. Closing unless there are objections. Apologies for the long delay here, I didn't realize I had never closed this. Thanks! Matt

Matt commented

2017-08-30 10:27:50 +02:00

Changed status from 'Open' to: 'Resolved'

Matt closed this issue

2017-08-30 10:27:50 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

VSE Scene Strip (in "Use Sequence" mode) Incompatible with certain Effect Strips #49424