SVG Import scaling is wrong on some files #50048

New Issue

Real Name · 2016-11-16T13:26:46+01:00

Real Name commented

2016-11-16 13:26:46 +01:00

Blender Version
2.78a, e8299c8

Short description of error
SVG files with viewBox attribute that differ from with/height attributes are scaled wrong.

Exact steps for others to reproduce the error
Cteate SVG file with content below:

  <svg width="1000mm" height="1000mm" viewBox="0 0 1 1">
      <g>
          <path d=" 
              M  0.0,  0.0
              L  1.0,  0.0
              L  1.0,  1.0
              L  0.0,  1.0
              C
          "/>
      </g>
  </svg>

And then import it with File -> Import -> Scalable Vector Graphics (.svg). It is expected that the square will be 1x1 Blender units, but it's 3543x3543 Blender units.

That is because scaling is performed twice in SVGMatrixFromNode() function in import_svg.py file.

I don't quite understand what's happening during the function and why first scaling is needed, but I've made a "patch" that, I believe, kinda solves the issue. I may be totally wrong with this solution =)

import_svg.diff

**Blender Version** 2.78a, e8299c8 **Short description of error** SVG files with `viewBox` attribute that differ from with/height attributes are scaled wrong. **Exact steps for others to reproduce the error** Cteate SVG file with content below: ``` <svg width="1000mm" height="1000mm" viewBox="0 0 1 1"> <g> <path d=" M 0.0, 0.0 L 1.0, 0.0 L 1.0, 1.0 L 0.0, 1.0 C "/> </g> </svg> ``` And then import it with `File -> Import -> Scalable Vector Graphics (.svg)`. It is expected that the square will be **1x1** Blender units, but it's **3543x3543** Blender units. That is because scaling is performed twice in `SVGMatrixFromNode()` function in `import_svg.py` file. I don't quite understand what's happening during the function and why first scaling is needed, but I've made a "patch" that, I believe, kinda solves the issue. I may be totally wrong with this solution =) [import_svg.diff](https://archive.blender.org/developer/F401638/import_svg.diff)

Real Name commented

2016-11-16 13:26:46 +01:00

Changed status to: 'Open'

Real Name commented

2016-11-16 13:26:46 +01:00

Added subscriber: @uvx3

Vuk Gardašević commented

2016-11-23 11:06:56 +01:00

Added subscribers: @Sergey, @VukGardasevic

Vuk Gardašević commented

2016-11-23 11:06:56 +01:00

I did an import on the generated SVG file with the code from the example and the scale seems off.

@Sergey when you have time, can you look into it. Thanks. :)

I did an import on the generated SVG file with the code from the example and the scale seems off. @Sergey when you have time, can you look into it. Thanks. :)

Sergey Sharybin commented

2016-11-23 11:12:35 +01:00

@uvx3, can you submit diff in an unified format (o even better, diff generated by git diff) ?

@uvx3, can you submit diff in an unified format (o even better, diff generated by `git diff`) ?

Real Name commented

2016-11-24 10:17:00 +01:00

Sorry for the wrong diff format.

Here's an output of diff -u.

import_svg.diff

It's strange, but I cant attach the python file. Here's a link to the file I've uploaded to github.

Sorry for the wrong diff format. Here's an output of `diff -u`. [import_svg.diff](https://archive.blender.org/developer/F405777/import_svg.diff) It's strange, but I cant attach the python file. Here's a [link to the file ](https://raw.githubusercontent.com/bb-q/scripts/master/import_svg.py) I've uploaded to github.

Brendon Murphy commented

2019-06-11 11:16:02 +02:00

Added subscribers: @howardt, @BrendonMurphy

Brendon Murphy commented

2019-06-11 11:16:02 +02:00

@howardt anything to do here?

Sergey Sharybin commented

2019-06-11 11:28:13 +02:00

@BrendonMurphy, not sure why Howard is involved here. If this is still an issue the patch needs to be updated against latest sources.

Brendon Murphy commented

2019-06-11 11:47:43 +02:00

@Sergey my mistake, I was looking at his addon in contrib

Brendon Murphy commented

2019-06-11 11:47:58 +02:00

Removed subscriber: @howardt

Brendon Murphy commented

2019-06-11 11:50:55 +02:00

@Sergey was this fixed by c2aef4a98f: SVG: Fix wrong closed path with quadratic segments?

Sergey Sharybin commented

2019-06-11 12:03:13 +02:00

@BrendonMurphy, that sounds as an unrelated change, but there were other fixes related to this one, i.e. b302fdf053.

I've tried to import the demo SVN from this task and it shows as 1x1 plane, which is what the task description says is expected.
So my guess is that everything is working fine now.

@BrendonMurphy, that sounds as an unrelated change, but there were other fixes related to this one, i.e. b302fdf053. I've tried to import the demo SVN from this task and it shows as 1x1 plane, which is what the task description says is expected. So my guess is that everything is working fine now.

Richard Antalik commented

2020-02-14 22:43:02 +01:00

Added subscriber: @iss