Grease Pencil + OpenGL crash in VSE #50051

New Issue

Crepe · 2016-11-16T15:48:55+01:00

Crepe commented

2016-11-16 15:48:55 +01:00

System Information
Geforce 1060
Ubuntu 16.04 64bits

Blender Version
Broken:
*2.78a

latest on buildbot: 8b29059 (Wed Nov 16 04:25:24 2016 )

Short description of error
Crash of Blender while doing an opengl render of grease pencil

System Information
Operating system and graphics card

Exact steps for others to reproduce the error
1- set the current frame to 1
2- render the animation in opengl "OpenGL render active viewport"
3- set the current from to 10
4-hit "refresh sequencer"
5-enjoy the crash...

It's not the same bug as:
https:*developer.blender.org/T49996 or https:*developer.blender.org/T49975
but that's at least the third bug i encounter in this area, maybe there is a bigger issue underneath

bug.blend

**System Information** Geforce 1060 Ubuntu 16.04 64bits **Blender Version** Broken: *2.78a * latest on buildbot: 8b29059 (Wed Nov 16 04:25:24 2016 ) **Short description of error** Crash of Blender while doing an opengl render of grease pencil **System Information** Operating system and graphics card **Exact steps for others to reproduce the error** 1- set the current frame to 1 2- render the animation in opengl "OpenGL render active viewport" 3- set the current from to 10 4-hit "refresh sequencer" 5-enjoy the crash... It's not the same bug as: https:*developer.blender.org/T49996 or https:*developer.blender.org/T49975 but that's at least the third bug i encounter in this area, maybe there is a bigger issue underneath [bug.blend](https://archive.blender.org/developer/F401737/bug.blend)

Crepe commented

2016-11-16 15:48:55 +01:00

Changed status to: 'Open'

Crepe commented

2016-11-16 15:48:55 +01:00

Added subscriber: @CrepeC

Crepe commented

2016-11-16 15:51:42 +01:00

bug.blend

[bug.blend](https://archive.blender.org/developer/F401739/bug.blend)

dono dono commented

2016-11-16 15:52:37 +01:00

Added subscriber: @ParrotDenis

dono dono commented

2016-11-16 15:52:37 +01:00

Same bug on windows 64 NVIDIA gtx780

Antonio Vazquez commented

2016-11-16 17:07:01 +01:00

Added subscriber: @antoniov

Antonio Vazquez commented

2016-11-16 17:07:01 +01:00

I can reproduce on Windows 10. Maybe this is related to one previous fix, we need to look in detail.

Antonio Vazquez commented

2016-11-16 17:41:40 +01:00

Added subscriber: @dfelinto

Antonio Vazquez commented

2016-11-16 17:41:40 +01:00

I have running some debugs running the operator and I got the error here:

sequencer_refresh_all_exec->
	BKE_sequencer_free_imbuf->

	BKE_sequencer_cache_cleanup->
		BKE_sequencer_preprocessed_cache_cleanup->
			IMB_freeImBuf->
				imb_freerectfloatImBuf (!Error)

I have seen you only need run opengl render with GP and then press refresh button to get the error. If you remove grease pencil or don't run the opengl render, works.

There is a problem when the function try to free the memory because ibuf->rect_float has an invalid value here:

void imb_freerectfloatImBuf(ImBuf *ibuf)
{
	if (ibuf == NULL) return;

	if (ibuf->rect_float && (ibuf->mall & IB_rectfloat)) {

	MEM_freeN(ibuf->rect_float);   // THIS VALUE IS NOT VALID !!!! ERROR!!!
	ibuf->rect_float = NULL;

	}.
..
..

@dfelinto I don't know this part of the code and how imbuffers works and it looks this bug can be related to #49975, could you please take a look?

I have running some debugs running the operator and I got the error here: ``` sequencer_refresh_all_exec-> BKE_sequencer_free_imbuf-> ``` BKE_sequencer_cache_cleanup-> BKE_sequencer_preprocessed_cache_cleanup-> IMB_freeImBuf-> imb_freerectfloatImBuf (!Error) I have seen you only need run opengl render with GP and then press refresh button to get the error. If you remove grease pencil or don't run the opengl render, works. There is a problem when the function try to free the memory because **ibuf->rect_float** has an invalid value here: ``` void imb_freerectfloatImBuf(ImBuf *ibuf) { if (ibuf == NULL) return; ``` ``` if (ibuf->rect_float && (ibuf->mall & IB_rectfloat)) { ``` MEM_freeN(ibuf->rect_float); // THIS VALUE IS NOT VALID !!!! ERROR!!! ibuf->rect_float = NULL; ``` }. .. .. ``` @dfelinto I don't know this part of the code and how imbuffers works and it looks this bug can be related to #49975, could you please take a look?

Dalai Felinto commented

2016-11-16 18:05:40 +01:00

Hi @antoniov this bug is present even in Blender 2.78a. And even if we revert 0b9b8ab2 the problem is still there. But I will try to debug a bit to see if I have an idea of what can it be.

Hi @antoniov this bug is present even in Blender 2.78a. And even if we revert 0b9b8ab2 the problem is still there. But I will try to debug a bit to see if I have an idea of what can it be.

Dalai Felinto commented

2016-11-16 18:10:14 +01:00

By the way I'm getting the crash by doing:

F12
Opengl render

F12

In Blender 2.78 doing (1) + (2) is enough to get a crash.

By the way I'm getting the crash by doing: - F12 - Opengl render # F12 In Blender 2.78 doing (1) + (2) is enough to get a crash.

Dalai Felinto commented

2016-11-16 19:00:29 +01:00

The bug was actually introduced in eaea4ea5 (Grease Pencil v2 branch)

The bug was actually introduced in eaea4ea5 (Grease Pencil v2 branch)

Antonio Vazquez commented

2016-11-16 19:08:17 +01:00

Let me see if it is related to the GP render passes.

Antonio Vazquez commented

2016-11-16 19:20:48 +01:00

@dfelinto I think the reason is the renderpasses must not be created in sequence mode. I have tested this change and I 'm unable to get the error again, could you test before commit?

diff --git a/source/blender/editors/render/render_opengl.c b/source/blender/editors/render/render_opengl.c
index 16842ef..e1e2314 100644

  - a/source/blender/editors/render/render_opengl.c

+++ b/source/blender/editors/render/render_opengl.c
@@ -553,7 +553,9 @@ static void screen_opengl_render_apply(OGLRender *oglrender)
 		RE_SetActiveRenderView(oglrender->re, rv->name);
 		oglrender->view_id = view_id;
 		/* add grease pencil passes */

add_gpencil_renderpass(oglrender, rr, rv);

+		if (!oglrender->is_sequencer) {
+			add_gpencil_renderpass(oglrender, rr, rv);
+		}
 		/* render composite */
 		screen_opengl_render_doit(oglrender, rr);
 	}

@dfelinto I think the reason is the renderpasses must not be created in sequence mode. I have tested this change and I 'm unable to get the error again, could you test before commit? ``` diff --git a/source/blender/editors/render/render_opengl.c b/source/blender/editors/render/render_opengl.c index 16842ef..e1e2314 100644 ``` - a/source/blender/editors/render/render_opengl.c ``` +++ b/source/blender/editors/render/render_opengl.c @@ -553,7 +553,9 @@ static void screen_opengl_render_apply(OGLRender *oglrender) RE_SetActiveRenderView(oglrender->re, rv->name); oglrender->view_id = view_id; /* add grease pencil passes */ ``` - add_gpencil_renderpass(oglrender, rr, rv); ``` + if (!oglrender->is_sequencer) { + add_gpencil_renderpass(oglrender, rr, rv); + } /* render composite */ screen_opengl_render_doit(oglrender, rr); }

Antonio Vazquez self-assigned this 2016-11-16 19:30:38 +01:00

Dalai Felinto commented

2016-11-16 20:23:57 +01:00

That certainly stops the crashes. I really think the grease pencil and sequencer should be rethought. But the patch at least seems to prevent the crash. That said it would be nice to understand what's going on, and add it as a code comment before the if (!oglrender->is_sequencer) { line.

That certainly stops the crashes. I really think the grease pencil and sequencer should be rethought. But the patch at least seems to prevent the crash. That said it would be nice to understand what's going on, and add it as a code comment before the `if (!oglrender->is_sequencer) {` line.

Antonio Vazquez commented

2016-11-16 21:30:30 +01:00

Yes, we need to rethink not only opengl render of grease pencil in sequencer, but for all modes.

Now, make compositing with grease pencil is not easy and we need integrate better the render workflow. I think this must be a topic for the 2.8 version and it's one of the points we are working.

I'm going to commit the fix because what is sure is we don't need render passes in the sequencer.

Yes, we need to rethink not only opengl render of grease pencil in sequencer, but for all modes. Now, make compositing with grease pencil is not easy and we need integrate better the render workflow. I think this must be a topic for the 2.8 version and it's one of the points we are working. I'm going to commit the fix because what is sure is we don't need render passes in the sequencer.

blender-admin commented

2016-11-16 21:33:47 +01:00

This issue was referenced by e400f4a53e

This issue was referenced by e400f4a53ec435b8c93c309896e63393c5b70bf3

Antonio Vazquez commented

2016-11-16 21:35:12 +01:00

Changed status from 'Open' to: 'Resolved'

Antonio Vazquez closed this issue

2016-11-16 21:35:12 +01:00

dono dono commented

2016-11-19 03:16:03 +01:00

It works ! Thanks Antonio and Dalai :)

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Grease Pencil + OpenGL crash in VSE #50051

F12