Cycles cull option ui problem #50460

New Issue

Ronny G · 2017-01-18T10:12:47+01:00

Ronny G commented

2017-01-18 10:12:47 +01:00

System Information
ubuntu 16.04, 630gt

Blender Version
Broken: master 0a446d7

Short description of error

if the option "use camera cull" is active in the simplify panel the per object (use camera cull) setting is grayed out and if the "use distance cull" is active both per object options are active

that would work https://hastebin.com/odoyelozej.vbs

**System Information** ubuntu 16.04, 630gt **Blender Version** Broken: master 0a446d7 **Short description of error** if the option "use camera cull" is active in the simplify panel the per object (use camera cull) setting is grayed out and if the "use distance cull" is active both per object options are active that would work https://hastebin.com/odoyelozej.vbs

Ronny G commented

2017-01-18 10:12:47 +01:00

Changed status to: 'Open'

Ronny G commented

2017-01-18 10:12:47 +01:00

Added subscriber: @nudelZ

Vuk Gardašević commented

2017-01-19 18:17:13 +01:00

Added subscriber: @VukGardasevic

Vuk Gardašević commented

2017-01-19 18:17:13 +01:00

The behavior of .active with rows that share the same parent can be an issue that can show up elsewhere in the UI, so adding user interface tag too.

If it is an expected behavior, it probably needs documenting the proper usage in this case.
Possibly .disabled acts similarly too.

The behavior of `.active` with rows that share the same parent can be an issue that can show up elsewhere in the UI, so adding user interface tag too. If it is an expected behavior, it probably needs documenting the proper usage in this case. Possibly `.disabled ` acts similarly too.

Dalai Felinto commented

2017-01-20 09:54:24 +01:00

Added subscriber: @dfelinto

Thomas Dinges was assigned by Dalai Felinto

2017-01-20 09:54:24 +01:00

Dalai Felinto commented

2017-01-20 09:54:24 +01:00

Thomas, care to look at it?

Thomas Dinges commented

2017-01-20 10:37:39 +01:00

I don't see how this is an underlying issue with the layout engine. Using a .active or .disabled tag, assigned to a certain layout block will affect all of its assigned properties. So using two different UI blocks is a proper fix.

Will commit a fix based on Ronnys suggestion.

I don't see how this is an underlying issue with the layout engine. Using a .active or .disabled tag, assigned to a certain layout block will affect all of its assigned properties. So using two different UI blocks is a proper fix. Will commit a fix based on Ronnys suggestion.

blender-admin commented

2017-01-20 10:58:03 +01:00

This issue was referenced by blender/cycles@72abe48a66

This issue was referenced by blender/cycles@72abe48a66b3d6fdd5b850691a451670e96396ac

blender-admin commented

2017-01-20 10:58:03 +01:00

This issue was referenced by ff1b850081

This issue was referenced by ff1b850081b067ea0b989bdc62c2d85f36e23524

Thomas Dinges commented

2017-01-20 10:58:40 +01:00

Changed status from 'Open' to: 'Resolved'

Thomas Dinges closed this issue

2017-01-20 10:58:40 +01:00

Vuk Gardašević commented

2017-01-20 21:02:50 +01:00

In #50460#413079, @ThomasDinges wrote:
I don't see how this is an underlying issue with the layout engine. Using a .active or .disabled tag, assigned to a certain layout block will affect all of its assigned properties. So using two different UI blocks is a proper fix.

Will commit a fix based on Ronnys suggestion.

I do understand but:

It's not documented in the Python Docs
.alert behaves differently (it's capable of marking individual entries of children)
complicates generated code - especially for operators aligned in a row (for instance, something similar to thing in development_icons_get.py add-on)

To show the point this is the modified code from D2464.

Using alert:

                for i in range(1, strip_channel):
                    if (i % BT_ROW) == 1:
                        row = col.row(align=True)

                    row.alert = True if i == strip.multicam_source else False
                    row.operator("sequencer.cut_multicam", text="%d" % i).camera = i

Workarond for .active:

                for i in range(1, strip_channel):
                    if (i % BT_ROW) == 1:
                        row = col.row(align=True)

                    # Workaround - .active has to have a separate UI block to work
                    if i == strip.multicam_source:
                        sub = row.row(align=True)
                        sub.active = True
                        sub.operator("sequencer.cut_multicam", text="%d" % i).camera = i
                    else:
                        sub_1 = row.row(align=True)
                        sub_1.active = False
                        sub_1.operator("sequencer.cut_multicam", text="%d" % i).camera = i

Anyway, this could be a Topic for 2.8 and it is probably outside of the scope of this task.

> In #50460#413079, @ThomasDinges wrote: > I don't see how this is an underlying issue with the layout engine. Using a .active or .disabled tag, assigned to a certain layout block will affect all of its assigned properties. So using two different UI blocks is a proper fix. > > Will commit a fix based on Ronnys suggestion. I do understand but: 1) It's not documented in the Python Docs 2) `.alert` behaves differently (it's capable of marking individual entries of children) 3) complicates generated code - especially for operators aligned in a row (for instance, something similar to thing in `development_icons_get.py` add-on) To show the point this is the modified code from [D2464](https://archive.blender.org/developer/D2464). Using `alert`: ``` for i in range(1, strip_channel): if (i % BT_ROW) == 1: row = col.row(align=True) row.alert = True if i == strip.multicam_source else False row.operator("sequencer.cut_multicam", text="%d" % i).camera = i ``` Workarond for `.active`: ``` for i in range(1, strip_channel): if (i % BT_ROW) == 1: row = col.row(align=True) # Workaround - .active has to have a separate UI block to work if i == strip.multicam_source: sub = row.row(align=True) sub.active = True sub.operator("sequencer.cut_multicam", text="%d" % i).camera = i else: sub_1 = row.row(align=True) sub_1.active = False sub_1.operator("sequencer.cut_multicam", text="%d" % i).camera = i ``` Anyway, this could be a Topic for 2.8 and it is probably outside of the scope of this task.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Cycles cull option ui problem #50460