Page MenuHome
Maniphest T51321

AlembicObjectPath has a fixed-size char[]
Open, Confirmed, LowPublic
Actions

Description

AlembicObjectPath (see DNA_cachefile_types.h) has a fixed-size char[] buffer.

In rB3128600a8ab2badd9ea39c80133f15f766794ec6#142412, @LazyDodo (LazyDodo) wrote:

if the object path can be arbitrarily large it's gonna be a matter of time before someone comes with a file with 4097 byte object path, why not just allocate the ram you need?

I think that's a good idea, and that's what this task is for.

Details

Differential Revisions
D2951: Fix T51321 - AlembicObjectPath has a fixed-size char[]
Type
To Do

Related Objects
Search...

Event Timeline

Brecht Van Lommel (brecht) changed Type from Bug to To Do.May 20 2017, 5:40 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

Doesn't belong in the bug tracker I think, so changed type. Not sure paths longer than 4096 are supported by any commonly used OS even.

LazyDodo (LazyDodo) added a comment.May 20 2017, 5:53 PM

it's an internal path inside an alembic file, we should not impose any OS related restrictions to that in the first place?

Brecht Van Lommel (brecht) added a comment.EditedMay 20 2017, 5:54 PM

I agree such hardcoded limits are not helpful, just saying that this might not actually affect anyone in practice. Mainly it's a waste of memory usage.

Sybren A. Stüvel (sybren) added a comment.May 21 2017, 6:41 PM

The "object path" is not a filesystem path, so it isn't affected by OS related restrictions. This is something we should address at some point, even though in practice I have yet to see Alembic files with such long "object paths" in them.