Python scripts executed from commandline don't have __main__ module's dict as their globals on Windows #51444

New Issue

Kerim Borchaev · 2017-05-09T15:54:13+02:00

Kerim Borchaev commented

2017-05-09 15:54:13 +02:00

System Information
Windows 7 & W8100

Blender Version
Broken: 2.78c

Short description of error
When a python file is executed with --python it's namespace is different from __main__ module's namespace. This, for example, prevents unittest.main() from collecting tests(unittest.main collects tests by importing __main__ module). So any tests scripts(including Blender's python tests) relying on unittest.main behavior are now passing, having collected 0 Tests.

Exact steps for others to reproduce the error
Here's the test file, that shows that namespace is not __main__'s - test.py
running it (blender.exe --background --python test.py) gives this:

['__builtins__', '__doc__', '__file__', '__loader__', '__name__', '__package__', '__spec__', 'f', 'ns']

----------------------------------------------------------------------
Ran 0 tests in 0.000s

Cause and fix

On Windows globals() is copied for some reason before being passed to exec. Removing copy() fixes the problem:

---
 source/blender/python/intern/bpy_interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source/blender/python/intern/bpy_interface.c b/source/blender/python/intern/bpy_interface.c
index 55e477b0214..9cfa98b12b1 100644
--- a/source/blender/python/intern/bpy_interface.c
+++ b/source/blender/python/intern/bpy_interface.c
@@ -483,7 +483,7 @@ static bool python_script_exec(
             * So now we load the script file data to a buffer */
            {
                const char *pystring =
-                       "ns = globals().copy()\n"
+                       "ns = globals()\n"
                        "with open(__file__, 'rb') as f: exec(compile(f.read(), __file__, 'exec'), ns)";
 
                fclose(fp);
--

**System Information** Windows 7 & W8100 **Blender Version** Broken: 2.78c **Short description of error** When a python file is executed with --python it's namespace is different from `__main__` module's namespace. This, for example, prevents unittest.main() from collecting tests(unittest.main collects tests by importing `__main__` module). So any tests scripts(including Blender's python tests) relying on unittest.main behavior are now passing, having collected **0 Tests**. **Exact steps for others to reproduce the error** Here's the test file, that shows that namespace is not `__main__`'s - [test.py](https://archive.blender.org/developer/F593316/test.py) running it (`blender.exe --background --python test.py`) gives this: ``` ['__builtins__', '__doc__', '__file__', '__loader__', '__name__', '__package__', '__spec__', 'f', 'ns'] ---------------------------------------------------------------------- Ran 0 tests in 0.000s ``` **Cause and fix** On Windows globals() is copied for some reason before being passed to `exec`. Removing copy() fixes the problem: ``` --- source/blender/python/intern/bpy_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/blender/python/intern/bpy_interface.c b/source/blender/python/intern/bpy_interface.c index 55e477b0214..9cfa98b12b1 100644 --- a/source/blender/python/intern/bpy_interface.c +++ b/source/blender/python/intern/bpy_interface.c @@ -483,7 +483,7 @@ static bool python_script_exec( * So now we load the script file data to a buffer */ { const char *pystring = - "ns = globals().copy()\n" + "ns = globals()\n" "with open(__file__, 'rb') as f: exec(compile(f.read(), __file__, 'exec'), ns)"; fclose(fp); -- ```

Kerim Borchaev commented

2017-05-09 15:54:13 +02:00

Changed status to: 'Open'

Kerim Borchaev commented

2017-05-09 15:54:13 +02:00

Added subscriber: @KerimBorchaev

Sergey Sharybin commented

2017-05-15 12:38:14 +02:00

Added subscribers: @ideasman42, @Sergey

Campbell Barton was assigned by Sergey Sharybin

2017-05-15 12:38:14 +02:00

Sergey Sharybin commented

2017-05-15 12:38:14 +02:00

@ideasman42, afraid you are the only one to knwo why globals are being copied. Mind having a look here? :)

Campbell Barton commented

2017-05-25 10:53:19 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2017-05-25 10:53:19 +02:00

blender-admin commented

2017-05-25 10:56:00 +02:00

This issue was referenced by 24e3a930f1

This issue was referenced by 24e3a930f14a7bfc1ea16350b4e2c9585aa0f7c3

Campbell Barton commented

2017-05-25 10:56:33 +02:00

The problem was caused by unittest module inspecting sys.modules[__name__] - executing with globals().copy() for globals meant that classes defined in the code weren't added to sys.modules[__name__] for unittest to discover.

Committed this change with a minor kludge to avoid f variable being declared for every script being executed.

The problem was caused by `unittest` module inspecting `sys.modules[__name__]` - executing with `globals().copy()` for globals meant that classes defined in the code weren't added to `sys.modules[__name__]` for `unittest` to discover. Committed this change with a minor kludge to avoid `f` variable being declared for every script being executed.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Python scripts executed from commandline don't have __main__ module's dict as their globals on Windows #51444

Python scripts executed from commandline don't have main module's dict as their globals on Windows #51444