Page MenuHome

Tissue object tessalation addon: 2.79 Release
Closed, ResolvedPublic

Description

Hi this is the task for the tissue addon by Alessandro Zomparelli
https://blenderartists.org/forum/showthread.php?375378-tissue-by-Alessandro-Zomparelli
Initially I approached Alessandro Zomparelli in regards to adding his popular Tissue addon to 2.78 release but we were unable to solve issues.
I've been approached by Alessandro recently & tested the new addon & it's working much more suitably now.
code: https://github.com/alessandro-zomparelli/tissue
wiki: https://github.com/alessandro-zomparelli/tissue/wiki
Alessandro is well versed with Git usage & prepared to commit & maintain his addon in our repo.
Sorry for lateness, but this addon is worth breaking bcon3 rules (no new features) as it's a requested feature/addon from last release.
Just running a little late, will be done before test builds.
Thanks.

Details

Type
Patch

Event Timeline

Hi Brendon,
I'm actually not much expert of managing large projects on github. I mainly developed small scripts because I'm a designer more than a programmer.
I will start cleaning up the code a bit. You also mentioned to format differently the props. Can you please be more specific?

Cheers

Hi Alessandro,
I can help with Blender git, really it's no different to github where you currently host & update your files.
I looked at your addon & there's many pep8 issues & Blender Code Style problems.
As these are not familiar to you atm, It might be best if I commit as is, then make style changes for you without any function changes.
From there you can grab the script from our repo & send back any changes you need here, or if you can, commit yourself.
You can learn about Blender git setup here;
http://wiki.blender.org/index.php/Dev:Doc/Tools/Git
http://wiki.blender.org/index.php/Dev:Doc/New_Committer_Info#Commit_Logs
https://wiki.blender.org/index.php/Dev:Doc/New_Developer_Info
Thanks, let me know how you would like to proceed.
Brendon

Yes, of course, if it is not too time consuming for you, I would be great. Then for future developments I can continue on the version committed by you preserving the style.

Or I can at least try to fix the pep8 issues before. Let me work just on that.

Ok, I did it. Now it should be better for PEP8. Please check if I missed something.

Alessandro

hi, I'll check it out now, thanks.

@Alessandro Zomparelli (alessandrozompa) hi, great job on the clean up. code looks much nicer now.
one last thing, the ccby license at top of file? I see you have the gpl ,license file also.
can we just add the standard gpl license block to the top of files?

Yes, sure. You mean that one?

# ##### BEGIN GPL LICENSE BLOCK #####
#
#  This program is free software; you can redistribute it and/or
#  modify it under the terms of the GNU General Public License
#  as published by the Free Software Foundation; either version 2
#  of the License, or (at your option) any later version.
#
#  This program is distributed in the hope that it will be useful,
#  but WITHOUT ANY WARRANTY; without even the implied warranty of
#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
#  GNU General Public License for more details.
#
#  You should have received a copy of the GNU General Public License
#  along with this program; if not, write to the Free Software Foundation,
#  Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# ##### END GPL LICENSE BLOCK #####

My only concern is that according to that description I should add the license file... Is that true?

hi, that's it, just standard like that if you look at other addons

you can also add below ### Author Name, small notes.
Thanks

hi, made initial commit to release with some changes.
Fix gpl blocks & info.
Fix Duel mesh unreg
Change Tab name to Create tab (addons must default to existing tab names)

ToDo:
Add Panel rename code blocks
Close Panes by Default

Thanks, I hope everything is ok, we can keep this task open for followups.

closing as resolved, committed, testing well.