Page MenuHome

Black boxes on a denoising render when using a .exr image as a environmental texture
Closed, ResolvedPublic

Description

System Information
OS: Windows 10
GPU: AMD 390X 8gb, latest drivers
CPU+RAM: i7-5820k, 32gb Ram

Blender Version
2.78 12651ab

I'm using the benchmark file from Gooseberry and when default rendering with denoise on the black boxes appear at random when denoise kicks in. But it only appears when rendering with '.exr' file as environmental texture. If I convert the same file to '.hdr' file then the boxes are gone. No visual difference noted except for the black boxes.

Event Timeline

This EXR coming with this scene is known to contain NaNs. Saving it to HDR format "fixes" this. But even saving it as a new EXR (I tried 16bit half-float with ZIPS compression) got rid of the black boxes.
If you load the original environment EXR into Natron it displays a yellow warning that it replaced some NaNs with white.

Sergey Sharybin (sergey) lowered the priority of this task from 90 to Normal.

This is similar to bug i've fixed in rB581c819. Guess we need to move finiste check to image.cpp.

@Lukas Stockner (lukasstockner97) , @Brecht Van Lommel (brecht), any objections on that?

Sounds fine if it doesn't cause a significant slowdown.
Releasing a fixed version of the scene would probably also be a good idea, this is the third "bug" caused by that HDR.

I'm not sure if we should release a fixed scene, testing if we handle weird HDR images correct is also valuable since users will likely encounter the as well.

@Brecht Van Lommel (brecht) and @Sergey Sharybin (sergey) wouldn't it be better and possible to take last valid texel value instead of 0,0,0 for replacing NaNs while cycling through all the texels of the texture?