IntegerSocket+Material view crashes blender. #51687

New Issue

Ray molenkamp · 2017-06-01T01:11:28+02:00

Ray molenkamp commented

2017-06-01 01:11:28 +02:00

System Information
Win7 (but it's irrelevant, all builds should do this)

Blender Version
Broken: latest master
Worked: (optional)

Short description of error
When you add an integer socket to a cycles node-group, cycles is happy with it and it functions properly , however when you switch to the material view, blender instantly disappears with an access violation.

Exact steps for others to reproduce the error
Open the attached blend, switch to material view
MaterialViewCrash.blend

I'm pretty sure this will end up in the 'not supported, don't do that' pile, but still it would be nice if we at-least not punish the user with an instant crash when this happens

**System Information** Win7 (but it's irrelevant, all builds should do this) **Blender Version** Broken: latest master Worked: (optional) **Short description of error** When you add an integer socket to a cycles node-group, cycles is happy with it and it functions properly , however when you switch to the material view, blender instantly disappears with an access violation. **Exact steps for others to reproduce the error** Open the attached blend, switch to material view [MaterialViewCrash.blend](https://archive.blender.org/developer/F614718/MaterialViewCrash.blend) I'm pretty sure this will end up in the 'not supported, don't do that' pile, but still it would be nice if we at-least not punish the user with an instant crash when this happens

Ray molenkamp commented

2017-06-01 01:11:28 +02:00

Changed status to: 'Open'

Ray molenkamp commented

2017-06-01 01:11:28 +02:00

Added subscriber: @LazyDodo

Miguel Porces commented

2017-06-01 03:11:37 +02:00

Added subscriber: @Secrop

Bastien Montagne commented

2017-06-01 09:48:16 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2017-06-01 09:48:17 +02:00

Can confirm the crash, for some reason node_get_stack() returns NULL bNodeStack pointer for those integer sockets... :|

Can confirm the crash, for some reason `node_get_stack()` returns NULL bNodeStack pointer for those integer sockets... :|

Bastien Montagne commented

2017-06-01 09:58:33 +02:00

Added subscriber: @Sergey

Bastien Montagne commented

2017-06-01 09:58:33 +02:00

OK, this boils down to node_exec_socket_use_stack() in node_exec.c not knowing about SOCK_INT socket type…

@Sergey not sure what's best here? support integer sockets (which could easily be converted to float values)? Forbid creation of such sockets in shader tree (if possible)? Or just make gpu_stack_from_data_list() NULL-checking the bNodeStack pointers? Later solution seams most straight forward to me…

OK, this boils down to `node_exec_socket_use_stack()` in node_exec.c not knowing about `SOCK_INT` socket type… @Sergey not sure what's best here? support integer sockets (which could easily be converted to float values)? Forbid creation of such sockets in shader tree (if possible)? Or just make `gpu_stack_from_data_list()` NULL-checking the `bNodeStack` pointers? Later solution seams most straight forward to me…

Miguel Porces commented

2017-06-01 11:23:13 +02:00

simply adding SOCK_INT to the node_exec_socket_use_stack() fixes this..
...
return ELEM(sock->type, SOCK_INT, SOCK_FLOAT, SOCK_VECTOR, SOCK_RGBA, SOCK_SHADER);
...

simply adding SOCK_INT to the node_exec_socket_use_stack() fixes this.. ... return ELEM(sock->type, SOCK_INT, SOCK_FLOAT, SOCK_VECTOR, SOCK_RGBA, SOCK_SHADER); ...

Bastien Montagne self-assigned this 2017-06-01 12:18:39 +02:00

Bastien Montagne commented

2017-06-01 12:18:39 +02:00

Adding SOCK_INT here won't be enough, might work in that specific case but will break in others, unless you also define conversions rules etc.

For now will commit some code to make GPU evaluation of nodetree resilient to unknown/unsupported socket types. Would consider adding support of Integer sockets here as a nice and (probably) easy TODO.

Adding SOCK_INT here won't be enough, might work in that specific case but will break in others, unless you also define conversions rules etc. For now will commit some code to make GPU evaluation of nodetree resilient to unknown/unsupported socket types. Would consider adding support of Integer sockets here as a nice and (probably) easy TODO.

blender-admin commented

2017-06-01 12:18:57 +02:00

This issue was referenced by 528ae8885e

This issue was referenced by 528ae8885ebb8a2eebbc6726af3950ca4db38665

Bastien Montagne commented

2017-06-01 12:24:34 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2017-06-01 12:24:34 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

IntegerSocket+Material view crashes blender. #51687