PxrProjectionLayer node added instead of the Image Texture node in Cycles #51859

Closed
opened 2017-06-21 13:17:02 +02:00 by Riccardo Giovanetti · 8 comments

System Information
ASUS G752VS, Windows 10 Pro (1511) 64bit, 32GB RAM, Nvidia GTX1070 8GB VRAM

Blender Version
Broken: 2.78c 64bit portable, 2.78.5 (Hash: 9e08019) 64bit portable
Worked: unknown

Short description of error
Adding an Image Texture node in the (by example) Diffuse BSDF shader from the button on the right of the Color field in the Material Properties panel adds instead the PxrProjectionLayer node.

Exact steps for others to reproduce the error

In Blender 2.78c 64bit (portable), as well as with the latest development build on Windows 10 Pro 64bit with the RMfB add-on activated (I have the latest version of both the add-on, which I sync with the Pixar's GitHub repository, as well as RMan 21.4) but not selected to be the active render engine, which is Cycles, if I add a new material like the default Diffuse BSDF node, and then I click on the Color input "dot" to open a list of nodes to choose from, selecting the Image Texture node Blender adds the PxrProjectionLayer node instead of the Image Texture node.

Here follow some screenshots:

RMfB_issue_1.jpg
RMfB_issue_2.jpg
RMfB_issue_3.jpg

Furthermore, I noticed that even if Cycles is the selected active render engine, all the nodes from PRMan are listed in the Add node menu, which in theory shouldn't.

PRMan_nodes_in_Cycles.jpg

Here is the link to the discussion on Blender Artists and Brian's comments, just in case.

Thank you for your attention and time.

**System Information** ASUS G752VS, Windows 10 Pro (1511) 64bit, 32GB RAM, Nvidia GTX1070 8GB VRAM **Blender Version** Broken: 2.78c 64bit portable, 2.78.5 (Hash: 9e08019) 64bit portable Worked: unknown **Short description of error** Adding an Image Texture node in the (by example) Diffuse BSDF shader from the button on the right of the Color field in the Material Properties panel adds instead the PxrProjectionLayer node. **Exact steps for others to reproduce the error** In Blender 2.78c 64bit (portable), as well as with the latest development build on Windows 10 Pro 64bit with the RMfB add-on activated (I have the latest version of both the add-on, which I sync with the Pixar's GitHub repository, as well as RMan 21.4) but not selected to be the active render engine, which is Cycles, if I add a new material like the default Diffuse BSDF node, and then I click on the Color input "dot" to open a list of nodes to choose from, selecting the Image Texture node Blender adds the PxrProjectionLayer node instead of the Image Texture node. Here follow some screenshots: ![RMfB_issue_1.jpg](https://archive.blender.org/developer/F637665/RMfB_issue_1.jpg) ![RMfB_issue_2.jpg](https://archive.blender.org/developer/F637667/RMfB_issue_2.jpg) ![RMfB_issue_3.jpg](https://archive.blender.org/developer/F637669/RMfB_issue_3.jpg) Furthermore, I noticed that even if Cycles is the selected active render engine, all the nodes from PRMan are listed in the Add node menu, which in theory shouldn't. ![PRMan_nodes_in_Cycles.jpg](https://archive.blender.org/developer/F637671/PRMan_nodes_in_Cycles.jpg) Here is the link to the [discussion ](https://blenderartists.org/forum/showthread.php?375734-Pixar-RenderMan-for-Blender!&p=3201426&viewfull=1#post3201426) on Blender Artists and Brian's comments, just in case. Thank you for your attention and time.

Changed status to: 'Open'

Changed status to: 'Open'

Added subscriber: @Harvester

Added subscriber: @Harvester

Added subscriber: @mont29

Added subscriber: @mont29

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Bastien Montagne self-assigned this 2017-06-21 14:39:55 +02:00

This totally sounds like an RMfB add-on bug to me? Probably does not correctly check that valid engine is active in its poll functions…

Issue is imho in poll function of root (base) class of nodes.

RMfB code:

def poll(cls, ntree):
if hasattr(ntree, 'bl_idname'):
return ntree.bl_idname == 'ShaderNodeTree'
else:
return True

LuxRender code:

def poll(cls, tree):
return tree.bl_idname in ['luxrender_material_nodes', 'luxrender_volume_nodes_a']

RMfB seems to be messing with Cycles' shading tree, when it should create its own!

This totally sounds like an RMfB add-on bug to me? Probably does not correctly check that valid engine is active in its poll functions… Issue is imho in `poll` function of root (base) class of nodes. RMfB code: ```lang=python ``` def poll(cls, ntree): if hasattr(ntree, 'bl_idname'): return ntree.bl_idname == 'ShaderNodeTree' else: return True ``` ``` LuxRender code: ```lang=python ``` def poll(cls, tree): return tree.bl_idname in ['luxrender_material_nodes', 'luxrender_volume_nodes_a'] ``` ``` RMfB seems to be messing with Cycles' shading tree, when it should create its own!

Thank you Bastien for the clue about where the issue might be coming from. Regards.

Thank you Bastien for the clue about where the issue might be coming from. Regards.

Added subscriber: @BrianSavery

Added subscriber: @BrianSavery

Why should it be creating it own? We use the native nodetree for various reasons:

1: Lack of node grouping in custom nodegroups.
2: Before 2.79 we had to link to the custom nodegroup via name (IDPointerProperties fixes this in 2.79). This causes multiple problems for example with linked files pulling in the correct nodegroup.
3: Because the cycles nodes are all OSL we can actually use the cycles nodes (just have to use our Bxdfs).

Either way, I fail to see how this is a RfB issue. If I created some custom nodes to work in the cycles nodetree you'd see the same issue. Is that forbidden as well? Also where does it say that addons MUST NOT use the built in nodetree. Please explain your "invalid" @mont29

Why should it be creating it own? We use the native nodetree for various reasons: 1: Lack of node grouping in custom nodegroups. 2: Before 2.79 we had to link to the custom nodegroup via name (IDPointerProperties fixes this in 2.79). This causes multiple problems for example with linked files pulling in the correct nodegroup. 3: Because the cycles nodes are all OSL we can actually use the cycles nodes (just have to use our Bxdfs). Either way, I fail to see how this is a RfB issue. If I created some custom nodes to work in the cycles nodetree you'd see the same issue. Is that forbidden as well? Also where does it say that addons MUST NOT use the built in nodetree. Please explain your "invalid" @mont29
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#51859
No description provided.