Rename file #52040

New Issue

Anders Lindén · 2017-07-12T23:58:15+02:00

Anders Lindén commented

2017-07-12 23:58:15 +02:00

Rename file from space_view3d_toolbar.py to space_view3d_toolshelf.py.0001-Rename-file-from-space_view3d_toolbar.py-to-space_vi.patch

As I understand it, this panel was called toolbar before and toolshelf now, but the naming did not change.

Rename file from space_view3d_toolbar.py to space_view3d_toolshelf.py.[0001-Rename-file-from-space_view3d_toolbar.py-to-space_vi.patch](https://archive.blender.org/developer/F661482/0001-Rename-file-from-space_view3d_toolbar.py-to-space_vi.patch) As I understand it, this panel was called toolbar before and toolshelf now, but the naming did not change.

Anders Lindén commented

2017-07-12 23:58:15 +02:00

Changed status to: 'Resolved'

Anders Lindén closed this issue

2017-07-12 23:58:15 +02:00

Anders Lindén commented

2017-07-12 23:58:15 +02:00

Added subscriber: @AndersBillLinden

Anders Lindén commented

2017-07-13 09:40:27 +02:00

Changed status from 'Resolved' to: 'Open'

Anders Lindén reopened this issue

2017-07-13 09:40:27 +02:00

Vuk Gardašević commented

2017-07-13 20:11:36 +02:00

Added subscriber: @VukGardasevic

Vuk Gardašević commented

2017-07-13 20:11:36 +02:00

Please can you make a differential for this patch?
Add a small description explaining the purpose of the proposed changes. After possible approval / code review it can be included in future versions (2.80 series) since we are really close to 2.79.

https://developer.blender.org/differential/diff/create/

Please can you make a differential for this patch? Add a small description explaining the purpose of the proposed changes. After possible approval / code review it can be included in future versions (2.80 series) since we are really close to 2.79. https://developer.blender.org/differential/diff/create/

Anders Lindén commented

2017-07-14 09:24:09 +02:00

I already provided a unified diff. Please tell me what more to provide!

Vuk Gardašević commented

2017-07-15 09:35:24 +02:00

For submitting patches to blender please consult this page:
https://wiki.blender.org/index.php/Dev:Doc/Process/Contributing_Code

The differential page is pretty straightforward to create - you can copy the diff in the field > create diff and enter the information in the next page.
This is easier for the developers to review and comment on.

For submitting patches to blender please consult this page: https://wiki.blender.org/index.php/Dev:Doc/Process/Contributing_Code The differential page is pretty straightforward to create - you can copy the diff in the field > create diff and enter the information in the next page. This is easier for the developers to review and comment on.

Anders Lindén commented

2017-07-15 16:31:25 +02:00

Differential at https://developer.blender.org/differential/diff/9010/ please let me know if I should add it somewhere to this task.

Vuk Gardašević commented

2017-07-15 22:15:33 +02:00

Half way there:) Press the continue button and fill up the title and the summary fields and create the differential.
You don't need to assign any developer as reviewer if you are not sure who to add.

The newly created entry will be in the specific section designated for code review of patches and contributions and will get a code/link starting with D followed by 4 digits.

This is an example how an Differential looks like in Phabricator.
https://developer.blender.org/D2561

I know that dealing with a foreign workflow can be a bit confusing sometimes, but the more difficult part is making the diff and patch itself . Anyway, thanks for contributing:)

Half way there:) Press the continue button and fill up the title and the summary fields and create the differential. You don't need to assign any developer as reviewer if you are not sure who to add. The newly created entry will be in the specific section designated for code review of patches and contributions and will get a code/link starting with D followed by 4 digits. This is an example how an Differential looks like in Phabricator. https://developer.blender.org/D2561 I know that dealing with a foreign workflow can be a bit confusing sometimes, but the more difficult part is making the diff and patch itself . Anyway, thanks for contributing:)

Aaron Carlisle commented

2017-07-15 22:29:31 +02:00

Added subscriber: @Blendify

Aaron Carlisle commented

2017-07-15 22:29:31 +02:00

Changed status from 'Open' to: 'Archived'

Aaron Carlisle closed this issue

2017-07-15 22:29:31 +02:00

Aaron Carlisle self-assigned this 2017-07-15 22:29:31 +02:00

Aaron Carlisle commented

2017-07-15 22:29:31 +02:00

Thanks for the suggestion but the naming is still being discussed see blender/blender#43623 so I would rather not make noisy commits until this is finalized on.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Rename file #52040