Bevel doesn't correctly work with default empty Vgroup #52176

New Issue

Serge Lyatin · 2017-07-24T17:48:43+02:00

Serge Lyatin commented

2017-07-24 17:48:43 +02:00

System Information
Win7 64bit

Blender Version
Broken: 2.78c

Short description of error
Bevel doesn't correctly work with default empty Vgroup, until manually click Assign in edit mode

Exact steps for others to reproduce the error
Load default scene
Click "+" button to create Vgroup
Add Bevel modifier to the cube and switch to Vgroup method
Choose Vgroup you have created-> Bevel is working, but shouldn't

**System Information** Win7 64bit **Blender Version** Broken: 2.78c **Short description of error** Bevel doesn't correctly work with default empty Vgroup, until manually click *Assign* in edit mode **Exact steps for others to reproduce the error** Load default scene Click "+" button to create Vgroup Add Bevel modifier to the cube and switch to Vgroup method Choose Vgroup you have created-> Bevel is working, but shouldn't

Serge Lyatin commented

2017-07-24 17:48:43 +02:00

Changed status to: 'Open'

Serge Lyatin commented

2017-07-24 17:48:43 +02:00

Added subscriber: @SergeL

Serge Lyatin changed title from ~~Bevel doesn't correctly work with default empty group~~ to Bevel doesn't correctly work with default empty Vgroup

2017-07-24 18:45:41 +02:00

Bastien Montagne commented

2017-07-26 16:21:05 +02:00

Added subscriber: @mont29

Bastien Montagne self-assigned this 2017-07-26 16:21:05 +02:00

Bastien Montagne commented

2017-07-26 16:21:05 +02:00

This is actually a bug in our defvert_array_find_weight_safe(), which was assuming that having a valid vgroup index but NULL vgroup data pointer was same as not having a valid vgroup index, and was returning '1.0' in both cases.

This is wrong, invalid vgroup index means the vgroup selected is invalid, does not exists, in that case it is OK to return 1.0 (i.e. maximum weight, as if no vgroup was selected).

But in case of valid vgroup and NULL vgroup data pointer, only means that vgroup is valid, and just totally empty, so we shall return '0.0' value then!

This is actually a bug in our `defvert_array_find_weight_safe()`, which was assuming that having a valid vgroup index but NULL vgroup data pointer was same as not having a valid vgroup index, and was returning '1.0' in both cases. This is wrong, invalid vgroup index means the vgroup selected is invalid, does not exists, in that case it is OK to return 1.0 (i.e. maximum weight, as if no vgroup was selected). But in case of valid vgroup and NULL vgroup data pointer, only means that vgroup **is** valid, and just totally empty, so we shall return '0.0' value then!

Bastien Montagne commented

2017-07-26 16:21:38 +02:00

Note that this affect other modifiers too (shrinkwrap and simple deform at least).

blender-admin commented

2017-07-26 16:23:24 +02:00

This issue was referenced by 66e28a2827

This issue was referenced by 66e28a2827ab589756882983e07808742c198cb2

Bastien Montagne commented

2017-07-26 16:26:05 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2017-07-26 16:26:05 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Bevel doesn't correctly work with default empty Vgroup #52176