Export Paper Model: Wrong get and set parameters for the output_margin property #52261

New Issue

Vuk Gardašević · 2017-08-04T14:48:22+02:00

Vuk Gardašević commented

2017-08-04 14:48:22 +02:00

System Information
Windows 7

Blender Version
Broken: 2.79 RC1 and previous builds

Short description of error
The functions for get and set for the property output_margin have a wrong structure / calls which leads to errors

Exact steps for others to reproduce the error
Enable Export Paper Model > with an object selected go to Export Menu> Select the Paper Model from it > the errors will show up in the cmd / terminal.

Traceback (most recent call last):
  File "2.78\scripts\addons\io_export_paper_model.py", line 2051, in <lambda>
    return lambda self: self[name] / bpy.context.scene.unit_settings.scale_length
KeyError: 'bpy_struct[key]: key "output_margin" not found'
}

If the problem is fixed by taking the lambda from a separate function block into the property itself, it will end up in the infinite recursion.
The structure of input parameters and return values doesn't match with the current API for get and set related to Properties.

I'm not sure what is the intention/scope of the margin so I cannot fix the issue as the margin in the current code takes it's own values and updates them while in other cases in other add-ons other properties/ functions are used.

**System Information** Windows 7 **Blender Version** Broken: 2.79 RC1 and previous builds **Short description of error** The functions for get and set for the property `output_margin` have a wrong structure / calls which leads to errors **Exact steps for others to reproduce the error** Enable Export Paper Model > with an object selected go to Export Menu> Select the Paper Model from it > the errors will show up in the cmd / terminal. ``` Traceback (most recent call last): File "2.78\scripts\addons\io_export_paper_model.py", line 2051, in <lambda> return lambda self: self[name] / bpy.context.scene.unit_settings.scale_length KeyError: 'bpy_struct[key]: key "output_margin" not found' } ``` If the problem is fixed by taking the lambda from a separate function block into the property itself, it will end up in the infinite recursion. The structure of input parameters and return values doesn't match with the current API for get and set related to Properties. I'm not sure what is the intention/scope of the margin so I cannot fix the issue as the margin in the current code takes it's own values and updates them while in other cases in other add-ons other properties/ functions are used.

Vuk Gardašević commented

2017-08-04 14:48:22 +02:00

Changed status to: 'Open'

Vuk Gardašević commented

2017-08-04 14:48:22 +02:00

Added subscriber: @VukGardasevic

Vuk Gardašević commented

2017-08-04 14:50:55 +02:00

Added subscriber: @emu-3

Adam Dominec self-assigned this 2017-08-06 10:21:19 +02:00

Adam Dominec commented

2017-08-06 10:21:19 +02:00

Changed status from 'Open' to: 'Resolved'

Adam Dominec closed this issue

2017-08-06 10:21:19 +02:00

Adam Dominec commented

2017-08-06 10:21:19 +02:00

The problem was that blender-addons repository contains a completely wrong version of the script. Apparently I forgot to update it for a long time. Sorry, and thank you for the report.

Fixed in c960569: updated to github version.

The problem was that `blender-addons` repository contains a completely wrong version of the script. Apparently I forgot to update it for a long time. Sorry, and thank you for the report. Fixed in c960569: updated to github version.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Export Paper Model: Wrong get and set parameters for the output_margin property #52261