32 bit Float normal map are baked in sRGB instead of Linear #52334

New Issue

Danyl Bekhoucha · 2017-08-10T12:51:54+02:00

Danyl Bekhoucha commented

2017-08-10 12:51:54 +02:00

When baking an image in 32 bit Float in Cycles or Blender render instead of baking it automatically in Linear like the 8 bit image, Blender bakes it in sRGB so it's unusable by game engines. That's not the only problem, compositing it by fixing the gamma to convert it into Linear generates some artefacts worse than directly baking a 8 bit image.

When baking an image in 32 bit Float in Cycles or Blender render instead of baking it automatically in Linear like the 8 bit image, Blender bakes it in sRGB so it's unusable by game engines. That's not the only problem, compositing it by fixing the gamma to convert it into Linear generates some artefacts worse than directly baking a 8 bit image. ![linear normal.png](https://archive.blender.org/developer/F703525/linear_normal.png)

Danyl Bekhoucha commented

2017-08-10 12:51:54 +02:00

Changed status to: 'Open'

Danyl Bekhoucha commented

2017-08-10 12:51:54 +02:00

Added subscriber: @DanylBekhoucha

blender-admin commented

2017-08-10 14:11:18 +02:00

This issue was referenced by e786ea6419

This issue was referenced by e786ea6419ce92d1e02eb80da990db7aca20b0ab

Sergey Sharybin commented

2017-08-10 14:34:48 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2017-08-10 14:34:48 +02:00

Changed status from 'Open' to: 'Archived'

Sergey Sharybin closed this issue

2017-08-10 14:34:48 +02:00

Sergey Sharybin self-assigned this 2017-08-10 14:34:48 +02:00

Sergey Sharybin commented

2017-08-10 14:34:48 +02:00

Bake sets raw pixel values. What's most likely happening here is that your 32bit image color space is set to Linear, which would apply Linear to sRGB conversion on display. To properly see your normal map you should set color space to Non-Color.

Brecht Van Lommel commented

2017-08-10 14:45:42 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2017-08-10 14:45:42 +02:00

@Sergey, saving a generated float non-color data image to PNG seems to change the color space to sRGB though.

I think we can fix that like this:
P520: (An Untitled Masterwork)

diff --git a/source/blender/imbuf/intern/colormanagement.c b/source/blender/imbuf/intern/colormanagement.c
index 03f71b5..1f3be8d 100644
--- a/source/blender/imbuf/intern/colormanagement.c
+++ b/source/blender/imbuf/intern/colormanagement.c
@@ -2565,6 +2565,14 @@ const char *IMB_colormanagement_colorspace_get_indexed_name(int index)
 
 void IMB_colormanagment_colorspace_from_ibuf_ftype(ColorManagedColorspaceSettings *colorspace_settings, ImBuf *ibuf)
 {
+	/* Don't modify non-color data space, it does not change with file type. */
+	ColorSpace *colorspace = colormanage_colorspace_get_named(colorspace_settings->name);
+
+	if (colorspace && colorspace->is_data) {
+		return;
+	}
+
+	/* Get color space from file type. */
 	const ImFileType *type;
 
 	for (type = IMB_FILE_TYPES; type < IMB_FILE_TYPES_LAST; type++) {
diff --git a/source/blender/imbuf/intern/jp2.c b/source/blender/imbuf/intern/jp2.c
index 390f250..388c273 100644
--- a/source/blender/imbuf/intern/jp2.c
+++ b/source/blender/imbuf/intern/jp2.c
@@ -588,7 +588,7 @@ static opj_image_t *ibuftoimage(ImBuf *ibuf, opj_cparameters_t *parameters)
 	img_fol_t img_fol; /* only needed for cinema presets */
 	memset(&img_fol, 0, sizeof(img_fol_t));
 	
-	if (ibuf->float_colorspace) {
+	if (ibuf->float_colorspace || (ibuf->colormanage_flag & IMB_COLORMANAGE_IS_DATA)) {
 		/* float buffer was managed already, no need in color space conversion */
 		chanel_colormanage_cb = channel_colormanage_noop;
 	}
diff --git a/source/blender/imbuf/intern/png.c b/source/blender/imbuf/intern/png.c
index 503e63a..dded0f7 100644
--- a/source/blender/imbuf/intern/png.c
+++ b/source/blender/imbuf/intern/png.c
@@ -152,7 +152,7 @@ int imb_savepng(struct ImBuf *ibuf, const char *name, int flags)
 	compression = (int)(((float)(ibuf->foptions.quality) / 11.1111f));
 	compression = compression < 0 ? 0 : (compression > 9 ? 9 : compression);
 
-	if (ibuf->float_colorspace) {
+	if (ibuf->float_colorspace || (ibuf->colormanage_flag & IMB_COLORMANAGE_IS_DATA)) {
 		/* float buffer was managed already, no need in color space conversion */
 		chanel_colormanage_cb = channel_colormanage_noop;
 	}
diff --git a/source/blender/imbuf/intern/tiff.c b/source/blender/imbuf/intern/tiff.c
index 4368a42..8e5cf80 100644
--- a/source/blender/imbuf/intern/tiff.c
+++ b/source/blender/imbuf/intern/tiff.c
@@ -822,7 +822,7 @@ int imb_savetiff(ImBuf *ibuf, const char *name, int flags)
 				/* convert from float source */
 				float rgb[4];
 				
-				if (ibuf->float_colorspace) {
+				if (ibuf->float_colorspace || (ibuf->colormanage_flag & IMB_COLORMANAGE_IS_DATA)) {
 					/* float buffer was managed already, no need in color space conversion */
 					copy_v3_v3(rgb, &fromf[from_i]);
 				}

@Sergey, saving a generated float non-color data image to PNG seems to change the color space to sRGB though. I think we can fix that like this: [P520: (An Untitled Masterwork)](https://archive.blender.org/developer/P520.txt) ```diff diff --git a/source/blender/imbuf/intern/colormanagement.c b/source/blender/imbuf/intern/colormanagement.c index 03f71b5..1f3be8d 100644 --- a/source/blender/imbuf/intern/colormanagement.c +++ b/source/blender/imbuf/intern/colormanagement.c @@ -2565,6 +2565,14 @@ const char *IMB_colormanagement_colorspace_get_indexed_name(int index) void IMB_colormanagment_colorspace_from_ibuf_ftype(ColorManagedColorspaceSettings *colorspace_settings, ImBuf *ibuf) { + /* Don't modify non-color data space, it does not change with file type. */ + ColorSpace *colorspace = colormanage_colorspace_get_named(colorspace_settings->name); + + if (colorspace && colorspace->is_data) { + return; + } + + /* Get color space from file type. */ const ImFileType *type; for (type = IMB_FILE_TYPES; type < IMB_FILE_TYPES_LAST; type++) { diff --git a/source/blender/imbuf/intern/jp2.c b/source/blender/imbuf/intern/jp2.c index 390f250..388c273 100644 --- a/source/blender/imbuf/intern/jp2.c +++ b/source/blender/imbuf/intern/jp2.c @@ -588,7 +588,7 @@ static opj_image_t *ibuftoimage(ImBuf *ibuf, opj_cparameters_t *parameters) img_fol_t img_fol; /* only needed for cinema presets */ memset(&img_fol, 0, sizeof(img_fol_t)); - if (ibuf->float_colorspace) { + if (ibuf->float_colorspace || (ibuf->colormanage_flag & IMB_COLORMANAGE_IS_DATA)) { /* float buffer was managed already, no need in color space conversion */ chanel_colormanage_cb = channel_colormanage_noop; } diff --git a/source/blender/imbuf/intern/png.c b/source/blender/imbuf/intern/png.c index 503e63a..dded0f7 100644 --- a/source/blender/imbuf/intern/png.c +++ b/source/blender/imbuf/intern/png.c @@ -152,7 +152,7 @@ int imb_savepng(struct ImBuf *ibuf, const char *name, int flags) compression = (int)(((float)(ibuf->foptions.quality) / 11.1111f)); compression = compression < 0 ? 0 : (compression > 9 ? 9 : compression); - if (ibuf->float_colorspace) { + if (ibuf->float_colorspace || (ibuf->colormanage_flag & IMB_COLORMANAGE_IS_DATA)) { /* float buffer was managed already, no need in color space conversion */ chanel_colormanage_cb = channel_colormanage_noop; } diff --git a/source/blender/imbuf/intern/tiff.c b/source/blender/imbuf/intern/tiff.c index 4368a42..8e5cf80 100644 --- a/source/blender/imbuf/intern/tiff.c +++ b/source/blender/imbuf/intern/tiff.c @@ -822,7 +822,7 @@ int imb_savetiff(ImBuf *ibuf, const char *name, int flags) /* convert from float source */ float rgb[4]; - if (ibuf->float_colorspace) { + if (ibuf->float_colorspace || (ibuf->colormanage_flag & IMB_COLORMANAGE_IS_DATA)) { /* float buffer was managed already, no need in color space conversion */ copy_v3_v3(rgb, &fromf[from_i]); } ```

Sergey Sharybin commented

2017-08-10 15:11:39 +02:00

@brecht, this is reasonable to not change color space, just technically not a bug. If you tested the code, please commit it.

Brecht Van Lommel commented

2017-08-10 15:55:27 +02:00

Changed status from 'Archived' to: 'Resolved'

Brecht Van Lommel commented

2017-08-10 15:57:58 +02:00

Maybe not technically a bug, but without it you can't save 32 bit float baked normals maps as an 8 bit image as far as I can tell.

Danyl Bekhoucha commented

2017-08-10 16:44:23 +02:00

Thank you for the clarification. And yes if I set the image to Raw i see it displayed linearly but when i save it it's converted in sRGB i don't know why. Also if I bake in Raw and switch the color space and go back to raw it's displayed like the sRGB version.

Brecht Van Lommel commented

2017-08-10 17:08:02 +02:00

It should be fixed in tomorrow's build on builder.blender.org, if you use Non-Color as the color space. Don't use Raw, that's something else.

YuanQing(Brent) Liu commented

2017-09-03 05:40:42 +02:00

Added subscriber: @BrentLiu

YuanQing(Brent) Liu commented

2017-09-03 05:40:42 +02:00

Why am I experiencing this in Blender 2.78? Is this truly resolved?

EDIT: Nevermind, I misread the time stamp thinking this was resolved in 2010. I should update to 2.79 or the version of this commit.

Needed this to work correctly for some multi-layer normal map blending workflow for material authoring.

Why am I experiencing this in Blender 2.78? Is this truly resolved? EDIT: Nevermind, I misread the time stamp thinking this was resolved in 2010. I should update to 2.79 or the version of this commit. Needed this to work correctly for some multi-layer normal map blending workflow for material authoring.

Ingmar Franz commented

2019-04-29 20:54:52 +02:00

Added subscriber: @IngmarFranz

Ingmar Franz commented

2019-04-29 20:54:53 +02:00

This comment was removed by @IngmarFranz

*This comment was removed by @IngmarFranz*

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

32 bit Float normal map are baked in sRGB instead of Linear #52334