Proposal: Remove Solaris platform support #52806

New Issue

Campbell Barton · 2017-09-18T03:29:54+02:00

Campbell Barton commented

2017-09-18 03:29:54 +02:00

Solaris has been discontinued and while an open version exists, I don't think this has been working since 2012 (last commit I could find).

Removing involves:

Removing checks for __SUNPRO, __sun, __sun__, sun, _XPG4 and possibly __sparc (depending on the check).
Removing references to SunPro in cmake.

Solaris has been discontinued and while an open version exists, I don't think this has been working since 2012 *(last commit I could find)*. Removing involves: - Removing checks for `__SUNPRO`, `__sun`, `__sun__`, `sun`, `_XPG4` and possibly `__sparc` (depending on the check). - Removing references to `SunPro` in cmake.

Campbell Barton self-assigned this 2017-09-18 03:29:54 +02:00

Campbell Barton commented

2017-09-18 03:29:54 +02:00

Changed status to: 'Open'

Campbell Barton commented

2017-09-18 03:29:54 +02:00

Added subscribers: @ideasman42, @mont29, @Sergey

Sergey Sharybin commented

2017-09-18 07:49:27 +02:00

Afaik, Solaris is pretty much discontinued by Oracle now, almost everyone from that team was fired. Think we can indeed remove checks for it in source/ and intern/. But be careful about extern/ because some of the libraries (like Glog) might use special ifdefs coming from upstream.

Afaik, Solaris is pretty much discontinued by Oracle now, almost everyone from that team was fired. Think we can indeed remove checks for it in `source/` and `intern/`. But be careful about `extern/` because some of the libraries (like Glog) might use special ifdefs coming from upstream.

Campbell Barton commented

2017-09-18 08:11:25 +02:00

Yep, extern/intern we only touch if they're maintained by blender devs.

Uploaded patch which covers all cases in source and intern, although I noticed 2 _AIX checks which were grouped with the solaris ones. I highly doubt modern Blender builds with AIX, we could remove them too, not sure its worth another task though.

Yep, extern/intern we only touch if they're maintained by blender devs. Uploaded patch which covers all cases in `source` and `intern`, although I noticed 2 `_AIX` checks which were grouped with the solaris ones. I highly doubt modern Blender builds with AIX, we could remove them too, not sure its worth another task though.

Campbell Barton commented

2017-09-29 11:07:12 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2017-09-29 11:07:12 +02:00

Campbell Barton commented

2017-09-29 11:07:12 +02:00

Committed 5a1954a5cb

Committed 5a1954a5cb

Sign in to join this conversation.