Undo doesn't undo the latest Automirror function that was selected! #53084

Closed
opened 2017-10-16 09:58:16 +02:00 by ashley · 10 comments

System Information

Windows 7

Nvidia Geforce GT620

Blender Version
2.79, Steam, latest

Short description of error

When hitting Undo after, say, the Y axis mirror, hitting Ctrl+Z does not undo the operation.

Exact steps for others to reproduce the error
Based on a (as simple as possible) attached .blend file with minimum amount of steps

Simply go to Tools -> Automirror -> Options -> Y -> hit button -> Ctrl+Z
sprytile.blend

**System Information** Windows 7 Nvidia Geforce GT620 **Blender Version** 2.79, Steam, latest **Short description of error** When hitting Undo after, say, the Y axis mirror, hitting Ctrl+Z does not undo the operation. **Exact steps for others to reproduce the error** Based on a (as simple as possible) attached .blend file with minimum amount of steps Simply go to Tools -> Automirror -> Options -> Y -> hit button -> Ctrl+Z [sprytile.blend](https://archive.blender.org/developer/F1041058/sprytile.blend)
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

Added subscriber: @watercolor

Added subscriber: @watercolor
Lapineige was assigned by ashley 2017-10-16 10:01:19 +02:00

Added subscriber: @Sergey

Added subscriber: @Sergey

Sounds like an addon issue to me. Assuming @Lapineige is the author of that addon.

However, might be just a limitation of the undo system, when you mix settings stored in interface and global undo.

Sounds like an addon issue to me. Assuming @Lapineige is the author of that addon. However, might be just a limitation of the undo system, when you mix settings stored in interface and global undo.

I'm not sure of the origin of this issue: If I add 'UNDO' in the bl_options, the Auto Mirror operation can be seen in the Undo History, but undoing it doesn't remove the mirror modifier.
I first thought it was due to global undo, but disabling it doesn't seem to change the final result.
(also using the Last Operator panel doesn't undo the operation, but does it multiple times instead)

@watercolor: this add-on was first intended to be used from object mode (which is the most common case), then I allowed edit mode but probably never tested that case of undoing inside edit mode. That's why I didn't see this problem.
Until this is fixed, if you have global undo activated, swap to object mode and then use AutoMirror. Then you should be able to undo it (from object mode) without undoing previous changes you made.

I'm not sure of the origin of this issue: If I add `'UNDO'` in the `bl_options`, the Auto Mirror operation can be seen in the Undo History, but undoing it doesn't remove the mirror modifier. I first thought it was due to global undo, but disabling it doesn't seem to change the final result. (also using the Last Operator panel doesn't undo the operation, but does it multiple times instead) @watercolor: this add-on was first intended to be used from object mode (which is the most common case), then I allowed edit mode but probably never tested that case of undoing *inside* edit mode. That's why I didn't see this problem. Until this is fixed, if you have global undo activated, swap to object mode and then use AutoMirror. Then you should be able to undo it (from object mode) without undoing previous changes you made.
Author

Removed subscriber: @Sergey

Removed subscriber: @Sergey
Author

In #53084#465872, @Lapineige wrote:

@watercolor: this add-on was first intended to be used from object mode (which is the most common case), then I allowed edit mode but probably never tested that case of undoing inside edit mode. That's why I didn't see this problem.
Until this is fixed, if you have global undo activated, swap to object mode and then use AutoMirror. Then you should be able to undo it (from object mode) without undoing previous changes you made.

Lapineige, thank you for taking the time to look at this. I started using Blender about ... a day ago so some of this functionality is opaque to me.

I did try this in Edit Mode just now, with the same result? After a quick google, it seems Global Undo is active. Hmm...

> In #53084#465872, @Lapineige wrote: > > > @watercolor: this add-on was first intended to be used from object mode (which is the most common case), then I allowed edit mode but probably never tested that case of undoing *inside* edit mode. That's why I didn't see this problem. > Until this is fixed, if you have global undo activated, swap to object mode and then use AutoMirror. Then you should be able to undo it (from object mode) without undoing previous changes you made. Lapineige, thank you for taking the time to look at this. I started using Blender about ... a day ago so some of this functionality is opaque to me. I did try this in Edit Mode just now, with the same result? After a quick google, it seems Global Undo is active. Hmm...

I did try this in Edit Mode just now, with the same result?

No, apply it from object mode, and then go back to object mode (it should put you in edit mode) to cancel the operation (you can do it thanks to Global Undo).

> I did try this in Edit Mode just now, with the same result? No, apply it from object mode, and then go back to object mode (it should put you in edit mode) to cancel the operation (you can do it thanks to Global Undo).

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'

I couldn't fix this issue, making my add-on usable with undo system was breaking some of its features.
This add-on is being rewritten for Blender 2.8x, hopefully I will figure out a way to fix that.

I guess we can close this issue now.

I couldn't fix this issue, making my add-on usable with undo system was breaking some of its features. This add-on is being rewritten for Blender 2.8x, hopefully I will figure out a way to fix that. I guess we can close this issue now.
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#53084
No description provided.