Support canceling color-ramp editing with the Escape key #53756
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#53756
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Most interactions in blender can be cancelled by pressing escape.
Try drag a slider, pressing escape resets it to the value before dragging.
This is not the case for the color-ramp:
This quick hack is to support escape to cancel the change (while dragging).
Added subscriber: @ideasman42
Added subscriber: @oktomus-2
Hello, I will try to make this one in few days. This is my first contribution so if everyone wants to make it before me, just tell me :)
@oktomus-2, thanks for looking into this.
Note that we don't assign quick hacks to developers. If you're working on it - saying so is enough (having claimed but inactive tasks became a problem in the past).
@ideasman42 Ok no problem.
Found how to cancel editing on color ramps. Now, I need to find out how to reset it to its default value.
I can't figure out where to look next, I am not comfortable enough with the ui event system.
Here is what I got so far:
After detecting an ESCAPE event, I tried to change the coloramp value by giving
data->dragstartx
:But I think that
ui_numedit_but_COLORBAND
takes a mouse position and not a coloramp index. So it works but give weird results sometimes do to the calculation made inside the function. And I think that this way of resetting the ramp is wrong.So I found this in
ui_apply_but
But I don't know where I should initialize origcoba (which I added in the struct) ?
Can someone give me any advice ?
Added subscriber: @aakashkt0
Hi, I too am looking in to getting my first commit to blender.
I hope it's not a problem if I too try the task along with @oktomus-2 .
Thanks.
Works for me, if we can both understand how to fix this, that would be great :)
Looks like you have solved it, time to learn from your code :D
I suggest you to generate the Doxygen documentation, most of the code isn't documented but it's a great tool to see what structure is being used and all..
Thanks for the suggestion :)
Changed status from 'Open' to: 'Resolved'
Thanks for working on this, committed
6f45dea6ee