Particle Instance doesn't preserve edge data #54341

New Issue

Serge Lyatin · 2018-03-16T21:11:11+01:00

Serge Lyatin commented

2018-03-16 21:11:11 +01:00

System Information
Win10 64bit

Blender Version
Broken: 2.79a

Short description of error
Plane with smooth Subsurf is corrected with creases to keep angles sharp. If Subsurf is placed after Instancer, then creases won't work. Bevel weight and sharp edges also don't work.

Exact steps for others to reproduce the error
Crease.blend

**System Information** Win10 64bit **Blender Version** Broken: 2.79a **Short description of error** Plane with smooth Subsurf is corrected with creases to keep angles sharp. If Subsurf is placed after Instancer, then creases won't work. Bevel weight and sharp edges also don't work. **Exact steps for others to reproduce the error** [Crease.blend](https://archive.blender.org/developer/F2446677/Crease.blend)

Serge Lyatin commented

2018-03-16 21:11:11 +01:00

Added subscriber: @SergeL

Steffen Dünner commented

2018-03-16 21:17:27 +01:00

Added subscriber: @SteffenD

Philipp Oeser commented

2018-04-20 13:04:46 +02:00

Added subscribers: @Sergey, @lichtwerk

Philipp Oeser self-assigned this 2018-04-20 13:04:46 +02:00

Philipp Oeser commented

2018-04-20 13:04:46 +02:00

This is a limitation to the current Particle Instance modifier (not a bug though).

It doesnt handle calculating/copying edges/edgedata itself, but instead uses the more generic CDDM_calc_edges here (which has no clue of the original meshes edgedata)

It could be done though [modifiers like e.g. Array can handle this nicely], think this is a nice TODO, will put on my desk and have a look later.
Unless @Sergey thinks this is a waste of time and will be part of rewrite/overhaul anyways?

This is a limitation to the current Particle Instance modifier (not a bug though). It doesnt handle calculating/copying edges/edgedata itself, but instead uses the more generic `CDDM_calc_edges` [here ](https://developer.blender.org/diffusion/B/browse/master/source/blender/modifiers/intern/MOD_particleinstance.c;ac8f6413ccce2efe08f6a9a1a3de3c05c8d0d1d4$522) (which has no clue of the original meshes edgedata) It could be done though [modifiers like e.g. `Array` can handle this nicely], think this is a nice TODO, will put on my desk and have a look later. Unless @Sergey thinks this is a waste of time and will be part of rewrite/overhaul anyways?

Sergey Sharybin commented

2018-04-20 13:41:18 +02:00

@lichtwerk, this is something what we should support indeed. Mind looking into this? Shouldn't be hard to add support :)

Philipp Oeser commented

2018-05-03 15:56:30 +02:00

Added subscriber: @dr.sybren

Philipp Oeser commented

2018-05-03 15:56:30 +02:00

@Sergey: got it working, will post patch tomorrow (just saying, so @dr.sybren is not porting this modifier over in 2.8 before we merge?)

Sybren A. Stüvel commented

2018-05-03 17:46:17 +02:00

I'll leave porting the Particle Instance modifier to @lichtwerk then ;-)

Maybe poke me at #54737 once it's either ported or fixed up enough for me to port?

I'll leave porting the Particle Instance modifier to @lichtwerk then ;-) Maybe poke me at #54737 once it's either ported or fixed up enough for me to port?

Philipp Oeser commented

2018-05-03 22:58:48 +02:00

possible fix: D3199

possible fix: [D3199](https://archive.blender.org/developer/D3199)

blender-admin commented

2018-05-04 09:20:57 +02:00

This issue was referenced by 288d7794d4

This issue was referenced by 288d7794d4c6836e1322d5ed943c4fbd4b0b0e54

Philipp Oeser commented

2018-05-04 09:24:44 +02:00

Changed status from 'Open' to: 'Resolved'

Philipp Oeser closed this issue

2018-05-04 09:24:44 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Particle Instance doesn't preserve edge data #54341