Investigate why Spring rigs are broken in 2.8 with COW #55096

New Issue

Joshua Leung · 2018-05-16T13:07:12+02:00

Joshua Leung commented

2018-05-16 13:07:12 +02:00

Task to keep track of all the issues that are currently causing issues with the Spring/Autumn blenrig rigs in 2.8 when using COW. Fixing these is important for getting the Spring team working in 2.8 next week.

Solved Issues

~~Hook modifier on lattices doesn't work~~ [SOLVED - b6e3430417] - This was causing problems on Spring's eyes, which are almost exclusively deformed using hook-deformed lattices.
~~Double transform when both Armature Modifier + Mesh Deform are enabled on GEO_body~~ [SOLVED - 6a4ba9133c ] - This was caused by the mdef vgroup option (#55097)
- eg. In 01_025: Autumn (dog) rig has parts of geometry running off into space (i.e. you get dog body with various bits - face/head + feet - trailing off miles away). Rig is proxified.
- e.g. 01_020: Spring rig has similar problems as the dog in 01_025, except there are skin-colored spikes.
~~Bones in proxified armatures cannot be transformed/edited~~ - #55076 (@mont29)
~~Custom bones were invisible in object mode~~ (#55068)
~~"Wireframe" option for custom bone shapes is ignored~~ - This breaks control widgets with custom shape (e.g. "box" around the branch, or pyramids on feet) [SOLVED - 35a298db52]

Workarounds Possible

Dark parts of eyes not visible - This is necessary for animators to check eyelines/facial poses. (Compare: 2.8 - , master: )
- Probably cornea mesh is showing, due to drivers on "hide" properties no longer being able to work?
- The cornea material should be marked/be set as "transparent"
- Workaround: Use Mask Modifier instead to hide the geometry. (May need optimisations when all faces get removed)
- Workaround/Proper Fix: Put objects to be hidden like this into a collection, and drive the visibility of that collection

Pending/Unresolved Issues

Evaluation/Editing Speed
- Profiling suggests that the main costs are still just modifier evaluation (> 60%), particularly armature modifier (b-bone evaluation) and particles (perlin noise). COW related data copying and/or DM<->Mesh conversions were not major sources of speed issues.

Other Issues

PyController Removal + Drivers/Custom Properties Creation Script thing? - @jpbouza-4 reports that it shouldn't be an issue. To be confirmed?

To be checked:

Are there any other issues with Proxy-based workflow (apart from #55076)
Are any other parts of the rigs broken, apart from the obvious glitches above?

Task to keep track of all the issues that are currently causing issues with the Spring/Autumn blenrig rigs in 2.8 when using COW. Fixing these is important for getting the Spring team working in 2.8 next week. # Solved Issues * ~~**Hook modifier on lattices doesn't work**~~ [**SOLVED** - b6e3430417] - This was causing problems on Spring's eyes, which are almost exclusively deformed using hook-deformed lattices. * **~~Double transform when both Armature Modifier + Mesh Deform are enabled on GEO_body~~** [**SOLVED** - 6a4ba9133c ] - This was caused by the mdef vgroup option (#55097) - eg. In `01_025`: **Autumn (dog) rig has parts of geometry running off into space** (i.e. you get dog body with various bits - face/head + feet - trailing off miles away). Rig is proxified. ![spring_breakage-20180514--01_025_A.png](https://archive.blender.org/developer/F3375161/spring_breakage-20180514--01_025_A.png) - e.g. `01_020`: **Spring rig has similar problems as the dog in 01_025, except there are skin-colored spikes**. ![spring_rig-20180516--01_020.png](https://archive.blender.org/developer/F3375164/spring_rig-20180516--01_020.png) * ~~**Bones in proxified armatures cannot be transformed/edited**~~ - #55076 (@mont29) * ~~**Custom bones were invisible in object mode**~~ (#55068) * ~~**"Wireframe" option for custom bone shapes is ignored**~~ - This breaks control widgets with custom shape (e.g. "box" around the branch, or pyramids on feet) [**SOLVED** - 35a298db52] # Workarounds Possible * **Dark parts of eyes not visible** - This is necessary for animators to check eyelines/facial poses. (Compare: 2.8 - ![spring_autumn_rig-corneas-20180516--01_025.png](https://archive.blender.org/developer/F3375615/spring_autumn_rig-corneas-20180516--01_025.png), master: ![spring_autumn_rig-corneas-20180516--01_025-master.png](https://archive.blender.org/developer/F3375617/spring_autumn_rig-corneas-20180516--01_025-master.png)) - Probably cornea mesh is showing, due to drivers on "hide" properties no longer being able to work? - The cornea material should be marked/be set as "transparent" - **Workaround:** Use Mask Modifier instead to hide the geometry. (May need optimisations when all faces get removed) - **Workaround/Proper Fix:** Put objects to be hidden like this into a collection, and drive the visibility of that collection # Pending/Unresolved Issues * **Evaluation/Editing Speed** - Profiling suggests that the main costs are still just modifier evaluation (> 60%), particularly armature modifier (b-bone evaluation) and particles (perlin noise). COW related data copying and/or DM<->Mesh conversions were not major sources of speed issues. # Other Issues * **PyController Removal + Drivers/Custom Properties Creation Script thing?** - @jpbouza-4 reports that it shouldn't be an issue. To be confirmed? To be checked: * Are there any other issues with Proxy-based workflow (apart from #55076) * Are any other parts of the rigs broken, apart from the obvious glitches above?

Joshua Leung self-assigned this 2018-05-16 13:07:12 +02:00

Joshua Leung commented

2018-05-16 13:07:12 +02:00

Added subscribers: @jpbouza-4, @JoshuaLeung, @dr.sybren, @mont29, @Sergey

Juan Pablo Bouza commented

2018-05-16 17:59:04 +02:00

Regarding PyController Removal + Drivers/Custom Properties Creation Script thing , even though the rig works without it, I realized that the animations in 2.79 are keying these api defined properties, so I should add the script with the drivers trick anyway so that animations work properly.

Regarding **PyController Removal + Drivers/Custom Properties Creation Script thing** , even though the rig works without it, I realized that the animations in 2.79 are keying these api defined properties, so I should add the script with the drivers trick anyway so that animations work properly.

Sybren A. Stüvel commented

2018-05-17 09:40:17 +02:00

Profiling suggests that the main costs are still just modifier evaluation (> 60%)

Which revision was used for profiling?

> Profiling suggests that the main costs are still just modifier evaluation (> 60%) Which revision was used for profiling?

Joshua Leung commented

2018-05-17 10:55:25 +02:00

@dr.sybren Didn't note the exact revision, but it one from was Monday (14 May) afternoon, (from around 4-5:30pm). I should probably run it again (maybe daily) to check if things have changed with the DM/modifier cleanups since.

Dalai Felinto commented

2018-05-28 18:29:30 +02:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2018-05-28 18:29:30 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Investigate why Spring rigs are broken in 2.8 with COW #55096

Solved Issues

Workarounds Possible

Pending/Unresolved Issues

Other Issues