Lattice options crash #55223

New Issue

Julien Kaspar · 2018-05-28T11:54:03+02:00

Julien Kaspar commented

2018-05-28 11:54:03 +02:00

Blender Version
Broken: 95c5d1193f

Short description of error
When creating a new lattice, going to object data and changing any amount of points in any of the 3 dimensions, Blender crashes.

**Blender Version** Broken: 95c5d1193f1 **Short description of error** When creating a new lattice, going to object data and changing any amount of points in any of the 3 dimensions, Blender crashes.

Julien Kaspar commented

2018-05-28 11:54:03 +02:00

Added subscriber: @JulienKaspar

Germano Cavalcante commented

2018-05-28 20:06:20 +02:00

Added subscriber: @mano-wii

Sergey Sharybin was assigned by Germano Cavalcante

2018-05-28 20:06:20 +02:00

Germano Cavalcante commented

2018-05-28 20:06:21 +02:00

I'm not sure what the curve_cache is for lattice..
One solution would be to use the evaluated object. The curve_cache is only part of the evaluated object. (I also wonder if using the original obmat is correct in BKE_lattice_resize).
Another solution is to skip cleaning the curve_cache->disp:

diff --git a/source/blender/blenkernel/intern/lattice.c b/source/blender/blenkernel/intern/lattice.c
index 2a60bd94d10..dfa59168576 100644
--- a/source/blender/blenkernel/intern/lattice.c
+++ b/source/blender/blenkernel/intern/lattice.c
@@ -211,8 +211,10 @@ void BKE_lattice_resize(Lattice *lt, int uNew, int vNew, int wNew, Object *ltOb)
 		/* works best if we force to linear type (endpoints match) */
 		lt->typeu = lt->typev = lt->typew = KEY_LINEAR;
 
-		/* prevent using deformed locations */
-		BKE_displist_free(&ltOb->curve_cache->disp);
+		if (!DEG_depsgraph_use_copy_on_write()) {
+			/* prevent using deformed locations */
+			BKE_displist_free(&ltOb->curve_cache->disp);
+		}
 
 		copy_m4_m4(mat, ltOb->obmat);
 		unit_m4(ltOb->obmat);

I'm not sure what the `curve_cache` is for lattice.. One solution would be to use the evaluated object. The `curve_cache` is only part of the evaluated object. (I also wonder if using the original `obmat` is correct in `BKE_lattice_resize`). Another solution is to skip cleaning the `curve_cache->disp`: ``` diff --git a/source/blender/blenkernel/intern/lattice.c b/source/blender/blenkernel/intern/lattice.c index 2a60bd94d10..dfa59168576 100644 --- a/source/blender/blenkernel/intern/lattice.c +++ b/source/blender/blenkernel/intern/lattice.c @@ -211,8 +211,10 @@ void BKE_lattice_resize(Lattice *lt, int uNew, int vNew, int wNew, Object *ltOb) /* works best if we force to linear type (endpoints match) */ lt->typeu = lt->typev = lt->typew = KEY_LINEAR; - /* prevent using deformed locations */ - BKE_displist_free(&ltOb->curve_cache->disp); + if (!DEG_depsgraph_use_copy_on_write()) { + /* prevent using deformed locations */ + BKE_displist_free(&ltOb->curve_cache->disp); + } copy_m4_m4(mat, ltOb->obmat); unit_m4(ltOb->obmat); ```

Sergey Sharybin commented

2018-05-29 15:56:03 +02:00

@mano-wii , code outside of depsgraph should not make decisions based on whether copy-on-write is enabled or not (there is one exception, which gives issues and likely be changed anyway). Here it seems like you want to check curve_cache to be not-NULL. And then also tag the object for update, so all existing copies gets updated as well.

blender-admin commented

2018-05-29 20:39:44 +02:00

This issue was referenced by 00dc1c08aa

This issue was referenced by 00dc1c08aacf46546883a41068a9e6aad1fe3c04

Germano Cavalcante commented

2018-05-29 20:40:02 +02:00

Changed status from 'Open' to: 'Resolved'

Germano Cavalcante closed this issue

2018-05-29 20:40:02 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Lattice options crash #55223