Crash as soon as press material button in properties panel #55555

New Issue

Antonio Vazquez · 2018-06-20T16:47:12+02:00

Antonio Vazquez commented

2018-06-20 16:47:12 +02:00

Windows 10 64 bits - Compiled source with last version at 20/06/2018 16:00 using MSVSC 2017 Debug mode

To reproduce:

blender --factory-startup
Select material icon in properties panel
Crash

Log details: P733

Doing some debug, the function GPU_texture_bind() is failing because text field is NULL.

The line with error is this:

if (tex->bindcode != 0)

Windows 10 64 bits - Compiled source with last version at 20/06/2018 16:00 using MSVSC 2017 Debug mode To reproduce: 1) blender --factory-startup 2) Select material icon in properties panel 3) Crash Log details: [P733](https://archive.blender.org/developer/P733.txt) Doing some debug, the function GPU_texture_bind() is failing because text field is NULL. The line with error is this: ``` if (tex->bindcode != 0)

Antonio Vazquez commented

2018-06-20 16:47:12 +02:00

Added subscriber: @antoniov

blender-admin commented

2018-06-20 16:47:12 +02:00

#55567 was marked as duplicate of this issue

Philipp Oeser commented

2018-06-21 10:45:01 +02:00

Added subscribers: @ignatz, @lichtwerk

Clément Foucault was assigned by Philipp Oeser

2018-06-21 12:13:51 +02:00

Philipp Oeser commented

2018-06-21 12:13:51 +02:00

Added subscriber: @fclem

Philipp Oeser commented

2018-06-21 12:13:51 +02:00

I cannot reproduce (linux 970m, 390.59 drivers)
This has been reported a couple of times btw., see #55541, #55553, #55523, #55567 (I've closed these before because of 2.8 policy)

But I assume this is MacOS/Windows issue?

Seeing @fclem already talking about it in IRC, assigning to him?

I cannot reproduce (linux 970m, 390.59 drivers) This has been reported a couple of times btw., see #55541, #55553, #55523, #55567 (I've closed these before because of 2.8 policy) But I assume this is MacOS/Windows issue? Seeing @fclem already talking about it in IRC, assigning to him?

Antonio Vazquez commented

2018-06-21 13:55:13 +02:00

The problem is only in Windows and Mac:

Tested:
Commit 30c383fd35 works

The commit that introduced the error is this: 8c77c36539

The problem is only in Windows and Mac: Tested: Commit 30c383fd35b5184037ba58ed2f7184af39a7b946 works The commit that introduced the error is this: 8c77c3653996516ba152eade2c27980ae20a1198

Antonio Vazquez commented

2018-06-21 13:57:03 +02:00

Added subscriber: @LazyDodo

Antonio Vazquez commented

2018-06-21 13:57:52 +02:00

Only in Windows and maybe in Mac.

blender-admin commented

2018-06-21 16:10:52 +02:00

This issue was referenced by c45a3b80e2

This issue was referenced by c45a3b80e2356a952248eaafaeeec48b28bcb0fd

Antonio Vazquez commented

2018-06-21 16:11:43 +02:00

Changed status from 'Open' to: 'Resolved'

Antonio Vazquez closed this issue

2018-06-21 16:11:43 +02:00

Antonio Vazquez commented

2018-06-22 10:57:52 +02:00

@fclem I'm not sure if this is related, but now I get the same error when press F12 using Eevee. The error is not all the times (maybe 90% of times).

Clément Foucault commented

2018-06-22 11:34:36 +02:00

Hmmm then it seems that 8c77c36539 is wrong in some way.

There must be some threading issue with the context creation process. Maybe we need some mutex in GHOST for the initialization of the context at least.

Hmmm then it seems that 8c77c3653996516ba152eade2c27980ae20a1198 is wrong in some way. There must be some threading issue with the context creation process. Maybe we need some mutex in GHOST for the initialization of the context at least.

Ray molenkamp commented

2018-06-23 05:20:03 +02:00

Changed status from 'Resolved' to: 'Open'

Ray molenkamp reopened this issue

2018-06-23 05:20:03 +02:00

Ray molenkamp commented

2018-06-23 05:20:03 +02:00

Added subscriber: @mano-wii

Ray molenkamp commented

2018-06-23 05:20:03 +02:00

It's a classic race condition, here's what's up

sometimes:

main thread: createOffscreenContext (offscreen context is now bound to main thread)
main thread: Start background render.
mainthread redraws ui and calls wglMakeCurrent on the gui context, detaching the offscreencontext from the main thread.
Background Thread: wglMakeCurrent on offscreen context succeeds since it's not bound currently

Render success!

most of the time:

main thread: createOffscreenContext (offscreen context is now bound to main thread)
main thread: Start background render.
Background Thread: wglMakeCurrent on offscreen context fails since it's still bound to the main thread.
mainthread redraws ui and calls wglMakeCurrent on the gui context.
background thread tries to make a texture without an active context, and crashes.

Something like P737 fixes it, but feels kinda hacky (I suppose this might also be an issue on other platforms which this patch doesn't address), @mano-wii any opinions here? maybe have make it a requirement that createOffscreenContext restores the context it was on when it was called?

It's a classic race condition, here's what's up sometimes: 1. main thread: createOffscreenContext (offscreen context is now bound to main thread) 2. main thread: Start background render. 3. mainthread redraws ui and calls wglMakeCurrent on the gui context, detaching the offscreencontext from the main thread. 4. Background Thread: wglMakeCurrent on offscreen context succeeds since it's not bound currently Render success! most of the time: 1. main thread: createOffscreenContext (offscreen context is now bound to main thread) 2. main thread: Start background render. 3. Background Thread: wglMakeCurrent on offscreen context fails since it's still bound to the main thread. 4. mainthread redraws ui and calls wglMakeCurrent on the gui context. 5. background thread tries to make a texture without an active context, and crashes. Something like [P737](https://archive.blender.org/developer/P737.txt) fixes it, but feels kinda hacky (I suppose this might also be an issue on other platforms which this patch doesn't address), @mano-wii any opinions here? maybe have make it a requirement that createOffscreenContext restores the context it was on when it was called?

Clément Foucault commented

2018-06-23 10:17:14 +02:00

Well my latest refactor in this area was to assure that a context is only made current on the thread that will use it (first time made active in GHOST_ContextWGL::initContext). So maybe I overlooked something.

Ray molenkamp commented

2018-06-23 19:38:28 +02:00

Changed status from 'Open' to: 'Resolved'

Ray molenkamp closed this issue

2018-06-23 19:38:28 +02:00

Ray molenkamp commented

2018-06-23 19:38:28 +02:00

I tried doing the same thing, and that blew up a tiny bit, to share resources the creating thread needs exclusive access to the main context currently bound to the main thread. WM_opengl_context_create has a comment about it, guess i'm not the first one to try and fail at this :)

Think best way forward is have createOffscreenContext create the context, but restore the calling context when it's done. Implemented this in D3499 and F12 , Background renders and the material tab all work now.

I tried doing the same thing, and that blew up a tiny bit, to share resources the creating thread needs exclusive access to the main context currently bound to the main thread. WM_opengl_context_create has a comment about it, guess i'm not the first one to try and fail at this :) Think best way forward is have createOffscreenContext create the context, but restore the calling context when it's done. Implemented this in [D3499](https://archive.blender.org/developer/D3499) and F12 , Background renders and the material tab all work now.

Antonio Vazquez commented

2018-06-23 19:44:50 +02:00

thanks @LazyDodo

Stephen Hamacek commented

2018-06-26 02:35:21 +02:00

Added subscriber: @StephenHamacek

Stephen Hamacek commented

2018-06-26 02:58:03 +02:00

Thanks, mac build fixed for me too.

Kristi Centinaro commented

2018-07-08 14:08:55 +02:00

Added subscriber: @KristiCentinaro

Kristi Centinaro commented

2018-07-08 14:08:55 +02:00

I wanted to report seeing this with the latest build as of 7/8/2018. I used both Windows x64 versions available and consistently saw the same result.

System: Windows 10 Home

Steps to reproduce:

Start blender default configuration
Select Cube
Navigate to the materials tab in properties panel

App would then crash.

I wanted to report seeing this with the latest build as of 7/8/2018. I used both Windows x64 versions available and consistently saw the same result. System: Windows 10 Home Steps to reproduce: - Start blender default configuration - Select Cube - Navigate to the materials tab in properties panel App would then crash.

Leon Lee commented

2018-07-08 14:28:42 +02:00

Added subscriber: @lileo

Leon Lee commented

2018-07-08 14:28:42 +02:00

macOS : Blender(7/8/2018)

blender --factory-startup
Select Light icon in properties panel
Crash

macOS : Blender(7/8/2018) blender --factory-startup Select Light icon in properties panel Crash

Mezgin Osman commented

2019-07-31 15:56:07 +02:00

Added subscriber: @mezgino85

Mezgin Osman commented

2019-07-31 15:56:07 +02:00

so , what i have to do to fix this Bug??
Crashed when pressing material icon
WIN 10 , 64 B

renderer: 'Quadro 2000M/PCIe/SSE2'
vendor: 'NVIDIA Corporation'
version: '4.5.0 NVIDIA 347.88'

so , what i have to do to fix this Bug?? Crashed when pressing material icon WIN 10 , 64 B renderer: 'Quadro 2000M/PCIe/SSE2' vendor: 'NVIDIA Corporation' version: '4.5.0 NVIDIA 347.88'

Brecht Van Lommel commented

2019-07-31 15:57:05 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2019-07-31 15:57:05 +02:00

@mezgino85, see my reply in #68003 (Report Bug).

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash as soon as press material button in properties panel #55555