Crash Dyntopo Sample Pipette #56004

New Issue

Silas Opel · 2018-07-17T00:09:50+02:00

Silas Opel commented

2018-07-17 00:09:50 +02:00

Blender Version
Broken:Blender 2.8 dc123ac9e5 (example: 2.69.7 4b206af, see splash screen)

Short description of error
When you use the sample pipette in the dyntopo function and sample the mesh blender will crash. You have to use constant detail for the function.

**Blender Version** Broken:Blender 2.8 dc123ac9e5a (example: 2.69.7 4b206af, see splash screen) **Short description of error** When you use the sample pipette in the dyntopo function and sample the mesh blender will crash. You have to use constant detail for the function.

Silas Opel commented

2018-07-17 00:09:50 +02:00

Added subscriber: @DarkKnight

blender-admin commented

2018-07-17 00:09:50 +02:00

#56058 was marked as duplicate of this issue

Philipp Oeser commented

2018-07-17 10:30:59 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2018-07-17 10:30:59 +02:00

Can confirm. But only if you use the Pipette icon button from the popover.
Works as expected if you use Search in the 3D view and invoke "Sample Detail size" from there...

1  ED_view3d_win_to_origin         view3d_project.c  576  0x1adc87f 
2  view3d_win_to_ray_segment       view3d_project.c  327  0x1adbfeb 
3  ED_view3d_win_to_segment        view3d_project.c  642  0x1adcada 
4  sculpt_raycast_init             sculpt.c          4698 0x1f88dc1 
5  sample_detail                   sculpt.c          5946 0x1f8bec3 
6  sculpt_sample_detail_size_modal sculpt.c          5987 0x1f8c07a 
7  wm_handler_operator_call        wm_event_system.c 1958 0x1989e80

Crashes because rv3d is NULL.
We are initializing viewcontext from topbar region (not view3d main region as in 2.79)
ED_view3d_viewcontext_init() in sample_detail():

CTX_wm_region(C) will return topbar region (not view3d main region as in 2.79)
CTX_wm_view3d(C) will return NULL because ScrArea->spacetype is not SPACE_VIEW3D (but SPACE_TOPBAR)

Can confirm. But only if you use the Pipette icon button from the popover. Works as expected if you use Search in the 3D view and invoke "Sample Detail size" from there... ``` 1 ED_view3d_win_to_origin view3d_project.c 576 0x1adc87f 2 view3d_win_to_ray_segment view3d_project.c 327 0x1adbfeb 3 ED_view3d_win_to_segment view3d_project.c 642 0x1adcada 4 sculpt_raycast_init sculpt.c 4698 0x1f88dc1 5 sample_detail sculpt.c 5946 0x1f8bec3 6 sculpt_sample_detail_size_modal sculpt.c 5987 0x1f8c07a 7 wm_handler_operator_call wm_event_system.c 1958 0x1989e80 ``` Crashes because rv3d is NULL. We are initializing viewcontext from topbar region (not view3d main region as in 2.79) `ED_view3d_viewcontext_init()` in `sample_detail()`: - CTX_wm_region(C) will return topbar region (not view3d main region as in 2.79) - CTX_wm_view3d(C) will return NULL because ScrArea->spacetype is not SPACE_VIEW3D (but SPACE_TOPBAR)

Philipp Oeser commented

2018-07-20 10:24:08 +02:00

Added subscriber: @arunsnkr