Regression in classroom benchmark scene #57934

Closed
opened 2018-11-19 13:37:18 +01:00 by Sergey Sharybin · 8 comments

System Information

Debian Buster 64bit, GTX1080 390.87

Blender Version

Broken: b0c463a274
Worked: master, and 2.8 prior to change which forbid dupli-group on non-empties

Short description of error

Not sure this was the best solution to ignore duplication. In the reality the duplicated objects is what you care about more than the mesh. So think changing duplicator object to empty to properly keep duplication in place is a more correct solution.

Or create a separate empty object.

Or at least add a warning when opening such files.

Failing silently is not a good thing to do.

Exact steps for others to reproduce the error

Get classroom scene from https://svn.blender.org/svnroot/bf-blender/trunk/lib/benchmarks/cycles/classroom/ and open it in 2.8. All the desks are missing.

**System Information** Debian Buster 64bit, GTX1080 390.87 **Blender Version** Broken: b0c463a274 Worked: master, and 2.8 prior to change which forbid dupli-group on non-empties **Short description of error** Not sure this was the best solution to ignore duplication. In the reality the duplicated objects is what you care about more than the mesh. So think changing duplicator object to empty to properly keep duplication in place is a more correct solution. Or create a separate empty object. Or at least add a warning when opening such files. Failing silently is not a good thing to do. **Exact steps for others to reproduce the error** Get classroom scene from https://svn.blender.org/svnroot/bf-blender/trunk/lib/benchmarks/cycles/classroom/ and open it in 2.8. All the desks are missing.
Author
Owner

Added subscriber: @Sergey

Added subscriber: @Sergey
Member

Added subscribers: @ideasman42, @lichtwerk

Added subscribers: @ideasman42, @lichtwerk
Campbell Barton was assigned by Philipp Oeser 2018-11-26 15:17:39 +01:00
Member

Confirmed, relating commit is 2eca054e14.

Will happily work on any replacement method that @Sergey suggested (if any could be agreed on), but assigning @ideasman42 first to hear opinions...

Confirmed, relating commit is 2eca054e14. Will happily work on any replacement method that @Sergey suggested (if any could be agreed on), but assigning @ideasman42 first to hear opinions...

The case of having non empty objects duplicating data is quite obscure and leads to hard to debug situations where some object doesn't render, you need to know to look for this setting to turn it off.

We could version patch the blend file to add in empties to instance the group which are parented to the meshes (so as to follow their animation).

The meshes will need render-ability turned off.

The case of having non empty objects duplicating data is quite obscure and leads to hard to debug situations where some object doesn't render, you need to know to look for this setting to turn it off. We could version patch the blend file to add in empties to instance the group which are parented to the meshes (so as to follow their animation). The meshes will need render-ability turned off.

Committed classroom blend files which don't instance from meshes, we could still support this, in the short term this means 2.8 can benchmark the file against 2.7.

Committed classroom blend files which don't instance from meshes, we could still support this, in the short term this means 2.8 can benchmark the file against 2.7.
Author
Owner

There are at least one of the following things i still expect to happen:

  • Change mesh to empty with dupli-group (or add an extra empty object, keeping the mesh).
  • Show a warning about unsupported instancing detected.
There are at least one of the following things i still expect to happen: - Change mesh to empty with dupli-group (or add an extra empty object, keeping the mesh). - Show a warning about unsupported instancing detected.

This issue was referenced by 7fe3d1e7d7

This issue was referenced by 7fe3d1e7d718561e275f21acc7261207e67bf685

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#57934
No description provided.