Page MenuHome
Maniphest T57977

When using box select in the VSE, all marker lines get highlighted
Closed, ResolvedPublic
Actions

Description

System Information
Xbuntu / AMD

Blender Version
e85aa8b

Short description of error
When working in the VSE, if you use box selection (B) all the marker lines get highlighter (turn white)

Exact steps for others to reproduce the error
New file
Go to the VSE
Create a few markers
Do box selection in the VSE (even though there's nothing in it)
...all the marker lines become highlighted...

Details

Commits
rB3280adc0aa31: Fix T57977: VSE: Markers lines get highlighted when using box select
Type
Bug

Related Objects

Event Timeline

Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).Nov 22 2018, 12:51 PM
Philipp Oeser (lichtwerk) claimed this task.
Philipp Oeser (lichtwerk) triaged this task as Confirmed, Medium priority.

Confirmed, checking...

Philipp Oeser (lichtwerk) added a subscriber: Clément Foucault (fclem).Nov 22 2018, 3:53 PM
Philipp Oeser (lichtwerk) reassigned this task from Philipp Oeser (lichtwerk) to Clément Foucault (fclem).

Note1: this goes away on a redraw (when panning the view)

Note2: drawing the marker lines ( draw_marker() ) seems to interfere with wm_gesture_draw_rect()
(e.g. I can change the color for the gesture border and the 'highlighted' marker lines described in the report appear in the same color)

Somehow the one programm (gesture border) is not finished correctly?

  • both use immBindBuiltinProgram(GPU_SHADER_2D_LINE_DASHED_UNIFORM_COLOR)
  • both have a block with immBegin and immEnd
  • both do immUnbindProgram()

Not sure whats going on, would like to hand this off to @Clément Foucault (fclem)... [or maybe he could tell me a way to debug this properly...]

Clément Foucault (fclem) added a comment.Nov 22 2018, 4:17 PM

@Philipp Oeser (lichtwerk) This is because wm_gesture_draw_rect change a uniform and uniform values are stored inside the shader. So if the next time the shader is used the uniform is not set to the desired value, it will use the previous one.