NodeWrangler - add texture for principled: extend func, clean #58039

New Issue

Dawid Huczyński · 2018-11-24T23:12:37+01:00

Dawid Huczyński commented

2018-11-24 23:12:37 +01:00

Recentely I did some import operator for PBR textures, and realized it is quite simillar to this one in node wrangler.
I wanted to extend

node.nw_add_textures_for_principled

with ao and alpha textures. As well to cleanup bump and normal relations (as a separate input textures).
It is based on nice presentation
https://docs.google.com/presentation/d/1hfBMyd4bi7JYIX-rP3JnkO4z5LhqEyXP3mUUA9kxoKU/edit#slide=id.p

Additionally, there are variation in spec/roughness ranges for almost every PBR texture source, so I've added adjust layer of nodes, for ease of use.

I've created this task to ask you all if i can update those changes. It is my first commit here for other author code.

Recentely I did some import operator for PBR textures, and realized it is quite simillar to this one in node wrangler. I wanted to extend ``` node.nw_add_textures_for_principled ``` with ao and alpha textures. As well to cleanup bump and normal relations (as a separate input textures). It is based on nice presentation https://docs.google.com/presentation/d/1hfBMyd4bi7JYIX-rP3JnkO4z5LhqEyXP3mUUA9kxoKU/edit#slide=id.p Additionally, there are variation in spec/roughness ranges for almost every PBR texture source, so I've added adjust layer of nodes, for ease of use. I've created this task to ask you all if i can update those changes. It is my first commit here for other author code. ![pbr.PNG](https://archive.blender.org/developer/F5707729/pbr.PNG)

Dawid Huczyński self-assigned this 2018-11-24 23:12:38 +01:00

Dawid Huczyński commented

2018-11-24 23:12:38 +01:00

Added subscriber: @tibicen

Brecht Van Lommel commented

2018-11-24 23:32:18 +01:00

Added subscriber: @brecht

Brecht Van Lommel commented

2018-11-24 23:32:18 +01:00

It's best to submit a patch to be reviewed:
https://developer.blender.org/differential/diff/create/

I'm not sure adding extra nodes for adjustment in between by default is a good idea. Blender 2.8 material export for OBJ / FBX / Collada / GLTF will probably fail if the image texture is not directly connected to the socket.

I'm also not sure about multiplying AO with the base color. that's not physically correct. Usually AO textures are used as an approximation for indirect diffuse light, but baked in advance for better performance. However Cycles and Eevee already compute their own indirect diffuse light. Further, this should not normally affect direct lighting.

AO can be used like this for artistic purposes, but it should not be interpreted that way by default.

It's best to submit a patch to be reviewed: https://developer.blender.org/differential/diff/create/ I'm not sure adding extra nodes for adjustment in between by default is a good idea. Blender 2.8 material export for OBJ / FBX / Collada / GLTF will probably fail if the image texture is not directly connected to the socket. I'm also not sure about multiplying AO with the base color. that's not physically correct. Usually AO textures are used as an approximation for indirect diffuse light, but baked in advance for better performance. However Cycles and Eevee already compute their own indirect diffuse light. Further, this should not normally affect direct lighting. AO can be used like this for artistic purposes, but it should not be interpreted that way by default.

Dawid Huczyński commented

2018-12-05 15:06:18 +01:00

Hi, I know there is a lot to do around all the stuff and bugs, but i was just wondering ifI did everything correct here?
If yes please just reply it is just waiting to review, don't even review it now.
If notplease help me understand how to commit it to proper branch.

Hi, I know there is a lot to do around all the stuff and bugs, but i was just wondering if**I did everything correct here?** **If yes** please just reply it is just waiting to review, don't even review it now. **If not**please help me understand how to commit it to proper branch.

Florian Meyer commented

2018-12-05 16:25:12 +01:00

Added subscriber: @florianfelix