Cursor position wrong when edit text on curve #58284

Closed
opened 2018-11-30 09:34:21 +01:00 by Roel Koster · 10 comments
Member

System Information
Operating system: OSX/Linux
Graphics card: Intel/Nvidia/AMD

Blender Version
Broken: Daily builds 2.80
Worked: never?

Short description of error
When having a text on a curve and entering edit mode, the cursor location is not at the end but one character before the last.. adding text however will still append to the end.

Exact steps for others to reproduce the error
Factory Defaults
Add Curve
Add Text
Select Text on Curve and select Curve
TAB to edit mode
Observe wrong cursor location

Screenshot 2018-11-30 at 09.27.58.png

**System Information** Operating system: OSX/Linux Graphics card: Intel/Nvidia/AMD **Blender Version** Broken: Daily builds 2.80 Worked: never? **Short description of error** When having a text on a curve and entering edit mode, the cursor location is not at the end but one character before the last.. adding text however will still append to the end. **Exact steps for others to reproduce the error** Factory Defaults Add Curve Add Text Select Text on Curve and select Curve TAB to edit mode Observe wrong cursor location ![Screenshot 2018-11-30 at 09.27.58.png](https://archive.blender.org/developer/F5765666/Screenshot_2018-11-30_at_09.27.58.png)
Author
Member

Added subscriber: @kostex

Added subscriber: @kostex
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Philipp Oeser self-assigned this 2018-11-30 11:57:50 +01:00
Member

Confirmed, same is true for 2.79. Will check in a bit if this is a hassle to get right...

Confirmed, same is true for 2.79. Will check in a bit if this is a hassle to get right...
Author
Member

Still an issue..

Still an issue..
Author
Member

Since 2.8 is master.. remove this tag.. maybe it will get some attention now ;-)

Since 2.8 is master.. remove this tag.. maybe it will get some attention now ;-)
Member

@kostex: will look into this shortly [this wasnt high on the list because it is also an issue in 2.79...]

@kostex: will look into this shortly [this wasnt high on the list because it is also an issue in 2.79...]
Philipp Oeser changed title from Cursor position wrong when edit text on curve (2.80) to Cursor position wrong when edit text on curve 2019-01-23 15:40:29 +01:00
Philipp Oeser removed their assignment 2019-01-28 13:57:10 +01:00
Campbell Barton was assigned by Philipp Oeser 2019-01-28 13:57:10 +01:00
Member

Added subscriber: @ideasman42

Added subscriber: @ideasman42
Member

This is caused by 8a379e3460

Commit message reads:

3D Text: avoid checking null character's text on path
Redundant and causes complications when improving text code.

And code comment:

null character is always zero width, no need to iterate over it

And while it is true that the width is always zero, the CharTrans->xof offset is still different from the previous characters... [which will result in the cursor being "off by one"]

So just reverting 8a379e3460 solves the issue [and afaict doesnt cause other issues], but I would kindly ask @ideasman42 to doublecheck [not sure what he meant by "complications when improving text code"...]

This is caused by 8a379e3460 Commit message reads: > 3D Text: avoid checking null character's text on path > Redundant and causes complications when improving text code. And code comment: > null character is always zero width, no need to iterate over it And while it is true that the width is always zero, the `CharTrans->xof` offset is still different from the previous characters... [which will result in the cursor being "off by one"] So just reverting 8a379e3460 solves the issue [and afaict doesnt cause other issues], but I would kindly ask @ideasman42 to doublecheck [not sure what he meant by "complications when improving text code"...]
Member

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Member

Should be resolved then, I guess 964a3f1097

Should be resolved then, I guess 964a3f1097
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#58284
No description provided.