Page MenuHome
Maniphest T58739

Camera Location, keyframe Bug
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: Win 10 64 bit
Graphics card: 2xGTX 1080 Ti

Blender Version
Broken:
2.80, 2018-12-03, a205493426b
Worked: (optional)

Short description of error
When camera location keyframed beyond timeline(or sometimes in) can't change keyframed values from 1st keyframe.

Exact steps for others to reproduce the error
Create camera, set view to camera, add keyframe, change position on timeline, move camera in location tab - its looking like view is still only outframe of camera is moving and changing visual od depth. After release for ex OY location it will back to value from first keyframe. If description will be not enough I can provide video.

Details

Commits
rB259879e13547: Fix T58739: Camera Location, keyframe Bug
Type
Bug

Related Objects

Event Timeline

Sebastian Parborg (zeddb) added a subscriber: Sebastian Parborg (zeddb).Dec 5 2018, 11:16 AM

I can not reproduce this issue. All location values does not seem to reset to previous value (unless the timeline is changed).

Sebastian Parborg (zeddb) added a comment.Dec 5 2018, 12:14 PM

Is this still a problem for you if you switch to solid mode? Perhaps it's a problem with the rendered view.

However, I still have a hard time to reproduce this issue on my side (I'm on linux and built blender from git).
I'm trying to reproduce this issue with the default blender cube scene and I'm having no luck with that.

It would be really helpful if you could create a minimal blend file that have the issue and upload it here.

Philip (DrPhil) added a comment.Dec 5 2018, 1:17 PM

camera_bug.blend601 KBDownload

Here is a file - try to change OY and keyframe it while in view to camera

Sebastian Parborg (zeddb) added a comment.Dec 5 2018, 3:23 PM

I can reproduce the issue on my end with that file, thanks!

Sebastian Parborg (zeddb) added a comment.Dec 5 2018, 3:58 PM

Have you tried any newer blender versions? If I open up your scene and duplicate the camera and set that one as the active camera, it does not have this problem.
I'm beginning to suspect that this issue has been solved in never 2.8 builds. But files created with older builds are still bugged.

Philip (DrPhil) added a comment.Dec 5 2018, 4:10 PM

Video I sent was from a20549342 version from 2 days ago

and file I sent was created in be91d4ef9 version that is from yesterday

Sebastian Parborg (zeddb) added a comment.Dec 5 2018, 4:21 PM

Does the problem still happen if you copy the camera and set the copy as the active scene camera?

Philip (DrPhil) added a comment.Dec 5 2018, 4:33 PM

Yes, it behave in same way. But if I "go out" of camera it start working properly.

Philip (DrPhil) added a comment.Dec 5 2018, 4:35 PM

Now I deleted this copied camera and again select old camera as active and now it looks like it is working properly.

Sebastian Parborg (zeddb) assigned this task to Sergey Sharybin (sergey).Dec 6 2018, 10:07 AM
Sebastian Parborg (zeddb) lowered the priority of this task from Needs Triage by Developer to Confirmed, Medium.

According to angavrilov on IRC, this seem to be a depsgraph issue:

angavrilov | DarkDefender: right, after a brief look it seems something fishy may be happening with the AnimData->recalc flag - it's probably related to COW and depsgraph, so need to discuss with hackerman-
angavrilov | DarkDefender: basically, it seems if that flag is set on the non-COW instance, it is never cleaned up and forces animation to be re-evaluated every time
angavrilov | DarkDefender: If I clear that stuck flag from that camera object in the debugger, the bug is fixed

Sergey Sharybin (sergey) added subscribers: Alexander Gavrilov (angavrilov), Brecht Van Lommel (brecht).Dec 6 2018, 11:11 AM

@Alexander Gavrilov (angavrilov) , why not to talk here, huh ;)

I am a strong believer in theory that AnimData->recalc flag is to be forgotten, gone and never brought back. It is kind of conflicts with granularity nature of the new dependency graph.

This is also something, i believe, we've discussed with @Brecht Van Lommel (brecht) about IDs -- they shouldn't get recalc flags set nowadays.

dika sahid (d_asap) added a subscriber: dika sahid (d_asap).Dec 10 2018, 8:08 AM

i experience the same problem on keyframing bug. the only way to pass it is to edit it via graph editor