Appended menus to VIEW3D_MT_editor_menus are not displayed #58937

New Issue

domlysz · 2018-12-07T14:22:19+01:00

domlysz commented

2018-12-07 14:22:19 +01:00

Blender Version
Broken: 2.80,

Short description of error

The code bellows illustrate the issue : a new menu is added to to VIEW3D_MT_editor_menus class which inherit from bpy.types.Menu and embed others 3d view menus, but this new menu does not appears. If VIEW3D_MT_editor_menus is displaying in another panel then the new menu appears which confirms that the append is effective.
See also related BA thread .

import bpy

class VIEW3D_MT_menu(bpy.types.Menu):
    bl_label = "Test"

    def draw(self, context):
        self.layout.operator("mesh.primitive_monkey_add")

def addmenu_callback(self, context):
    self.layout.menu("VIEW3D_MT_menu")


def register():
    bpy.utils.register_class(VIEW3D_MT_menu)
    bpy.types.VIEW3D_MT_editor_menus.append(addmenu_callback)

def unregister():
    bpy.types.VIEW3D_MT_editor_menus.remove(addmenu_callback)
    bpy.utils.register_class(VIEW3D_MT_menu)


if __name__ == "__main__":
	register()

**Blender Version** Broken: 2.80, **Short description of error** The code bellows illustrate the issue : a new menu is added to to `VIEW3D_MT_editor_menus` class which inherit from `bpy.types.Menu` and embed others 3d view menus, but this new menu does not appears. If `VIEW3D_MT_editor_menus` is displaying in another panel then the new menu appears which confirms that the append is effective. See also related [BA thread ](https://blenderartists.org/t/blender-2-8-add-view-3d-menu/1137302/4). ``` import bpy class VIEW3D_MT_menu(bpy.types.Menu): bl_label = "Test" def draw(self, context): self.layout.operator("mesh.primitive_monkey_add") def addmenu_callback(self, context): self.layout.menu("VIEW3D_MT_menu") def register(): bpy.utils.register_class(VIEW3D_MT_menu) bpy.types.VIEW3D_MT_editor_menus.append(addmenu_callback) def unregister(): bpy.types.VIEW3D_MT_editor_menus.remove(addmenu_callback) bpy.utils.register_class(VIEW3D_MT_menu) if __name__ == "__main__": register() ```

domlysz commented

2018-12-07 14:22:20 +01:00

Added subscriber: @domlysz

Philipp Oeser commented

2018-12-08 15:30:39 +01:00

Added subscribers: @ideasman42, @lichtwerk

Philipp Oeser commented

2018-12-08 15:30:39 +01:00

Seems like VIEW3D_HT_header calls
VIEW3D_MT_editor_menus.draw_collapsible(context, layout)

which in turn calls
cls.draw_menus(layout.row(align=True), context)

then
VIEW3D_MT_editor_menus.draw_menus() is pretty hardcoded (and doesnt really take into any appended menus as it seems)

Not sure exactly why it works when the VIEW3D_MT_editor_menus is placed in a panel in the Properties Editor.

Maybe @ideasman42 knows?

Seems like VIEW3D_HT_header calls `VIEW3D_MT_editor_menus.draw_collapsible(context, layout)` which in turn calls `cls.draw_menus(layout.row(align=True), context)` then `VIEW3D_MT_editor_menus.draw_menus()` is pretty hardcoded (and doesnt really take into any appended menus as it seems) Not sure exactly why it works when the `VIEW3D_MT_editor_menus` is placed in a panel in the Properties Editor. Maybe @ideasman42 knows?

Campbell Barton commented

2018-12-20 01:02:35 +01:00

This isn't exactly a bug since this method of drawing doesn't use a menu instance.

Even so, it would be nice to support.

We could workaround this but not really happy with this solution especially since it's running in the typical case when all items are displayed.

diff --git a/release/scripts/modules/bpy_types.py b/release/scripts/modules/bpy_types.py
index c6552334dcf..5bd3a2882a6 100644
--- a/release/scripts/modules/bpy_types.py
+++ b/release/scripts/modules/bpy_types.py
@@ -920,7 +920,11 @@ class Menu(StructRNA, _GenericUI, metaclass=RNAMeta):
         # only usable within headers
         if context.area.show_menus:
             # Align menus to space them closely.
-            cls.draw_menus(layout.row(align=True), context)
+            fake_self =  type("FakeMenu", (), {
+                "layout": layout.row(align=True),
+                "draw_menus": cls.draw_menus,
+            })
+            cls.draw(fake_self, context)
         else:
             layout.menu(cls.__name__, icon='COLLAPSEMENU')

Edit, thinking about this - I think the correct solution is to add a method that draws the menu expanded (in the header or panel...). Then we get a menu instance and don't need to have a hacky workaround.

This isn't exactly a bug since this method of drawing doesn't use a menu instance. Even so, it would be nice to support. We could workaround this but not really happy with this solution especially since it's running in the typical case when all items are displayed. ``` diff --git a/release/scripts/modules/bpy_types.py b/release/scripts/modules/bpy_types.py index c6552334dcf..5bd3a2882a6 100644 --- a/release/scripts/modules/bpy_types.py +++ b/release/scripts/modules/bpy_types.py @@ -920,7 +920,11 @@ class Menu(StructRNA, _GenericUI, metaclass=RNAMeta): # only usable within headers if context.area.show_menus: # Align menus to space them closely. - cls.draw_menus(layout.row(align=True), context) + fake_self = type("FakeMenu", (), { + "layout": layout.row(align=True), + "draw_menus": cls.draw_menus, + }) + cls.draw(fake_self, context) else: layout.menu(cls.__name__, icon='COLLAPSEMENU') ``` ---- Edit, thinking about this - I think the correct solution is to add a method that draws the menu expanded (in the header or panel...). Then we get a menu instance and don't need to have a hacky workaround.

blender-admin commented

2018-12-20 01:33:08 +01:00

This issue was referenced by blender/blender@756be8f4d8

This issue was referenced by blender/blender@756be8f4d8ff2ba3915b67c36c2e40f1652397da

blender-admin commented

2018-12-20 02:00:20 +01:00

This issue was referenced by blender/blender@dc3d9467f2

This issue was referenced by blender/blender@dc3d9467f2b62bf241d95ab62312304a82ab3b28

Campbell Barton commented

2018-12-20 02:03:27 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2018-12-20 02:03:27 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Appended menus to VIEW3D_MT_editor_menus are not displayed #58937