Keyframed node properties stay linked after shading network duplication #59062

New Issue

Nicolas Prigent · 2018-12-09T10:32:08+01:00

Nicolas Prigent commented

2018-12-09 10:32:08 +01:00

System Information
Operating system: windows 10
Graphics card: gtx 760

Blender Version
Broken: 2.8 beta
Worked: 2.79

Short description of error
Keyframed node properties stay linked after shading network duplication

Exact steps for others to reproduce the error
If I duplicate from the properties panel a shader that as animated nodes, those animated nodes are linked in some way by their keyframes : if I move or delete a keyframe on the base shader, it moves or delete it also on the duplicated shader, althought I can change node properties that are not keyed. You'll find a test file showing the bug, the animation is on the color mix node. Just move or delete a keyframe on the animation.

animated_nodes_bug.blend

**System Information** Operating system: windows 10 Graphics card: gtx 760 **Blender Version** Broken: 2.8 beta Worked: 2.79 **Short description of error** Keyframed node properties stay linked after shading network duplication **Exact steps for others to reproduce the error** If I duplicate from the properties panel a shader that as animated nodes, those animated nodes are linked in some way by their keyframes : if I move or delete a keyframe on the base shader, it moves or delete it also on the duplicated shader, althought I can change node properties that are not keyed. You'll find a test file showing the bug, the animation is on the color mix node. Just move or delete a keyframe on the animation. [animated_nodes_bug.blend](https://archive.blender.org/developer/F5897690/animated_nodes_bug.blend)

Nicolas Prigent commented

2018-12-09 10:32:08 +01:00

Added subscriber: @boustalahit

blender-admin commented

2018-12-09 10:32:08 +01:00

#62393 was marked as duplicate of this issue

Philipp Oeser commented

2018-12-13 13:35:35 +01:00

Added subscribers: @JacquesLucke, @JoshuaLeung, @lichtwerk

Philipp Oeser commented

2018-12-13 13:35:35 +01:00

Confirmed.
Seems another issue with data path resolution on nodes [I dont remember the details, but I do recall there were issues relating to this (nodes and drivers e.g.)]

Also note that renaming a node will break the animation actually (was not the case in 2.79)

#59256 is related

@JoshuaLeung: mind sharing your wisdom?
or maybe @JacquesLucke has an idea?

Confirmed. Seems another issue with data path resolution on nodes [I dont remember the details, but I do recall there were issues relating to this (nodes and drivers e.g.)] Also note that renaming a node will break the animation actually (was not the case in 2.79) #59256 is related @JoshuaLeung: mind sharing your wisdom? or maybe @JacquesLucke has an idea?

Philipp Oeser commented

2018-12-19 14:43:19 +01:00

Added subscriber: @Sergey

Philipp Oeser commented

2018-12-19 14:43:19 +01:00

#59390 was also reported (which I think has the same roots)

adding @Sergey here...

#59390 was also reported (which I think has the same roots) adding @Sergey here...

Philipp Oeser commented

2019-01-22 16:04:33 +01:00

Interstingly, though #59390 is resolved, this is still happening.
So making a single material user from the row.template_ID(ob, "active_material", new="material.new") doesnt seem to do the same thing as Object > Relations > Make Single User > Materials

Interstingly, though #59390 is resolved, this is still happening. So making a single material user from the `row.template_ID(ob, "active_material", new="material.new")` doesnt seem to do the same thing as `Object` > `Relations` > `Make Single User` > `Materials`

Philipp Oeser commented

2019-02-13 15:58:43 +01:00

Added subscriber: @mont29

Philipp Oeser commented

2019-02-13 15:58:43 +01:00

In #59062#604282, @lichtwerk wrote:
So making a single material user from the row.template_ID(ob, "active_material", new="material.new") doesnt seem to do the same thing as Object > Relations > Make Single User > Materials

@mont29: can you confirm the above? (difference between Object > Relations > Make Single User > Materials and using the template_ID from the Properties Editor [doesnt matter if you make single user or add new from there])

Properties Editor doesnt seem to make animation unique, whereas Object > Relations > Make Single User > Materials seems to do so...
Should this be consistent (just asking...)?

> In #59062#604282, @lichtwerk wrote: > So making a single material user from the `row.template_ID(ob, "active_material", new="material.new")` doesnt seem to do the same thing as `Object` > `Relations` > `Make Single User` > `Materials` @mont29: can you confirm the above? (difference between `Object` > `Relations` > `Make Single User` > `Materials` and using the template_ID from the Properties Editor [doesnt matter if you make single user or add new from there]) Properties Editor doesnt seem to make animation unique, whereas `Object` > `Relations` > `Make Single User` > `Materials` seems to do so... Should this be consistent (just asking...)?

Bastien Montagne self-assigned this 2019-02-13 17:18:56 +01:00

Bastien Montagne commented

2019-02-13 17:18:56 +01:00

Those are two different operators/operatioons, but do not see why copying material from IDTemplate widget should not also duplicate its actions. Fix incoming.

blender-admin commented

2019-02-13 17:19:18 +01:00

This issue was referenced by a75ac18638

This issue was referenced by a75ac18638f41d8b427b7519628602b6be54d995

Bastien Montagne commented

2019-02-13 17:21:10 +01:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2019-02-13 17:21:10 +01:00

Philipp Oeser commented

2019-03-09 18:26:33 +01:00

Changed status from 'Resolved' to: 'Open'

Philipp Oeser reopened this issue

2019-03-09 18:26:33 +01:00

Philipp Oeser commented

2019-03-09 18:26:33 +01:00

Looks like this popped up again (#62393).
@mont29: I can confirm that making a new material from the template IDTemplate widget duplicates the action, whereas making it a single user still doesnt.

Looks like this popped up again (#62393). @mont29: I can confirm that making **a new** material from the template IDTemplate widget duplicates the action, whereas **making it a single user** still doesnt.

Philipp Oeser commented

2019-03-09 18:27:45 +01:00

Added subscriber: @VladimirKunyansky

Philipp Oeser commented

2019-03-09 18:39:18 +01:00

Hm, BKE_animdata_from_id() returns NULL in BKE_animdata_copy_id_action() when doing this?
Gotta go now, but will have another look later...

Hm, `BKE_animdata_from_id()` returns NULL in `BKE_animdata_copy_id_action() `when doing this? Gotta go now, but will have another look later...

Bastien Montagne commented

2019-03-09 20:12:47 +01:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2019-03-09 20:12:47 +01:00

Bastien Montagne commented

2019-03-09 20:12:47 +01:00

Please do not merge just because issues are similar, those remain two different things.

Philipp Oeser commented

2019-03-09 21:47:40 +01:00

So we have id_single_user() vs. single_mat_users()

id_single_user() doesnt traverse down the nodetree and doesnt copy nodetrees action, whereas single_mat_users() does.
Same thing is happening in 2.79

I am not exactly sure if we would always want the behavior of copying actions here, but if in doubt, my vote would go for it, patch incoming...

So we have `id_single_user()` vs. `single_mat_users()` `id_single_user()` doesnt traverse down the nodetree and doesnt copy nodetrees action, whereas `single_mat_users()` does. Same thing is happening in 2.79 I am not exactly sure if we would **always** want the behavior of copying actions here, but if in doubt, my vote would go for it, patch incoming...

Philipp Oeser commented

2019-03-09 21:54:55 +01:00

@mont29: oki, posted patch for #62393 then...

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Keyframed node properties stay linked after shading network duplication #59062