Page MenuHome

Subdivision Surface Modifier on meshes without faces does not work in editmode
Closed, ResolvedPublic

Description

System Information
Operating system:
Graphics card:

Blender Version
Broken:
(example: 2.79b release)
(example: 2.80, edbf15d3c044, blender2.8, 2018-11-28, as found on the splash screen)
Worked: (optional)

Short description of error

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

In Edit Mode when i want to Mesh curve circle segments make smooth with using modifier - subdivision surface , its not be in smooth toggle like 2.79 . Please can fix this bug . Thank you. Regards. Pierre

Event Timeline

In Edit Mode when i want to Mesh curve circle segments make smooth with using modifier - subdivision surface , its not be in smooth toggle like 2.79 . Please can fix this bug . Thank you. Regards. Pierre

name

Philipp Oeser (lichtwerk) renamed this task from bout Mesh Curve circle in Subdivision Modifiers not work , when i toggle to smooth its not work in 2.8 to Subdivision Surface Modifier on meshes without faces does not work in editmode.Dec 13 2018, 12:14 PM

Hi Sergey , i uploaded blender-2.80-7d4d9e9dbd3-win64 in December 13 today , still bug not fix as i checked .I think before 2 or 3 days was fixed but last 2 days when i uploaded updated Blender its still . Can please fix it .
Thank you.
Appreciate your work.
Best Regards.
Pierre
https://photos.app.goo.gl/pna5FWVGmfjYqX429

Thank you Philipp i appreciate your work too , hope will fix bugs soon , today i tried still not fix.
Thank you Philipp and Sergey .
Best Regards.
Pierre

Well, not sure why one would expect bug to be fixed in the nightly builds, the report is still marked as Open.. We fix bugs as soon as time frame allows us. Is not like we don't fix them to keep artists unhappy. But keep in mind, we've got 100 times more open reports than developers dealing with those..
Bit of patience, my friend ;)

@Clément Foucault (fclem), actually, i am not sure what's going on there. As for subdiv modifier i generate all edges and set the render flag. Mind having a loot and tell if it's anything specific draw manager is missing? Or maybe it's something totally in the control of draw manager?

Hello ,
I did short video compare between 2.79 and 2.8 for Mesh Circle Curve how its work during in subdivision modifier smooth and quad toggle in 2.79 its work fine smooth toggle but in 2.8 still not work in smooth toggle in edit mode .
Please check video example.
Thank you.
Regards.
Pierre

https://photos.app.goo.gl/rrGU5iE7GjJ4edUy9

This is the solution that came to my mind (but I did not consider all cases):

diff --git a/source/blender/draw/intern/draw_cache_impl_mesh.c b/source/blender/draw/intern/draw_cache_impl_mesh.c
index 3037a2fe225..c7b5c4853c2 100644
--- a/source/blender/draw/intern/draw_cache_impl_mesh.c
+++ b/source/blender/draw/intern/draw_cache_impl_mesh.c
@@ -474,8 +474,8 @@ static MeshRenderData *mesh_render_data_create_ex(
 			rdata->mapped.l_origindex = CustomData_get_layer(&me_cage->ldata, CD_ORIGINDEX);
 			rdata->mapped.p_origindex = CustomData_get_layer(&me_cage->pdata, CD_ORIGINDEX);
 			rdata->mapped.supported = (
-			        rdata->mapped.v_origindex &&
-			        rdata->mapped.e_origindex &&
+			        rdata->mapped.v_origindex ||
+			        rdata->mapped.e_origindex ||
 			        rdata->mapped.p_origindex);
 		}

(I noticed that there is also a bug in the selection of loose edges vertices).

Hello please can fix this bug in Blender 2.8 , still not fixed , if you please fix it .
Thank you.
Regards.
Pierre

Ok Thank you .
Regards.
Pierre