View Layer - Search not working #59322

New Issue

Marcus Papathoma · 2018-12-13T17:28:34+01:00

Marcus Papathoma commented

2018-12-13 17:28:34 +01:00

System Information
Operating system:
Windows 10 x64
Graphics card:
Nvidia Geforce GTX 1080Ti

Blender Version
Broken: 2.80, 7d4d9e9dbd

Short description of error
The Search in the View Layer drop down menu isn´t working

Exact steps for others to reproduce the error
Open the attached blend file.
Open the View Layer popup and write "Test" into the search field. Nothing happens.
The first View Layer ist called test.
View_Layer_search_bug.blend

**System Information** Operating system: Windows 10 x64 Graphics card: Nvidia Geforce GTX 1080Ti **Blender Version** Broken: 2.80, 7d4d9e9dbd3 **Short description of error** The Search in the View Layer drop down menu isn´t working **Exact steps for others to reproduce the error** Open the attached blend file. Open the View Layer popup and write "Test" into the search field. Nothing happens. The first View Layer ist called test. [View_Layer_search_bug.blend](https://archive.blender.org/developer/F5943340/View_Layer_search_bug.blend) ![View_Layer_search_bug.jpg](https://archive.blender.org/developer/F5943354/View_Layer_search_bug.jpg)

Marcus Papathoma commented

2018-12-13 17:28:34 +01:00

Added subscriber: @machieb

Dalai Felinto self-assigned this 2018-12-14 12:40:49 +01:00

Dalai Felinto commented

2018-12-14 14:23:39 +01:00

Basically when we get to ui_rna_collection_search_cb skip_filter is always true because in those cases data->but_changed is NULL for those buttons.

Basically when we get to `ui_rna_collection_search_cb` skip_filter is always true because in those cases `data->but_changed` is NULL for those buttons.

Dalai Felinto commented

2018-12-14 15:17:28 +01:00

Tempted to remove the skip_filter altogether, or at least to never skip when there is no but_changed.
For the records, this works: P870

The way we are using this "but_changed" seems wrong anyways.

Tempted to remove the skip_filter altogether, or at least to never skip when there is no but_changed. For the records, this works: [P870](https://archive.blender.org/developer/P870.txt) The way we are using this "but_changed" seems wrong anyways.

Dalai Felinto commented

2018-12-14 17:56:17 +01:00

Added subscribers: @brecht, @JulianEisel

Dalai Felinto commented

2018-12-14 17:56:17 +01:00

@brecht are you familiar with this code? Have any opinion around which way to go?

Brecht Van Lommel commented

2018-12-14 18:46:23 +01:00

I hadn't seen this code before.

To me it seems but_changed should be removed, and filtering should only depend on str being empty or not.

I hadn't seen this code before. To me it seems `but_changed` should be removed, and filtering should only depend on `str` being empty or not.

Brecht Van Lommel commented

2018-12-14 18:50:19 +01:00

Although, I guess but_changed is needed for the case there is already a value in the text field, like when clicking to select a different bone?

In the search menu probably always setting it to true is ok as a fix.

Although, I guess `but_changed` is needed for the case there is already a value in the text field, like when clicking to select a different bone? In the search menu probably always setting it to true is ok as a fix.

blender-admin commented

2018-12-14 20:03:47 +01:00

This issue was referenced by fc74903f27

This issue was referenced by fc74903f272a01784e0376c9ee12c2673017285d

Dalai Felinto commented

2018-12-14 20:12:32 +01:00

You are right, but_changed is needed for those cases. Committing an alternative fix.

You are right, `but_changed` is needed for those cases. Committing an alternative fix.

Dalai Felinto commented

2018-12-14 20:14:09 +01:00

Changed status from 'Open' to: 'Resolved'

Dalai Felinto closed this issue

2018-12-14 20:14:09 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

View Layer - Search not working #59322