Grease Pencil Edit Mode: Individual Origins does not work #59546

New Issue

William Reynish · 2018-12-18T09:45:44+01:00

William Reynish commented

2018-12-18 09:45:44 +01:00

System Information
Operating system: macOS 10.14.2 (18C54)
Graphics card: AMD Radeon R9 M395X 4096 MB

Blender Version
Broken: Blender 2.80 beta Dec 18 2018

Short description of error
Grease Pencil Edit Mode: Individual Origins does not work

Exact steps for others to reproduce the error

Add a GP Object and draw some shapes
Go to Edit Mode and set pivot to Individual Origins

Rotate or Scale with all shapes selected. You'll see that the entire collection of shapes are transformed as a whole, rather than as individual items.

This blend file has two identical objects - one is a mesh and the other is a GP object:
GP_individual_origins_bug.blend
Enter Edit Mode for each and scale the items. Observe how the mesh object scales from the individual mesh islands, but the GP object in Edit Mode does not.

**System Information** Operating system: macOS 10.14.2 (18C54) Graphics card: AMD Radeon R9 M395X 4096 MB **Blender Version** Broken: Blender 2.80 beta Dec 18 2018 **Short description of error** Grease Pencil Edit Mode: Individual Origins does not work **Exact steps for others to reproduce the error** - Add a GP Object and draw some shapes - Go to Edit Mode and set pivot to Individual Origins # Rotate or Scale with all shapes selected. You'll see that the entire collection of shapes are transformed as a whole, rather than as individual items. This blend file has two identical objects - one is a mesh and the other is a GP object: [GP_individual_origins_bug.blend](https://archive.blender.org/developer/F5990956/GP_individual_origins_bug.blend) Enter Edit Mode for each and scale the items. Observe how the mesh object scales from the individual mesh islands, but the GP object in Edit Mode does not.

William Reynish commented

2018-12-18 09:45:44 +01:00

Added subscriber: @WilliamReynish

Antonio Vazquez commented

2018-12-18 10:26:33 +01:00

Added subscribers: @brecht, @antoniov

Antonio Vazquez commented

2018-12-18 10:26:33 +01:00

@brecht you changed how the origin was calculated because I did not know this area of the code. Could you take a look on this?

Antonio Vazquez was assigned by Brecht Van Lommel

2018-12-18 17:54:27 +01:00

Brecht Van Lommel commented

2018-12-18 17:54:27 +01:00

This is just not implemented for grease pencil. I think it mainly needs changes in transform_conversions.c. See for example how createTransEditVerts does it for edit mesh. It seems to work roughly like this:

Compute which vertices belong to the same "island", that is which vertices are connected to each other. Not sure what the equivalent is for grease pencil, maybe just points in the same stroke? I guess there is not any more connectivity information, unless you try to do something clever with detecting overlapping strokes.
Then for each vertex, it sets a td->center and td->axismtxto the center and axis of the island it belongs to, rather than using the same values for all.

This is just not implemented for grease pencil. I think it mainly needs changes in `transform_conversions.c`. See for example how `createTransEditVerts` does it for edit mesh. It seems to work roughly like this: * Compute which vertices belong to the same "island", that is which vertices are connected to each other. Not sure what the equivalent is for grease pencil, maybe just points in the same stroke? I guess there is not any more connectivity information, unless you try to do something clever with detecting overlapping strokes. * Then for each vertex, it sets a `td->center` and `td->axismtx`to the center and axis of the island it belongs to, rather than using the same values for all.

Antonio Vazquez commented

2018-12-18 18:47:45 +01:00

@brecht I see what you mean. I will try to implement that.

Antonio Vazquez commented

2018-12-18 19:42:13 +01:00

@brecht I created this code P875 but still does not work. I have checked and the center is right by stroke (local coords). What am I missing?

The matrix is filled with this code:

/* apply parent transformations */
copy_m3_m4(td->smtx, inverse_diff_mat); /* final position */
copy_m3_m4(td->mtx, diff_mat);  /* display position */
copy_m3_m4(td->axismtx, diff_mat); /* axis orientation */

@brecht I created this code [P875](https://archive.blender.org/developer/P875.txt) but still does not work. I have checked and the center is right by stroke (local coords). What am I missing? The matrix is filled with this code: ``` /* apply parent transformations */ copy_m3_m4(td->smtx, inverse_diff_mat); /* final position */ copy_m3_m4(td->mtx, diff_mat); /* display position */ copy_m3_m4(td->axismtx, diff_mat); /* axis orientation */ ```

Habib Gahbiche commented

2018-12-19 00:22:58 +01:00

Added subscriber: @zazizizou

Habib Gahbiche commented

2019-01-02 21:32:07 +01:00

@antoniov: I submitted a patch to fix this: D4156. Center computation was done correctly, the problem was that transdata_check_local_center() didn't support GP objects.

@antoniov: I submitted a patch to fix this: [D4156](https://archive.blender.org/developer/D4156). Center computation was done correctly, the problem was that `transdata_check_local_center()` didn't support GP objects.

blender-admin commented

2019-01-04 17:01:39 +01:00

This issue was referenced by 38796a4971

This issue was referenced by 38796a4971afdd58e58bcfe043fbdb21153dfcc2

Antonio Vazquez commented

2019-01-04 17:02:00 +01:00

Changed status from 'Open' to: 'Resolved'

Antonio Vazquez closed this issue

2019-01-04 17:02:00 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Grease Pencil Edit Mode: Individual Origins does not work #59546

Rotate or Scale with all shapes selected. You'll see that the entire collection of shapes are transformed as a whole, rather than as individual items.