Crashes in "mesh_create_loops_tris()" #59696

New Issue

Martin Capitanio · 2018-12-20T23:58:19+01:00

Martin Capitanio commented

2018-12-20 23:58:19 +01:00

System Information
Linux

Blender Version
b49699b1ec

Short description of error
After selecting "Overlays->Face Orientation" or "Overlays->Hidden Wire"
in similar models like this, Blender crashes:

crash02-03.blend

Backtrace

The array const MPoly *mp = &rdata->mpoly[mlt->poly];
returns here a null pointer:

Thread 1 "blender8tip" received signal SIGSEGV, Segmentation fault.
0x0000555556cebba4 in mesh_create_loops_tris (rdata=rdata@entry=0x7fffaa6ae508, ibo=ibo@entry=0x7fffab7460a0, ibo_len=ibo_len@entry=1, use_hide=use_hide@entry=true)
    at /intranet/blender-build/blender-git/source/blender/draw/intern/draw_cache_impl_mesh.c:4385
4385					if (use_hide && (mp->flag & ME_HIDE)) {
(gdb) bt
#0  0x0000555556cebba4 in mesh_create_loops_tris (rdata=rdata@entry=0x7fffaa6ae508, ibo=ibo@entry=0x7fffab7460a0, ibo_len=ibo_len@entry=1, use_hide=use_hide@entry=true)
    at /intranet/blender-build/blender-git/source/blender/draw/intern/draw_cache_impl_mesh.c:4385
#1  0x0000555556cf27d9 in DRW_mesh_batch_cache_create_requested (ob=ob@entry=0x7fffac757c08, me=0x7fffffffcc60)
    at /intranet/blender-build/blender-git/source/blender/draw/intern/draw_cache_impl_mesh.c:5508
- 2  0x0000555556d3e7dc in drw_batch_cache_generate_requested (ob=ob@entry=0x7fffac757c08) at /intranet/blender-build/blender-git/source/blender/draw/intern/draw_cache.c:3743
- 3  0x0000555556cf67d1 in drw_engines_cache_populate (ob=0x7fffac757c08) at /intranet/blender-build/blender-git/source/blender/draw/intern/draw_manager.c:1023
- 4  0x0000555556cf7bd3 in DRW_draw_render_loop_ex (depsgraph=0x7fffcc7fc908, engine_type=<optimized out>, ar=0x7fffac735908, v3d=0x7fffaed03208, viewport=0x7fffac7fd608, evil_C=evil_C@entry=0x7fffce86d408) at /intranet/blender-build/blender-git/source/blender/draw/intern/draw_manager.c:1483
- 5  0x0000555556cf814b in DRW_draw_view (C=C@entry=0x7fffce86d408) at /intranet/blender-build/blender-git/source/blender/draw/intern/draw_manager.c:1409
- 6  0x00005555567acfe7 in view3d_draw_view (ar=0x7fffac735908, C=0x7fffce86d408) at /intranet/blender-build/blender-git/source/blender/editors/space_view3d/view3d_draw.c:1334
- 7  0x00005555567acfe7 in view3d_main_region_draw (C=0x7fffce86d408, ar=0x7fffac735908) at /intranet/blender-build/blender-git/source/blender/editors/space_view3d/view3d_draw.c:1355
- 8  0x00005555569dca21 in ED_region_do_draw (C=C@entry=0x7fffce86d408, ar=ar@entry=0x7fffac735908) at /intranet/blender-build/blender-git/source/blender/editors/screen/area.c:529
- 9  0x00005555566cbde1 in wm_draw_window_offscreen (stereo=false, win=0x7fffac374c88, C=0x7fffce86d408) at /intranet/blender-build/blender-git/source/blender/windowmanager/intern/wm_draw.c:580
- 10 0x00005555566cbde1 in wm_draw_window (win=0x7fffac374c88, C=0x7fffce86d408) at /intranet/blender-build/blender-git/source/blender/windowmanager/intern/wm_draw.c:712
- 11 0x00005555566cbde1 in wm_draw_update (C=C@entry=0x7fffce86d408) at /intranet/blender-build/blender-git/source/blender/windowmanager/intern/wm_draw.c:866
- 12 0x00005555566c9f10 in WM_main (C=0x7fffce86d408) at /intranet/blender-build/blender-git/source/blender/windowmanager/intern/wm.c:433
- 13 0x000055555667d531 in main (argc=1, argv=0x7fffffffdce8) at /intranet/blender-build/blender-git/source/creator/creator.c:521
(gdb) l
4380			}
4381			else {
4382				for (int i = 0; i < tri_len; i++) {
4383					const MLoopTri *mlt = &rdata->mlooptri[i];
4384					const MPoly *mp = &rdata->mpoly[mlt->poly];
-> 4385					if (use_hide && (mp->flag & ME_HIDE)) {
4386						continue;
4387					}
4388					int mat = (ibo_len > 1) ? mp->mat_nr : 0;
4389					GPU_indexbuf_add_tri_verts(&elb[mat], mlt->tri[0], mlt->tri[1], mlt->tri[2]);

(gdb) info locals 
mlt = 0x7fffa6e90008
mp = 0x0
mat = <optimized out>
i = <optimized out>
loop_len = <optimized out>
tri_len = <optimized out>
elb = 0x7fffffffcac0

**System Information** Linux **Blender Version** b49699b1ec **Short description of error** After selecting "Overlays->Face Orientation" or "Overlays->Hidden Wire" in similar models like this, Blender crashes: ![image.png](https://archive.blender.org/developer/F6019939/image.png) [crash02-03.blend](https://archive.blender.org/developer/F6020013/crash02-03.blend) **Backtrace** The array `const MPoly *mp = &rdata->mpoly[mlt->poly];` returns here a null pointer: ``` Thread 1 "blender8tip" received signal SIGSEGV, Segmentation fault. 0x0000555556cebba4 in mesh_create_loops_tris (rdata=rdata@entry=0x7fffaa6ae508, ibo=ibo@entry=0x7fffab7460a0, ibo_len=ibo_len@entry=1, use_hide=use_hide@entry=true) at /intranet/blender-build/blender-git/source/blender/draw/intern/draw_cache_impl_mesh.c:4385 4385 if (use_hide && (mp->flag & ME_HIDE)) { (gdb) bt #0 0x0000555556cebba4 in mesh_create_loops_tris (rdata=rdata@entry=0x7fffaa6ae508, ibo=ibo@entry=0x7fffab7460a0, ibo_len=ibo_len@entry=1, use_hide=use_hide@entry=true) at /intranet/blender-build/blender-git/source/blender/draw/intern/draw_cache_impl_mesh.c:4385 #1 0x0000555556cf27d9 in DRW_mesh_batch_cache_create_requested (ob=ob@entry=0x7fffac757c08, me=0x7fffffffcc60) at /intranet/blender-build/blender-git/source/blender/draw/intern/draw_cache_impl_mesh.c:5508 - 2 0x0000555556d3e7dc in drw_batch_cache_generate_requested (ob=ob@entry=0x7fffac757c08) at /intranet/blender-build/blender-git/source/blender/draw/intern/draw_cache.c:3743 - 3 0x0000555556cf67d1 in drw_engines_cache_populate (ob=0x7fffac757c08) at /intranet/blender-build/blender-git/source/blender/draw/intern/draw_manager.c:1023 - 4 0x0000555556cf7bd3 in DRW_draw_render_loop_ex (depsgraph=0x7fffcc7fc908, engine_type=<optimized out>, ar=0x7fffac735908, v3d=0x7fffaed03208, viewport=0x7fffac7fd608, evil_C=evil_C@entry=0x7fffce86d408) at /intranet/blender-build/blender-git/source/blender/draw/intern/draw_manager.c:1483 - 5 0x0000555556cf814b in DRW_draw_view (C=C@entry=0x7fffce86d408) at /intranet/blender-build/blender-git/source/blender/draw/intern/draw_manager.c:1409 - 6 0x00005555567acfe7 in view3d_draw_view (ar=0x7fffac735908, C=0x7fffce86d408) at /intranet/blender-build/blender-git/source/blender/editors/space_view3d/view3d_draw.c:1334 - 7 0x00005555567acfe7 in view3d_main_region_draw (C=0x7fffce86d408, ar=0x7fffac735908) at /intranet/blender-build/blender-git/source/blender/editors/space_view3d/view3d_draw.c:1355 - 8 0x00005555569dca21 in ED_region_do_draw (C=C@entry=0x7fffce86d408, ar=ar@entry=0x7fffac735908) at /intranet/blender-build/blender-git/source/blender/editors/screen/area.c:529 - 9 0x00005555566cbde1 in wm_draw_window_offscreen (stereo=false, win=0x7fffac374c88, C=0x7fffce86d408) at /intranet/blender-build/blender-git/source/blender/windowmanager/intern/wm_draw.c:580 - 10 0x00005555566cbde1 in wm_draw_window (win=0x7fffac374c88, C=0x7fffce86d408) at /intranet/blender-build/blender-git/source/blender/windowmanager/intern/wm_draw.c:712 - 11 0x00005555566cbde1 in wm_draw_update (C=C@entry=0x7fffce86d408) at /intranet/blender-build/blender-git/source/blender/windowmanager/intern/wm_draw.c:866 - 12 0x00005555566c9f10 in WM_main (C=0x7fffce86d408) at /intranet/blender-build/blender-git/source/blender/windowmanager/intern/wm.c:433 - 13 0x000055555667d531 in main (argc=1, argv=0x7fffffffdce8) at /intranet/blender-build/blender-git/source/creator/creator.c:521 (gdb) l 4380 } 4381 else { 4382 for (int i = 0; i < tri_len; i++) { 4383 const MLoopTri *mlt = &rdata->mlooptri[i]; 4384 const MPoly *mp = &rdata->mpoly[mlt->poly]; -> 4385 if (use_hide && (mp->flag & ME_HIDE)) { 4386 continue; 4387 } 4388 int mat = (ibo_len > 1) ? mp->mat_nr : 0; 4389 GPU_indexbuf_add_tri_verts(&elb[mat], mlt->tri[0], mlt->tri[1], mlt->tri[2]); (gdb) info locals mlt = 0x7fffa6e90008 mp = 0x0 mat = <optimized out> i = <optimized out> loop_len = <optimized out> tri_len = <optimized out> elb = 0x7fffffffcac0 ```

Martin Capitanio commented

2018-12-20 23:58:19 +01:00

Added subscriber: @capnm